From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:470:142:3::10]:39682) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1j1aFT-0005hp-KK for guix-patches@gnu.org; Tue, 11 Feb 2020 13:27:04 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1j1aFS-0001Hb-Ld for guix-patches@gnu.org; Tue, 11 Feb 2020 13:27:03 -0500 Received: from debbugs.gnu.org ([209.51.188.43]:51550) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1j1aFS-0001Gx-HI for guix-patches@gnu.org; Tue, 11 Feb 2020 13:27:02 -0500 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1j1aFS-0000qg-CC for guix-patches@gnu.org; Tue, 11 Feb 2020 13:27:02 -0500 Subject: bug#39445: [PATCH v2 2/2] gnu: ripgrep: enable the 'pcre2' feature Resent-To: guix-patches@gnu.org Resent-Message-ID: Date: Tue, 11 Feb 2020 20:25:42 +0200 From: Efraim Flashner Message-ID: <20200211182542.GD26092@E5400> References: <20200209215110.6755-1-kuba@kadziolka.net> <20200209215110.6755-2-kuba@kadziolka.net> <20200210084351.GA26092@E5400> <20200210112813.cgs4hbra2konsz5j@gravity> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="IDYEmSnFhs3mNXr+" Content-Disposition: inline In-Reply-To: <20200210112813.cgs4hbra2konsz5j@gravity> List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+kyle=kyleam.com@gnu.org Sender: "Guix-patches" To: Jakub =?UTF-8?Q?K=C4=85dzio=C5=82ka?= Cc: 39445-done@debbugs.gnu.org --IDYEmSnFhs3mNXr+ Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Mon, Feb 10, 2020 at 12:28:13PM +0100, Jakub K=C4=85dzio=C5=82ka wrote: > On Mon, Feb 10, 2020 at 10:43:51AM +0200, Efraim Flashner wrote: > > Should the install phase also get the '--release' flag? >=20 > It's a reasonable question to ask, but no. `cargo install' will always > use a release build. Moreover, passing the --release flag to cargo > install will lead to an unexpected argument error. That's unfortunate. I was hoping to re-use the cargo-build-flags option. Might still be worth it, after adding logic to strip out the '--release' flag. Patches pushed. --=20 Efraim Flashner =D7=90=D7=A4=D7=A8=D7=99=D7=9D = =D7=A4=D7=9C=D7=A9=D7=A0=D7=A8 GPG key =3D A28B F40C 3E55 1372 662D 14F7 41AA E7DC CA3D 8351 Confidentiality cannot be guaranteed on emails sent or received unencrypted --IDYEmSnFhs3mNXr+ Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQIzBAABCgAdFiEEoov0DD5VE3JmLRT3Qarn3Mo9g1EFAl5C8aYACgkQQarn3Mo9 g1FSsw/9GDyLQF9j0KpE2NCw8Lv7eUjGgzdg033a4Z07zs0Fn1EbNOxCqAMzF+6q S0vkm99G8d6Fpbc/dycrKUPzB2PKoE0FVOYT+nORAGx0MlKX3FN9IdShGDwQaXyF Ne48SBzldgxvt9hvtFe5AbaZdml4TlNdQlsIuO9XPYafCfh3qcJveSHfXbbXn3N6 T6BM+klzLw9H9Kj7i/HIph0AUXgKkqeZHING6aDTr3BTVM1GvxCxSb2VVMGIZ/91 jpk1LFLehviKNK32WLT2XEn2sdI8zvUyf5ohc+dDNmxYi1RJy0FsuFx+XVlcRcnJ nP1AnJA1obbHH9gBQQo3GnU+Rukulj7yko1erPErXt3bi1pPcFuaJ/VpidceBCXO HEW00+lzQ3LeEXqf6Si252aZjKncTp8rFPWzd/x6luPYAA59d+xLbuZClocRcpBC 7zhK0zpSibogGw1dCZIT3mkwqODvlFRlVf5oyysd6FwaE3Im2359KfV3IxPRD6d1 b3Y4Xw7CP0d6NFV1EfQklpGCV0i79fyakJSp0WTfc9yP9F0BCRuPi+nkZN2SiHwv dDMh7ZMlJhX9qyqTUf3BbRh1XQxIUbXoh+WhiOLkKmkI3kGr8vKc23dZTrRmnasF G68DLbU7fLLmeOfuB3jheCxMNjfRC0yWlVy6kk6M635jia1zQSo= =L9c3 -----END PGP SIGNATURE----- --IDYEmSnFhs3mNXr+--