From: "Jakub Kądziołka" <kuba@kadziolka.net>
To: Leo Famulari <leo@famulari.name>
Cc: 39021@debbugs.gnu.org
Subject: [bug#39021] [PATCH] Add Keybase
Date: Tue, 11 Feb 2020 17:36:54 +0100 [thread overview]
Message-ID: <20200211163654.v5jz5bf7audo7unh@gravity> (raw)
In-Reply-To: <20200208002020.GD12194@jasmine.lan>
[-- Attachment #1: Type: text/plain, Size: 1457 bytes --]
> > From 3de233a2d8e6bdb4723844337b69b6612616c9c5 Mon Sep 17 00:00:00 2001
> > From: =?UTF-8?q?Jakub=20K=C4=85dzio=C5=82ka?= <kuba@kadziolka.net>
> > Date: Tue, 7 Jan 2020 20:29:21 +0100
> > Subject: [PATCH 2/2] gnu: Add keybase.
> >
> > * gnu/packages/crypto.scm
> > (keybase-component): New function.
> > (keybase, git-remote-keybase, kbfs): New variables.
>
> This is enough of it's own thing that we can make a new (gnu packages
> keybase) module.
Sure, will do.
> > +(define* (keybase-component #:key name repo-path synopsis description)
>
> We avoid abbreviations, so maybe "repository-path"? Bonus points if we
> can make it more descriptive.
I can't think of anything more descriptive, as it's literally the path
in the repository the component is at.
> Can you take a look at the bundled ("vendored") dependencies:
>
> https://github.com/keybase/client/tree/master/go/vendor
>
> We strive to avoid using these, but sometimes we do, as in the Docker
> package. It's not really idiomatic to unbundle things in Go. But we need
> to at least make sure all the bundled dependencies are freely licensed.
Apart from licensing concerns, what are the arguments for splitting this
into separate packages? I feel like this is just busywork...
> Also, please run `guix lint` on these packages and make sure the
> descriptions are written in complete sentences.
Ah, sure, somehow I forgot to do this before.
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
next prev parent reply other threads:[~2020-02-11 16:37 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-01-07 20:00 [bug#39021] [PATCH] Add Keybase Jakub Kądziołka
2020-01-24 18:34 ` [bug#39021] go package rebuilds Jakub Kądziołka
2020-01-28 21:54 ` [bug#39021] [PATCH 1/2 v2] build-system/go: Allow providing additional build flags Jakub Kądziołka
2020-02-08 0:20 ` [bug#39021] [PATCH] Add Keybase Leo Famulari
2020-02-11 16:36 ` Jakub Kądziołka [this message]
2020-02-11 17:36 ` Leo Famulari
2020-05-31 7:09 ` Efraim Flashner
2020-05-31 21:47 ` Jakub Kądziołka
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://guix.gnu.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200211163654.v5jz5bf7audo7unh@gravity \
--to=kuba@kadziolka.net \
--cc=39021@debbugs.gnu.org \
--cc=leo@famulari.name \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/guix.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).