From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:470:142:3::10]:56389) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1j1YX1-0006bD-MX for guix-patches@gnu.org; Tue, 11 Feb 2020 11:37:04 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1j1YX0-0007Wd-Je for guix-patches@gnu.org; Tue, 11 Feb 2020 11:37:03 -0500 Received: from debbugs.gnu.org ([209.51.188.43]:51443) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1j1YX0-0007WZ-GB for guix-patches@gnu.org; Tue, 11 Feb 2020 11:37:02 -0500 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1j1YX0-0004d2-F3 for guix-patches@gnu.org; Tue, 11 Feb 2020 11:37:02 -0500 Subject: [bug#39021] [PATCH] Add Keybase Resent-Message-ID: Date: Tue, 11 Feb 2020 17:36:54 +0100 From: Jakub =?UTF-8?Q?K=C4=85dzio=C5=82ka?= Message-ID: <20200211163654.v5jz5bf7audo7unh@gravity> References: <20200107200039.jga75muq7excgpqu@zdrowyportier.kadziolka.net> <20200208002020.GD12194@jasmine.lan> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="3gvbgjxfgdn3uwba" Content-Disposition: inline In-Reply-To: <20200208002020.GD12194@jasmine.lan> List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+kyle=kyleam.com@gnu.org Sender: "Guix-patches" To: Leo Famulari Cc: 39021@debbugs.gnu.org --3gvbgjxfgdn3uwba Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable > > From 3de233a2d8e6bdb4723844337b69b6612616c9c5 Mon Sep 17 00:00:00 2001 > > From: =3D?UTF-8?q?Jakub=3D20K=3DC4=3D85dzio=3DC5=3D82ka?=3D > > Date: Tue, 7 Jan 2020 20:29:21 +0100 > > Subject: [PATCH 2/2] gnu: Add keybase. > >=20 > > * gnu/packages/crypto.scm > > (keybase-component): New function. > > (keybase, git-remote-keybase, kbfs): New variables. >=20 > This is enough of it's own thing that we can make a new (gnu packages > keybase) module. Sure, will do. > > +(define* (keybase-component #:key name repo-path synopsis description) >=20 > We avoid abbreviations, so maybe "repository-path"? Bonus points if we > can make it more descriptive. I can't think of anything more descriptive, as it's literally the path in the repository the component is at. > Can you take a look at the bundled ("vendored") dependencies: >=20 > https://github.com/keybase/client/tree/master/go/vendor >=20 > We strive to avoid using these, but sometimes we do, as in the Docker > package. It's not really idiomatic to unbundle things in Go. But we need > to at least make sure all the bundled dependencies are freely licensed. Apart from licensing concerns, what are the arguments for splitting this into separate packages? I feel like this is just busywork... > Also, please run `guix lint` on these packages and make sure the > descriptions are written in complete sentences. Ah, sure, somehow I forgot to do this before. --3gvbgjxfgdn3uwba Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQIzBAEBCAAdFiEE5Xa/ss9usT31cTO54xWnWEYTFWQFAl5C2CEACgkQ4xWnWEYT FWRv+A//fqKTVj3IEWYOSUS7lHMiUYVpaQg/k5m0a9pmEP/L0BWegAhixRYrLKh6 fupoXjGxryPbKG6rOh2eiZ8F46lJSjrlPYyXdBgD5mwzQR/UZ7QuBKgu66BBPpiR 97JEMdPje6BO2ImYY+JlIeQWg1MpgrxmujqfGn3QeLxtD3w9HOtfSXsesU1n0gyb GHxK6hzlXI6Q5al2aEfEmGK7OG4ycCwLgPoIrZH0g+VuyGpufxTDCa69TN6aNT1n sqnuvizd1U0sfoDruVdphWCMGvyNrnzZTx8GHsYnd+i5yTTHYunQQ8f1ZoOgoFck uR4Xfcw9sQ2ytoHWUB6TwEhiF/dT/QUTERBT+WApSAp+ksSVwN7ZskB6wAGHvuTk G4D25zBk23gnDKeXj68zkmitQv/UqM8xirXQXOIV2195Q7+vNk1b8au9CIMSTNvC HDnSKdNAhvzf3pb7kCsNadMQ2DgPl1M9xMxR8k2JxWwokWxPrh4N/9CM2jmYBs0e 1gWIxABbC79mJuZqSAHMVR0LFX41RWuFrYQWU1LwlrYBzj8XPq0/o62418q2uaob mkEF8T03BpNEptHzj5UBzn7BZkmdQCPy8GmlTwRDJOL+1finU5QbGzejQZqkaNB6 S+elhku+3J/vTdFGoPAZPkO9QzH3fpep/0rJJbT6Ko0LRpaMwY4= =3uIp -----END PGP SIGNATURE----- --3gvbgjxfgdn3uwba--