* [bug#38954] gnu: gnome: Add missing inputs.
@ 2020-01-05 19:37 Raghav Gururajan
2020-01-07 23:41 ` Julien Lepiller
` (2 more replies)
0 siblings, 3 replies; 6+ messages in thread
From: Raghav Gururajan @ 2020-01-05 19:37 UTC (permalink / raw)
To: 38954
[-- Attachment #1: Type: text/plain, Size: 225 bytes --]
Hello Guix!
Please find the attached patch to add missing inputs for gnome.
NOTE: This patch depends on patches #38904, #38905, #38906, #38914, #38911, #38952, #38931, #38953 and #38935.
Thank you!
Regards,
RG.
[-- Attachment #2: gnome.patch --]
[-- Type: application/octet-stream, Size: 2436 bytes --]
From 6318bb6929770bf52a29b66d9ec78b79a771424b Mon Sep 17 00:00:00 2001
From: Raghav Gururajan <raghavgururajan@disroot.org>
Date: Sun, 5 Jan 2020 14:28:12 -0500
Subject: [PATCH] gnu: gnome: Add missing inputs.
* gnu/packages/gnome.scm (gnome): Add missing inputs.
---
gnu/packages/gnome.scm | 9 +++++++++
1 file changed, 9 insertions(+)
diff --git a/gnu/packages/gnome.scm b/gnu/packages/gnome.scm
index 2ffff4bcdb..c927400d21 100644
--- a/gnu/packages/gnome.scm
+++ b/gnu/packages/gnome.scm
@@ -7735,9 +7735,11 @@ associations for GNOME.")
("glib-networking" ,glib-networking)
("gnome-backgrounds" ,gnome-backgrounds)
("gnome-bluetooth" ,gnome-bluetooth)
+ ("gnome-color-manager" ,gnome-color-manager)
("gnome-control-center" ,gnome-control-center)
("gnome-desktop" ,gnome-desktop)
("gnome-getting-started-docs" ,gnome-getting-started-docs)
+ ("gnome-initial-setup" ,gnome-initial-setup)
("gnome-keyring" ,gnome-keyring)
("gnome-menus" ,gnome-menus)
("gnome-session" ,gnome-session)
@@ -7746,10 +7748,13 @@ associations for GNOME.")
("gnome-shell" ,gnome-shell)
("gnome-themes-extra" ,gnome-themes-extra)
("gnome-user-docs" ,gnome-user-docs)
+ ("gnome-user-share" ,gnome-user-share)
("gsettings-desktop-schemas" ,gsettings-desktop-schemas)
("gvfs" ,gvfs)
("mutter" ,mutter)
("orca" ,orca)
+ ("rygel" ,rygel)
+ ("sushi" ,sushi)
;; GNOME-Core-Utilities
("baobab" ,baobab)
("cheese" ,cheese)
@@ -7758,6 +7763,7 @@ associations for GNOME.")
("evince" ,evince)
("file-roller" ,file-roller)
("gedit" ,gedit)
+ ("gnome-boxes" ,gnome-boxes)
("gnome-calculator" ,gnome-calculator)
("gnome-calendar" ,gnome-calendar)
("gnome-characters" ,gnome-characters)
@@ -7766,9 +7772,12 @@ associations for GNOME.")
("gnome-disk-utility" ,gnome-disk-utility)
("gnome-font-viewer" ,gnome-font-viewer)
("gnome-maps" ,gnome-maps)
+ ("gnome-music" ,gnome-music)
+ ("gnome-photos" ,gnome-photos)
("gnome-screenshot" ,gnome-screenshot)
("gnome-system-monitor" ,gnome-system-monitor)
("gnome-terminal" ,gnome-terminal)
+ ("gnome-weather" ,gnome-weather)
("nautilus" ,nautilus)
("simple-scan" ,simple-scan)
("totem" ,totem)
--
2.24.1
^ permalink raw reply related [flat|nested] 6+ messages in thread
* [bug#38954] gnu: gnome: Add missing inputs.
2020-01-05 19:37 [bug#38954] gnu: gnome: Add missing inputs Raghav Gururajan
@ 2020-01-07 23:41 ` Julien Lepiller
2020-01-08 9:32 ` Raghav Gururajan
2020-01-12 21:04 ` [bug#38954] v3 Raghav Gururajan
2 siblings, 0 replies; 6+ messages in thread
From: Julien Lepiller @ 2020-01-07 23:41 UTC (permalink / raw)
To: Raghav Gururajan; +Cc: 38954
Le Sun, 05 Jan 2020 19:37:45 +0000,
"Raghav Gururajan" <raghavgururajan@disroot.org> a écrit :
> Hello Guix!
>
> Please find the attached patch to add missing inputs for gnome.
>
> NOTE: This patch depends on patches #38904, #38905, #38906, #38914,
> #38911, #38952, #38931, #38953 and #38935.
>
> Thank you!
>
> Regards,
> RG.
Hi raghav,
you've built a maze of patches which makes it difficult for us (at
least for me) to review. I'd like to encourage you to report all of
these patches under only one bug. You can use apply all your patches
locally on a single branch, and use git send-email (from git:send-email
package) to send and format the messages properly. Please add them in
an order that makes sense (dependencies first) so that at every commit,
everything builds fine.
Thanks in advance!
^ permalink raw reply [flat|nested] 6+ messages in thread
* [bug#38954] gnu: gnome: Add missing inputs.
2020-01-05 19:37 [bug#38954] gnu: gnome: Add missing inputs Raghav Gururajan
2020-01-07 23:41 ` Julien Lepiller
@ 2020-01-08 9:32 ` Raghav Gururajan
2020-01-12 21:04 ` [bug#38954] v3 Raghav Gururajan
2 siblings, 0 replies; 6+ messages in thread
From: Raghav Gururajan @ 2020-01-08 9:32 UTC (permalink / raw)
To: Julien Lepiller; +Cc: 38954
Hello Jan!
> you've built a maze of patches which makes it difficult for us (at
> least for me) to review. I'd like to encourage you to report all of
> these patches under only one bug. You can use apply all your patches
> locally on a single branch, and use git send-email (from git:send-email
> package) to send and format the messages properly. Please add them in
> an order that makes sense (dependencies first) so that at every commit,
> everything builds fine.
>
> Thanks in advance!
Sorry that I created confusion. I will do it better with future patches.
For these, let me put a flow chart for the order in which the patches are to be pushed.
[1] 38904
[2] 38905
[3] 38906
[4] 38914 (38894 --> 38896 --> 38898 --> 38901 --> 38914)
[5] 38911 (38909 --> 38911)
[6] 38931 (38930 --> 38931)
[7] 38953
[8] 38935
[9] 38954
Please let me know if you have any questions.
Thank you!
Regards,
RG.
^ permalink raw reply [flat|nested] 6+ messages in thread
* [bug#38954] v3
2020-01-05 19:37 [bug#38954] gnu: gnome: Add missing inputs Raghav Gururajan
2020-01-07 23:41 ` Julien Lepiller
2020-01-08 9:32 ` Raghav Gururajan
@ 2020-01-12 21:04 ` Raghav Gururajan
2020-01-23 1:54 ` Danny Milosavljevic
2 siblings, 1 reply; 6+ messages in thread
From: Raghav Gururajan @ 2020-01-12 21:04 UTC (permalink / raw)
To: 38954
[-- Attachment #1: Type: text/plain, Size: 104 bytes --]
Hello Guix!
Please find the revised patch (v3) for gnome attached with this email.
Regards,
RG.
[-- Attachment #2: gnome.patch --]
[-- Type: application/octet-stream, Size: 2944 bytes --]
From 8cee53668ea778dacf940f076ae353543026fa7a Mon Sep 17 00:00:00 2001
From: Raghav Gururajan <raghavgururajan@disroot.org>
Date: Sun, 12 Jan 2020 16:00:21 -0500
Subject: [PATCH] gnu: gnome: Add missing inputs.
* gnu/packages/gnome.scm (gnome): Add missing inputs.
---
gnu/packages/gnome.scm | 11 ++++++++++-
1 file changed, 10 insertions(+), 1 deletion(-)
diff --git a/gnu/packages/gnome.scm b/gnu/packages/gnome.scm
index 8f0967a513..4fad0b1700 100644
--- a/gnu/packages/gnome.scm
+++ b/gnu/packages/gnome.scm
@@ -42,7 +42,7 @@
;;; Copyright © 2019 Maxim Cournoyer <maxim.cournoyer@gmail.com>
;;; Copyright © 2019 Martin Becze <mjbecze@riseup.net>
;;; Copyright © 2019 David Wilson <david@daviwil.com>
-;;; Copyright © 2019 Raghav Gururajan <raghavgururajan@disroot.org>
+;;; Copyright © 2019, 2020 Raghav Gururajan <raghavgururajan@disroot.org>
;;; Copyright © 2019 Jonathan Brielmaier <jonathan.brielmaier@web.de>
;;; Copyright © 2019 Leo Prikler <leo.prikler@student.tugraz.at>
;;;
@@ -7339,9 +7339,11 @@ associations for GNOME.")
("glib-networking" ,glib-networking)
("gnome-backgrounds" ,gnome-backgrounds)
("gnome-bluetooth" ,gnome-bluetooth)
+ ("gnome-color-manager" ,gnome-color-manager)
("gnome-control-center" ,gnome-control-center)
("gnome-desktop" ,gnome-desktop)
("gnome-getting-started-docs" ,gnome-getting-started-docs)
+ ("gnome-initial-setup" ,gnome-initial-setup)
("gnome-keyring" ,gnome-keyring)
("gnome-menus" ,gnome-menus)
("gnome-session" ,gnome-session)
@@ -7350,10 +7352,13 @@ associations for GNOME.")
("gnome-shell" ,gnome-shell)
("gnome-themes-extra" ,gnome-themes-extra)
("gnome-user-docs" ,gnome-user-docs)
+ ("gnome-user-share" ,gnome-user-share)
("gsettings-desktop-schemas" ,gsettings-desktop-schemas)
("gvfs" ,gvfs)
("mutter" ,mutter)
("orca" ,orca)
+ ("rygel" ,rygel)
+ ("sushi" ,sushi)
;; GNOME-Core-Utilities
("baobab" ,baobab)
("cheese" ,cheese)
@@ -7362,6 +7367,7 @@ associations for GNOME.")
("evince" ,evince)
("file-roller" ,file-roller)
("gedit" ,gedit)
+ ("gnome-boxes" ,gnome-boxes)
("gnome-calculator" ,gnome-calculator)
("gnome-calendar" ,gnome-calendar)
("gnome-characters" ,gnome-characters)
@@ -7370,9 +7376,12 @@ associations for GNOME.")
("gnome-disk-utility" ,gnome-disk-utility)
("gnome-font-viewer" ,gnome-font-viewer)
("gnome-maps" ,gnome-maps)
+ ("gnome-music" ,gnome-music)
+ ("gnome-photos" ,gnome-photos)
("gnome-screenshot" ,gnome-screenshot)
("gnome-system-monitor" ,gnome-system-monitor)
("gnome-terminal" ,gnome-terminal)
+ ("gnome-weather" ,gnome-weather)
("nautilus" ,nautilus)
("simple-scan" ,simple-scan)
("totem" ,totem)
--
2.24.1
^ permalink raw reply related [flat|nested] 6+ messages in thread
* [bug#38954] v3
2020-01-12 21:04 ` [bug#38954] v3 Raghav Gururajan
@ 2020-01-23 1:54 ` Danny Milosavljevic
2022-01-07 4:47 ` [bug#38954] gnu: gnome: Add missing inputs Maxim Cournoyer
0 siblings, 1 reply; 6+ messages in thread
From: Danny Milosavljevic @ 2020-01-23 1:54 UTC (permalink / raw)
To: Raghav Gururajan; +Cc: 38954
[-- Attachment #1: Type: text/plain, Size: 218 bytes --]
Pushed to guix master as commit d36fa50fbf8169018193774782fd21f1b13b9c0e
with commented-out gnome-boxes, gnome-music, gnome-photos
and changed commit message.
Leaving bug report open since it's not everything.
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
^ permalink raw reply [flat|nested] 6+ messages in thread
* [bug#38954] gnu: gnome: Add missing inputs.
2020-01-23 1:54 ` Danny Milosavljevic
@ 2022-01-07 4:47 ` Maxim Cournoyer
0 siblings, 0 replies; 6+ messages in thread
From: Maxim Cournoyer @ 2022-01-07 4:47 UTC (permalink / raw)
To: Danny Milosavljevic; +Cc: Raghav Gururajan, 38954
Hi Danny and Raghav,
Danny Milosavljevic <dannym@scratchpost.org> writes:
> Pushed to guix master as commit d36fa50fbf8169018193774782fd21f1b13b9c0e
> with commented-out gnome-boxes, gnome-music, gnome-photos
> and changed commit message.
>
> Leaving bug report open since it's not everything.
This is old. Is there some action to do, or is it OK to close it?
Thanks,
Maxim
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2022-01-07 4:48 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-01-05 19:37 [bug#38954] gnu: gnome: Add missing inputs Raghav Gururajan
2020-01-07 23:41 ` Julien Lepiller
2020-01-08 9:32 ` Raghav Gururajan
2020-01-12 21:04 ` [bug#38954] v3 Raghav Gururajan
2020-01-23 1:54 ` Danny Milosavljevic
2022-01-07 4:47 ` [bug#38954] gnu: gnome: Add missing inputs Maxim Cournoyer
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/guix.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).