unofficial mirror of guix-patches@gnu.org 
 help / color / mirror / code / Atom feed
From: Danny Milosavljevic <dannym@scratchpost.org>
To: Reza Alizadeh Majd <r.majd@pantherx.org>
Cc: 39004@debbugs.gnu.org
Subject: [bug#39004] [PATCH] gnu: pcmanfm-qt: fix open file issue
Date: Tue, 7 Jan 2020 10:52:14 +0100	[thread overview]
Message-ID: <20200107105214.502793d3@scratchpost.org> (raw)
In-Reply-To: <9b9644a5-b79d-4293-8311-762a49f46a12@www.fastmail.com>

[-- Attachment #1: Type: text/plain, Size: 825 bytes --]

Hi Reza,

thanks for the patch.  I think that it is the right way for now.

But GIO_LAUNCH_DESKTOP is not interpreted as a list by glib.

It would be better to communicate intent by constructing GIO_LAUNCH_DESKTOP as

               (wrap-program (string-append out "/bin/pcmanfm-qt")
                 `("GIO_LAUNCH_DESKTOP" =
                   (,(string-append glib "/bin/gio-launch-desktop"))))

.

Otherwise, with ":" and "prefix" it very much sounded like a list.

Also, could you make it check whether /bin/gio-launch-desktop exists and
error out otherwise?  That is in order for us to notice the workaround
later when we move the gio-launch-desktop executable.

(if (file-exists? ".........../bin/gio-launch-desktop")
    (wrap-program ........)
    (error "Could not find gio-launch-desktop"))

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

  reply	other threads:[~2020-01-07  9:53 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-01-07  8:00 [bug#39004] [PATCH] gnu: pcmanfm-qt: fix open file issue Reza Alizadeh Majd
2020-01-07  9:52 ` Danny Milosavljevic [this message]
2020-01-07 10:17   ` Reza Alizadeh Majd
2020-01-11  7:38     ` Reza Alizadeh Majd
2020-01-11 20:28       ` bug#39004: " Marius Bakke

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://guix.gnu.org/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20200107105214.502793d3@scratchpost.org \
    --to=dannym@scratchpost.org \
    --cc=39004@debbugs.gnu.org \
    --cc=r.majd@pantherx.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/guix.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).