From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:470:142:3::10]:46866) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1iolXr-0003xe-C8 for guix-patches@gnu.org; Tue, 07 Jan 2020 04:53:04 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1iolXq-0007SB-Br for guix-patches@gnu.org; Tue, 07 Jan 2020 04:53:03 -0500 Received: from debbugs.gnu.org ([209.51.188.43]:41295) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1iolXq-0007S3-8d for guix-patches@gnu.org; Tue, 07 Jan 2020 04:53:02 -0500 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1iolXq-0005Qn-6n for guix-patches@gnu.org; Tue, 07 Jan 2020 04:53:02 -0500 Subject: [bug#39004] [PATCH] gnu: pcmanfm-qt: fix open file issue Resent-Message-ID: Date: Tue, 7 Jan 2020 10:52:14 +0100 From: Danny Milosavljevic Message-ID: <20200107105214.502793d3@scratchpost.org> In-Reply-To: <9b9644a5-b79d-4293-8311-762a49f46a12@www.fastmail.com> References: <9b9644a5-b79d-4293-8311-762a49f46a12@www.fastmail.com> MIME-Version: 1.0 Content-Type: multipart/signed; boundary="Sig_/kBqHBcAKH.snKrC5T2EkKl+"; protocol="application/pgp-signature"; micalg=pgp-sha256 List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+kyle=kyleam.com@gnu.org Sender: "Guix-patches" To: Reza Alizadeh Majd Cc: 39004@debbugs.gnu.org --Sig_/kBqHBcAKH.snKrC5T2EkKl+ Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: quoted-printable Hi Reza, thanks for the patch. I think that it is the right way for now. But GIO_LAUNCH_DESKTOP is not interpreted as a list by glib. It would be better to communicate intent by constructing GIO_LAUNCH_DESKTOP= as (wrap-program (string-append out "/bin/pcmanfm-qt") `("GIO_LAUNCH_DESKTOP" =3D (,(string-append glib "/bin/gio-launch-desktop")))) . Otherwise, with ":" and "prefix" it very much sounded like a list. Also, could you make it check whether /bin/gio-launch-desktop exists and error out otherwise? That is in order for us to notice the workaround later when we move the gio-launch-desktop executable. (if (file-exists? ".........../bin/gio-launch-desktop") (wrap-program ........) (error "Could not find gio-launch-desktop")) --Sig_/kBqHBcAKH.snKrC5T2EkKl+ Content-Type: application/pgp-signature Content-Description: OpenPGP digital signature -----BEGIN PGP SIGNATURE----- iQEzBAEBCAAdFiEEds7GsXJ0tGXALbPZ5xo1VCwwuqUFAl4UVM4ACgkQ5xo1VCww uqXYjAgAoM1NyG8zzLGjIwqFl9Zsr9LvgzCy+mYQjwjxKHXJCLRfrrpHhI/mc8IG hN+bOqBL0wVTxNMnL+4p44uUF9ufr6exRtzny7LKwiaKEUl+T8Lr0RMCc+T47piC g6e2njvo3Zt/Jj8+9gyOFmvJ+Fxf7RSl4BVECcpkBa9z69zJuFE8wwdKlbwlWdV1 O79P2kYppqh71J+iiQDYkLIu9kxvbiS+SwSyGC7Q1qv0Y8qWxhsXSG7p711Rrgjf vuGcHw6lkAvqSgxLYB4GaATnbk+t2Wvgky2ZKTo4yG2sNPGQKp6mkQ4UF4+XGNTT 7tLs3dsdTfZ0Kvv2AD5zdb8Q51bfAQ== =82Dc -----END PGP SIGNATURE----- --Sig_/kBqHBcAKH.snKrC5T2EkKl+--