unofficial mirror of guix-patches@gnu.org 
 help / color / mirror / code / Atom feed
From: Danny Milosavljevic <dannym@scratchpost.org>
To: David Trudgian <dave@trudgian.net>
Cc: 38826@debbugs.gnu.org
Subject: [bug#38826] doc: Mention no LUKS2 for luks-device-mapping
Date: Thu, 2 Jan 2020 23:32:56 +0100	[thread overview]
Message-ID: <20200102233256.4250ec30@scratchpost.org> (raw)
In-Reply-To: <20191231034701.GA10716@lappy>

[-- Attachment #1: Type: text/plain, Size: 1109 bytes --]

Hi,

On Mon, 30 Dec 2019 21:47:01 -0600
David Trudgian <dave@trudgian.net> wrote:

> I spent a bit of time trying to mount some existing LUKS2 devices on
> boot in a Guix system. They worked to open and mount manually in a
> booted system, but not on boot with luks-device-mapping. Eventually
> worked out LUKS2 is not supported by the code that inspects the
> superblock directly for the (LUKS1) UUID.
> 
> A mention LUKS2 is not supported in the docs might be nice.

I agree.

But better yet would be to implement LUKS2 in the uuid code.
Since you have such a device could you find where the magic number /
uuid parts in it are?

Both references [1] and [2] say that the magic number is 6 bytes and the
uuid is at offset 168 Byte, length 40 Byte.  Endianness is also big endian
in both, so I have no idea where the problem comes from.  The code should
work for both.

[1] LUKS1 on-disk format: https://gitlab.com/cryptsetup/cryptsetup/-/wikis/LUKS-standard/on-disk-format.pdf
[2] LUKS2 on-disk format: https://habd.as/post/external-backup-drive-encryption/assets/luks2_doc_wip.pdf

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

  reply	other threads:[~2020-01-02 22:34 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-12-31  3:47 [bug#38826] doc: Mention no LUKS2 for luks-device-mapping David Trudgian
2020-01-02 22:32 ` Danny Milosavljevic [this message]
2020-01-02 22:53   ` Tobias Geerinckx-Rice via Guix-patches via
2020-01-03  1:56     ` David Trudgian
2020-01-10 15:39     ` [bug#38826] Fwd: [bug #55093] Add LUKS2 support Tobias Geerinckx-Rice via Guix-patches via
2020-01-10 19:03       ` David Trudgian
     [not found] <20181125-133249.sv131345.66349@savannah.gnu.org>
     [not found] ` <20190329-085821.sv141454.39342@savannah.gnu.org>
     [not found]   ` <20190529-204303.sv92573.55917@savannah.gnu.org>
     [not found]     ` <20191104-210711.sv164522.57380@savannah.gnu.org>
     [not found]       ` <20191104-214103.sv131345.42463@savannah.gnu.org>

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://guix.gnu.org/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20200102233256.4250ec30@scratchpost.org \
    --to=dannym@scratchpost.org \
    --cc=38826@debbugs.gnu.org \
    --cc=dave@trudgian.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/guix.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).