From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:470:142:3::10]:40336) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1in92Z-00071y-Gw for guix-patches@gnu.org; Thu, 02 Jan 2020 17:34:04 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1in92Y-0005GO-F6 for guix-patches@gnu.org; Thu, 02 Jan 2020 17:34:03 -0500 Received: from debbugs.gnu.org ([209.51.188.43]:34195) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1in92Y-0005G8-BT for guix-patches@gnu.org; Thu, 02 Jan 2020 17:34:02 -0500 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1in92Y-0001n6-6N for guix-patches@gnu.org; Thu, 02 Jan 2020 17:34:02 -0500 Subject: [bug#38826] doc: Mention no LUKS2 for luks-device-mapping Resent-Message-ID: Date: Thu, 2 Jan 2020 23:32:56 +0100 From: Danny Milosavljevic Message-ID: <20200102233256.4250ec30@scratchpost.org> In-Reply-To: <20191231034701.GA10716@lappy> References: <20191231034701.GA10716@lappy> MIME-Version: 1.0 Content-Type: multipart/signed; boundary="Sig_/T7ea/1XVoL2W5TOm5vHlPkN"; protocol="application/pgp-signature"; micalg=pgp-sha256 List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+kyle=kyleam.com@gnu.org Sender: "Guix-patches" To: David Trudgian Cc: 38826@debbugs.gnu.org --Sig_/T7ea/1XVoL2W5TOm5vHlPkN Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: quoted-printable Hi, On Mon, 30 Dec 2019 21:47:01 -0600 David Trudgian wrote: > I spent a bit of time trying to mount some existing LUKS2 devices on > boot in a Guix system. They worked to open and mount manually in a > booted system, but not on boot with luks-device-mapping. Eventually > worked out LUKS2 is not supported by the code that inspects the > superblock directly for the (LUKS1) UUID. >=20 > A mention LUKS2 is not supported in the docs might be nice. I agree. But better yet would be to implement LUKS2 in the uuid code. Since you have such a device could you find where the magic number / uuid parts in it are? Both references [1] and [2] say that the magic number is 6 bytes and the uuid is at offset 168 Byte, length 40 Byte. Endianness is also big endian in both, so I have no idea where the problem comes from. The code should work for both. [1] LUKS1 on-disk format: https://gitlab.com/cryptsetup/cryptsetup/-/wikis/= LUKS-standard/on-disk-format.pdf [2] LUKS2 on-disk format: https://habd.as/post/external-backup-drive-encryp= tion/assets/luks2_doc_wip.pdf --Sig_/T7ea/1XVoL2W5TOm5vHlPkN Content-Type: application/pgp-signature Content-Description: OpenPGP digital signature -----BEGIN PGP SIGNATURE----- iQEzBAEBCAAdFiEEds7GsXJ0tGXALbPZ5xo1VCwwuqUFAl4Ob5gACgkQ5xo1VCww uqWH7wf/b5jd4jE/f3DndnK1iydrT7RksluS/PPqh4u/LxGt2cOg18TTuRLnFV0V tMFDK+noiJz5Q9RqHOYORtpLIInS820FH6auP0TyhpeqPGHa/I7qXmrA6MM27FOw bHrAB12xYtTlFgiLZYVJLKLtL1mjmoGuF3l6O/+eRd+0yaeGf36u2wccj8li3T5a 1zqClutAYxSlTphZw4l0bd5XYDGnZr+GF/sa13x1ZLvex6xc8D1ApNNV2uFfYcft iVr+ar0c6t4pusmLZJY8X6tsKf+JS51lHw7yu7idqj13laU14nF51Q0YKZrfSc2G YZhFClydKV+2jiPxHarWPKDoIM+7FA== =lAXg -----END PGP SIGNATURE----- --Sig_/T7ea/1XVoL2W5TOm5vHlPkN--