From: Danny Milosavljevic <dannym@scratchpost.org>
To: 38742@debbugs.gnu.org
Cc: riku.viitanen@protonmail.com
Subject: [bug#38742] [PATCH] gnu: python-fonttools: Update to 4.2.2
Date: Thu, 26 Dec 2019 12:58:01 +0100 [thread overview]
Message-ID: <20191226125801.20c2e80d@scratchpost.org> (raw)
In-Reply-To: <iS8eIDLTs0T7PFq_qgYCZqjE-vo4A7I8hXGK3UB5TlBHiV6E6U2IKoCNYPNPf9fXUwmFQuIMrnVtt_UMVLrsHBaLW6lGVnfz3Llalg5w3MM=@protonmail.com>
[-- Attachment #1: Type: text/plain, Size: 1339 bytes --]
Hi,
thanks for the patch! I have a few comments below:
* I can't apply it. There's two parts in your message:
(1) A rfc822 format file with MIME escape parts (like "=C2=A0") in it which "git am" cannot use and which looks very unusable.
(2) A plain text format file (much better) which is missing the author information ("From"...)--so "git am" cannot use it.
If that's a problem with our Guix-patches tooling (or my mail client), I apologize, but even with manual editing I could not apply (2). (1) is out of the question.
Please use "git format-patch -1" after committing the change to your local git repository in order to create the patch.
You can revert your patch using "git reset HEAD~1" and then try "git am your-patchfile" on your side to see whether we would be able to apply it.
* Please rename the procedure from "python-fonttools-version" to "python-fonttools-package" for consistency with other places we do that.
* Please mention the new procedure in the commit log.
* Please put maintainer comments into the source code, not the commit log.
* A comment trailing a scheme line should have only one ";".
> + (python-fonttools-version
python-fonttools-package
> + "3.44.0" ;; last version to support Python 2
+ "3.44.0" ; last version to support Python 2
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
next prev parent reply other threads:[~2019-12-26 11:59 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-12-25 14:24 [bug#38742] [PATCH] gnu: python-fonttools: Update to 4.2.2 Riku Viitanen via Guix-patches via
2019-12-26 11:58 ` Danny Milosavljevic [this message]
2019-12-26 15:05 ` Marius Bakke
2019-12-30 15:22 ` Riku Viitanen via Guix-patches via
2020-01-12 21:22 ` bug#38742: " Marius Bakke
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://guix.gnu.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20191226125801.20c2e80d@scratchpost.org \
--to=dannym@scratchpost.org \
--cc=38742@debbugs.gnu.org \
--cc=riku.viitanen@protonmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/guix.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).