From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:470:142:3::10]:55828) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1ikRnD-0005ri-O5 for guix-patches@gnu.org; Thu, 26 Dec 2019 06:59:04 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1ikRnC-00032K-N8 for guix-patches@gnu.org; Thu, 26 Dec 2019 06:59:03 -0500 Received: from debbugs.gnu.org ([209.51.188.43]:49001) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1ikRnC-00032G-Kl for guix-patches@gnu.org; Thu, 26 Dec 2019 06:59:02 -0500 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1ikRnC-0004Hh-Kk for guix-patches@gnu.org; Thu, 26 Dec 2019 06:59:02 -0500 Subject: [bug#38742] [PATCH] gnu: python-fonttools: Update to 4.2.2 Resent-Message-ID: Date: Thu, 26 Dec 2019 12:58:01 +0100 From: Danny Milosavljevic Message-ID: <20191226125801.20c2e80d@scratchpost.org> In-Reply-To: References: MIME-Version: 1.0 Content-Type: multipart/signed; boundary="Sig_/tIxP0Xps1.R/BuT3Ik94bsZ"; protocol="application/pgp-signature"; micalg=pgp-sha256 List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+kyle=kyleam.com@gnu.org Sender: "Guix-patches" To: 38742@debbugs.gnu.org Cc: riku.viitanen@protonmail.com --Sig_/tIxP0Xps1.R/BuT3Ik94bsZ Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable Hi, thanks for the patch! I have a few comments below: * I can't apply it. There's two parts in your message: (1) A rfc822 format file with MIME escape parts (like "=3DC2=3DA0") in it= which "git am" cannot use and which looks very unusable. (2) A plain text format file (much better) which is missing the author in= formation ("From"...)--so "git am" cannot use it. If that's a problem with our Guix-patches tooling (or my mail client), I = apologize, but even with manual editing I could not apply (2). (1) is out = of the question. Please use "git format-patch -1" after committing the change to your loca= l git repository in order to create the patch. You can revert your patch using "git reset HEAD~1" and then try "git am y= our-patchfile" on your side to see whether we would be able to apply it. * Please rename the procedure from "python-fonttools-version" to "python-fo= nttools-package" for consistency with other places we do that. * Please mention the new procedure in the commit log. * Please put maintainer comments into the source code, not the commit log. * A comment trailing a scheme line should have only one ";". > +=C2=A0=C2=A0=C2=A0 (python-fonttools-version python-fonttools-package > +=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 "3.44.0"=C2=A0 ;; last version to support= Python 2 +=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 "3.44.0"=C2=A0 ; last version to support Py= thon 2 --Sig_/tIxP0Xps1.R/BuT3Ik94bsZ Content-Type: application/pgp-signature Content-Description: OpenPGP digital signature -----BEGIN PGP SIGNATURE----- iQEzBAEBCAAdFiEEds7GsXJ0tGXALbPZ5xo1VCwwuqUFAl4EoEkACgkQ5xo1VCww uqVq6wf/eTGckqGL9hbirzqlbRp/gmoxrYxBiJtw8UDY0NUdW830p3dqK2IUhhLx bc2a5w9lEg4kSdK5hND1oXOaJtFFSXJTuNTWeFsp7mooQtRCV/KEV//i8YH3q98l xJLi+BEGI9elG6UIYCoPgOHDh6IKi2jzNJFFw09wHubuWRohHa4xMdfkNF41OLph RADN1oZt7jkgIWQnsTcuWIzrK6yTGwtnshJyTrciTMZuDwLRBA0oOjT71ESY4rG0 R+CZGkSWiDEofZSMOX9XxIZ/BmZZXvGcwg/0QND1kZO1zQh0N71vstn5PVUHUA6q Z5ZNHQvxNmF/ZvDrZJZKqx6ppLaZyQ== =LuKx -----END PGP SIGNATURE----- --Sig_/tIxP0Xps1.R/BuT3Ik94bsZ--