unofficial mirror of guix-patches@gnu.org 
 help / color / mirror / code / Atom feed
From: Ivan Vilata i Balaguer <ivan@selidor.net>
To: Efraim Flashner <efraim@flashner.co.il>
Cc: 38395@debbugs.gnu.org, Ivan Vilata i Balaguer <ivan@selidor.net>
Subject: [bug#38395] Acknowledgement ([PATCH] gnu: mumble: Update to 1.3.0.)
Date: Fri, 6 Dec 2019 13:28:26 -0500	[thread overview]
Message-ID: <20191206182826.GD17141@sax.terramar.selidor.net> (raw)
In-Reply-To: <20191205090236.GQ15280@E5400>

Efraim Flashner (2019-12-05 11:02:36 +0200) wrote:

> On Wed, Dec 04, 2019 at 03:17:18PM -0500, Ivan Vilata i Balaguer wrote:
> > Is there anything still missing in the patch that I could work on for it to
> > get merged?  Thanks!
> > 
> 
> With the 'staging' branch being merged into master the patch no longer
> cleanly applies.
> 
> Also, since you've removed a patch from the gnu/packages/patches folder
> you need to remove it also from gnu/local.mk. The two other things are
> the commit message doesn't list all of the changes and with the new
> qt-build-system that would probably be a better choice than wrapping the
> binaries yourself, but with an updated patch without that I can help
> work on that since it is such a new change.

Thanks Efraim for the info!  I don't think I'll have time to work on this
during the next week, but I'll try again ASAP and get back to you.

Cheers,

-- 
Ivan Vilata i Balaguer -- https://elvil.net/

  reply	other threads:[~2019-12-06 18:30 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-11-27  1:40 [bug#38395] [PATCH] gnu: mumble: Update to 1.3.0 Ivan Vilata i Balaguer
     [not found] ` <handler.38395.B.157481938629139.ack@debbugs.gnu.org>
2019-12-04 20:17   ` [bug#38395] Acknowledgement ([PATCH] gnu: mumble: Update to 1.3.0.) Ivan Vilata i Balaguer
2019-12-04 23:24     ` Christopher Lemmer Webber
2019-12-05  9:02     ` Efraim Flashner
2019-12-06 18:28       ` Ivan Vilata i Balaguer [this message]
2019-12-16  1:44       ` Ivan Vilata i Balaguer
     [not found]         ` <20191219130311.GH917@E5400>
2019-12-19 16:51           ` Ivan Vilata i Balaguer

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://guix.gnu.org/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20191206182826.GD17141@sax.terramar.selidor.net \
    --to=ivan@selidor.net \
    --cc=38395@debbugs.gnu.org \
    --cc=efraim@flashner.co.il \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/guix.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).