From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:470:142:3::10]:40073) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1idIMi-0005Rn-VE for guix-patches@gnu.org; Fri, 06 Dec 2019 13:30:10 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1idIMe-00012r-TA for guix-patches@gnu.org; Fri, 06 Dec 2019 13:30:07 -0500 Received: from debbugs.gnu.org ([209.51.188.43]:41076) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1idIMc-00010Y-Jf for guix-patches@gnu.org; Fri, 06 Dec 2019 13:30:02 -0500 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1idIMc-0005gB-Ey for guix-patches@gnu.org; Fri, 06 Dec 2019 13:30:02 -0500 Subject: [bug#38395] Acknowledgement ([PATCH] gnu: mumble: Update to 1.3.0.) Resent-Message-ID: Date: Fri, 6 Dec 2019 13:28:26 -0500 From: Ivan Vilata i Balaguer Message-ID: <20191206182826.GD17141@sax.terramar.selidor.net> References: <20191127014038.GD17004@sax.terramar.selidor.net> <20191204201718.GA17141@sax.terramar.selidor.net> <20191205090236.GQ15280@E5400> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20191205090236.GQ15280@E5400> List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+kyle=kyleam.com@gnu.org Sender: "Guix-patches" To: Efraim Flashner Cc: 38395@debbugs.gnu.org, Ivan Vilata i Balaguer Efraim Flashner (2019-12-05 11:02:36 +0200) wrote: > On Wed, Dec 04, 2019 at 03:17:18PM -0500, Ivan Vilata i Balaguer wrote: > > Is there anything still missing in the patch that I could work on for it to > > get merged? Thanks! > > > > With the 'staging' branch being merged into master the patch no longer > cleanly applies. > > Also, since you've removed a patch from the gnu/packages/patches folder > you need to remove it also from gnu/local.mk. The two other things are > the commit message doesn't list all of the changes and with the new > qt-build-system that would probably be a better choice than wrapping the > binaries yourself, but with an updated patch without that I can help > work on that since it is such a new change. Thanks Efraim for the info! I don't think I'll have time to work on this during the next week, but I'll try again ASAP and get back to you. Cheers, -- Ivan Vilata i Balaguer -- https://elvil.net/