unofficial mirror of guix-patches@gnu.org 
 help / color / mirror / code / Atom feed
* [bug#36755] Upgrade mallard-ducktype to 1.0.2
@ 2019-07-22  0:05 Jack Hill
  2019-07-22  0:08 ` [bug#36755] [PATCH] gnu: mallard-ducktype: Update " Jack Hill
  0 siblings, 1 reply; 6+ messages in thread
From: Jack Hill @ 2019-07-22  0:05 UTC (permalink / raw)
  To: 36755

Hi Guix,

mallard-ducktype 1.0.2 has been released, so I've prepared the following 
patch to update our package definition.

Notable in this release is the availability of a source tarball on pypi, 
so I've updated the package definition to use that instead of a git 
reference.

[0] http://projectmallard.org/pipermail/mallard-list/2019-July/000295.html

Best,
Jack

^ permalink raw reply	[flat|nested] 6+ messages in thread

* [bug#36755] [PATCH] gnu: mallard-ducktype: Update to 1.0.2.
  2019-07-22  0:05 [bug#36755] Upgrade mallard-ducktype to 1.0.2 Jack Hill
@ 2019-07-22  0:08 ` Jack Hill
  2019-07-22  6:50   ` Efraim Flashner
  0 siblings, 1 reply; 6+ messages in thread
From: Jack Hill @ 2019-07-22  0:08 UTC (permalink / raw)
  To: 36755; +Cc: Jack Hill

With this release a source tarball is newly available on PyPI.

* gnu/packages/python-xyz.scm (mallard-ducktype) Update to 1.0.2.
[source] Use pypi uri.
---
 gnu/packages/python-xyz.scm | 13 ++++---------
 1 file changed, 4 insertions(+), 9 deletions(-)

diff --git a/gnu/packages/python-xyz.scm b/gnu/packages/python-xyz.scm
index 6e90c9a933..43bcc377e7 100644
--- a/gnu/packages/python-xyz.scm
+++ b/gnu/packages/python-xyz.scm
@@ -3122,19 +3122,14 @@ and is very extensible.")
 (define-public mallard-ducktype
   (package
     (name "mallard-ducktype")
-    (version "1.0.1")
+    (version "1.0.2")
     (source
      (origin
-       (method git-fetch)
-       ;; git-reference because a proper source tarball is not available
-       ;; https://lists.gnu.org/archive/html/guix-devel/2019-05/msg00209.html
-       (uri (git-reference
-             (url "https://github.com/projectmallard/mallard-ducktype.git")
-             (commit version)))
-       (file-name (git-file-name name version))
+       (method url-fetch)
+       (uri (pypi-uri name version))
        (sha256
         (base32
-         "0crland0kmpsyjfmnflcw7gaqy5b87b6ah17cmr9d5z1kyazf54n"))))
+         "1xxx8jqsqais91li2wl9jbc9fzhgq1gbi24lf9kx43j6fjck25cf"))))
     (build-system python-build-system)
     (home-page "http://projectmallard.org")
     (synopsis "Convert Ducktype to Mallard documentation markup")
-- 
2.22.0

^ permalink raw reply related	[flat|nested] 6+ messages in thread

* [bug#36755] [PATCH] gnu: mallard-ducktype: Update to 1.0.2.
  2019-07-22  0:08 ` [bug#36755] [PATCH] gnu: mallard-ducktype: Update " Jack Hill
@ 2019-07-22  6:50   ` Efraim Flashner
  2019-07-22 13:27     ` Jack Hill
  0 siblings, 1 reply; 6+ messages in thread
From: Efraim Flashner @ 2019-07-22  6:50 UTC (permalink / raw)
  To: Jack Hill; +Cc: 36755

[-- Attachment #1: Type: text/plain, Size: 515 bytes --]

The patch applies cleanly but it turns out the test suite doesn't run.
Digging a little further, the test suite isn't included with the pypi
release, so I'd prefer to stay with the git checkout so we can run the
test suite.

Can you send an updated patch that keeps the git checkout?

Thanks


-- 
Efraim Flashner   <efraim@flashner.co.il>   אפרים פלשנר
GPG key = A28B F40C 3E55 1372 662D  14F7 41AA E7DC CA3D 8351
Confidentiality cannot be guaranteed on emails sent or received unencrypted

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]

^ permalink raw reply	[flat|nested] 6+ messages in thread

* [bug#36755] [PATCH] gnu: mallard-ducktype: Update to 1.0.2.
  2019-07-22  6:50   ` Efraim Flashner
@ 2019-07-22 13:27     ` Jack Hill
  2019-07-22 13:33       ` [bug#36755] [PATCH v2] " Jack Hill
  0 siblings, 1 reply; 6+ messages in thread
From: Jack Hill @ 2019-07-22 13:27 UTC (permalink / raw)
  To: Efraim Flashner; +Cc: 36755

On Mon, 22 Jul 2019, Efraim Flashner wrote:

> The patch applies cleanly but it turns out the test suite doesn't run.
> Digging a little further, the test suite isn't included with the pypi
> release, so I'd prefer to stay with the git checkout so we can run the
> test suite.

Thanks for the review and catching that. I agree that sticking with the 
git checkout sounds like the correct course of action.

> Can you send an updated patch that keeps the git checkout?

Sure, new patch coming shortly.

^ permalink raw reply	[flat|nested] 6+ messages in thread

* [bug#36755] [PATCH v2] gnu: mallard-ducktype: Update to 1.0.2.
  2019-07-22 13:27     ` Jack Hill
@ 2019-07-22 13:33       ` Jack Hill
  2019-07-23  6:10         ` bug#36755: " Efraim Flashner
  0 siblings, 1 reply; 6+ messages in thread
From: Jack Hill @ 2019-07-22 13:33 UTC (permalink / raw)
  To: 36755; +Cc: Jack Hill

* gnu/packages/python-xyz.scm (mallard-ducktype) Update to 1.0.2.
---
 gnu/packages/python-xyz.scm | 8 ++++----
 1 file changed, 4 insertions(+), 4 deletions(-)

diff --git a/gnu/packages/python-xyz.scm b/gnu/packages/python-xyz.scm
index d8f144893d..362ab7f031 100644
--- a/gnu/packages/python-xyz.scm
+++ b/gnu/packages/python-xyz.scm
@@ -3122,19 +3122,19 @@ and is very extensible.")
 (define-public mallard-ducktype
   (package
     (name "mallard-ducktype")
-    (version "1.0.1")
+    (version "1.0.2")
     (source
      (origin
        (method git-fetch)
-       ;; git-reference because a proper source tarball is not available
-       ;; https://lists.gnu.org/archive/html/guix-devel/2019-05/msg00209.html
+       ;; git-reference because tests are not included in pypi source tarball
+       ;; https://issues.guix.gnu.org/issue/36755#2
        (uri (git-reference
              (url "https://github.com/projectmallard/mallard-ducktype.git")
              (commit version)))
        (file-name (git-file-name name version))
        (sha256
         (base32
-         "0crland0kmpsyjfmnflcw7gaqy5b87b6ah17cmr9d5z1kyazf54n"))))
+         "1jk9bfz7g04ip78s03b0xak6d54rj4h9zpgadkziy1ji216g6y4c"))))
     (build-system python-build-system)
     (arguments
      '(#:phases
-- 
2.22.0

^ permalink raw reply related	[flat|nested] 6+ messages in thread

* bug#36755: [PATCH v2] gnu: mallard-ducktype: Update to 1.0.2.
  2019-07-22 13:33       ` [bug#36755] [PATCH v2] " Jack Hill
@ 2019-07-23  6:10         ` Efraim Flashner
  0 siblings, 0 replies; 6+ messages in thread
From: Efraim Flashner @ 2019-07-23  6:10 UTC (permalink / raw)
  To: Jack Hill; +Cc: 36755-done

[-- Attachment #1: Type: text/plain, Size: 236 bytes --]

patch pushed. Thanks!

-- 
Efraim Flashner   <efraim@flashner.co.il>   אפרים פלשנר
GPG key = A28B F40C 3E55 1372 662D  14F7 41AA E7DC CA3D 8351
Confidentiality cannot be guaranteed on emails sent or received unencrypted

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]

^ permalink raw reply	[flat|nested] 6+ messages in thread

end of thread, other threads:[~2019-07-23  6:11 UTC | newest]

Thread overview: 6+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-07-22  0:05 [bug#36755] Upgrade mallard-ducktype to 1.0.2 Jack Hill
2019-07-22  0:08 ` [bug#36755] [PATCH] gnu: mallard-ducktype: Update " Jack Hill
2019-07-22  6:50   ` Efraim Flashner
2019-07-22 13:27     ` Jack Hill
2019-07-22 13:33       ` [bug#36755] [PATCH v2] " Jack Hill
2019-07-23  6:10         ` bug#36755: " Efraim Flashner

Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/guix.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).