From: Julien Lepiller <julien@lepiller.eu>
To: 35329-done@debbugs.gnu.org
Subject: bug#35329: [PATCH] gnu: knot-service: Add includes field in configuration.
Date: Thu, 25 Apr 2019 21:46:08 +0200 [thread overview]
Message-ID: <20190425214608.774e13ae@sybil.lepiller.eu> (raw)
In-Reply-To: <87wojjd1ko.fsf@gnu.org>
Le Wed, 24 Apr 2019 14:34:15 +0200,
Ludovic Courtès <ludo@gnu.org> a écrit :
> Julien Lepiller <julien@lepiller.eu> skribis:
>
> > * gnu/services/dns.scm (knot-configuration): Add includes field.
> > (verify-knot-configuration): Check includes content.
> > (knot-config-file): Serialize includes.
> > * doc/guix.texi (DNS Services): Document it.
>
> [...]
>
> > +@item @code{includes} (default: @code{'()})
> > +A list of strings or file-like objects denoting other files that
> > must be +included at the top of the configuration file. This is
> > especially useful
> ^
> I’d make a new paragraph here.
>
> > +for including key configuration from outside the store, since keys
> > should +not be readable by every user. It can also be used to add
> > configuration +not supported by this interface.
>
> What about:
>
> @cindex secrets, Knot service
> This can be used to manage secrets out-of-band. For example, secret
> keys may be stored in an out-of-band file not managed by Guix, and
> thus not visible in @file{/gnu/store}---e.g., you could store secret
> key configuration in @file{/etc/knot/secrets.conf} and add this file
> to the @code{includes} list.
>
> It can also be used […]
>
> LGTM!
>
> Thanks,
> LUdo’.
Push as 92eb600f8a94afa36142f8f145efaa485b632433, thanks!
prev parent reply other threads:[~2019-04-25 19:53 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-04-19 21:22 [bug#35329] [PATCH] gnu: knot-service: Add includes field in configuration Julien Lepiller
2019-04-24 12:34 ` Ludovic Courtès
2019-04-25 19:46 ` Julien Lepiller [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://guix.gnu.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190425214608.774e13ae@sybil.lepiller.eu \
--to=julien@lepiller.eu \
--cc=35329-done@debbugs.gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/guix.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).