From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([209.51.188.92]:36949)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <Debian-debbugs@debbugs.gnu.org>) id 1hJkQi-0001m2-6Y
	for guix-patches@gnu.org; Thu, 25 Apr 2019 15:53:15 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <Debian-debbugs@debbugs.gnu.org>) id 1hJkKm-0001CV-B7
	for guix-patches@gnu.org; Thu, 25 Apr 2019 15:47:05 -0400
Received: from debbugs.gnu.org ([209.51.188.43]:45851)
	by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16)
	(Exim 4.71) (envelope-from <Debian-debbugs@debbugs.gnu.org>)
	id 1hJkKm-00013y-8U
	for guix-patches@gnu.org; Thu, 25 Apr 2019 15:47:04 -0400
Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2)
	(envelope-from <Debian-debbugs@debbugs.gnu.org>) id 1hJkKk-000695-3I
	for guix-patches@gnu.org; Thu, 25 Apr 2019 15:47:02 -0400
Subject: bug#35329: [PATCH] gnu: knot-service: Add includes field in
	configuration.
Resent-To: guix-patches@gnu.org
Resent-Message-ID: <handler.35329.D35329.155622159423584.done@debbugs.gnu.org>
Date: Thu, 25 Apr 2019 21:46:08 +0200
From: Julien Lepiller <julien@lepiller.eu>
Message-ID: <20190425214608.774e13ae@sybil.lepiller.eu>
In-Reply-To: <87wojjd1ko.fsf@gnu.org>
References: <20190419212255.20209-1-julien@lepiller.eu>
	<87wojjd1ko.fsf@gnu.org>
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: quoted-printable
List-Id: <guix-patches.gnu.org>
List-Unsubscribe: <https://lists.gnu.org/mailman/options/guix-patches>,
	<mailto:guix-patches-request@gnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/archive/html/guix-patches/>
List-Post: <mailto:guix-patches@gnu.org>
List-Help: <mailto:guix-patches-request@gnu.org?subject=help>
List-Subscribe: <https://lists.gnu.org/mailman/listinfo/guix-patches>,
	<mailto:guix-patches-request@gnu.org?subject=subscribe>
Errors-To: guix-patches-bounces+kyle=kyleam.com@gnu.org
Sender: "Guix-patches" <guix-patches-bounces+kyle=kyleam.com@gnu.org>
To: 35329-done@debbugs.gnu.org

Le Wed, 24 Apr 2019 14:34:15 +0200,
Ludovic Court=C3=A8s <ludo@gnu.org> a =C3=A9crit :

> Julien Lepiller <julien@lepiller.eu> skribis:
>=20
> > * gnu/services/dns.scm (knot-configuration): Add includes field.
> > (verify-knot-configuration): Check includes content.
> > (knot-config-file): Serialize includes.
> > * doc/guix.texi (DNS Services): Document it. =20
>=20
> [...]
>=20
> > +@item @code{includes} (default: @code{'()})
> > +A list of strings or file-like objects denoting other files that
> > must be +included at the top of the configuration file.  This is
> > especially useful =20
>                                                  ^
> I=E2=80=99d make a new paragraph here.
>=20
> > +for including key configuration from outside the store, since keys
> > should +not be readable by every user.  It can also be used to add
> > configuration +not supported by this interface. =20
>=20
> What about:
>=20
>   @cindex secrets, Knot service
>   This can be used to manage secrets out-of-band.  For example, secret
>   keys may be stored in an out-of-band file not managed by Guix, and
>   thus not visible in @file{/gnu/store}---e.g., you could store secret
>   key configuration in @file{/etc/knot/secrets.conf} and add this file
>   to the @code{includes} list.
>=20
>   It can also be used [=E2=80=A6]
>=20
> LGTM!
>=20
> Thanks,
> LUdo=E2=80=99.

Push as 92eb600f8a94afa36142f8f145efaa485b632433, thanks!