unofficial mirror of guix-patches@gnu.org 
 help / color / mirror / code / Atom feed
* [bug#34254] [PATCH] build: clean-go: Do not warn about *.go files in "test-tmp".
@ 2019-01-30  5:08 ericbavier
  2019-02-06 22:04 ` Ludovic Courtès
  0 siblings, 1 reply; 3+ messages in thread
From: ericbavier @ 2019-01-30  5:08 UTC (permalink / raw)
  To: 34254; +Cc: Eric Bavier

From: Eric Bavier <bavier@member.fsf.org>

* Makefile.am (clean-go): Ignore "test-tmp" directory.
---
 Makefile.am | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/Makefile.am b/Makefile.am
index 0590c51519..fec9800ce7 100644
--- a/Makefile.am
+++ b/Makefile.am
@@ -318,7 +318,7 @@ nobase_nodist_guileobject_DATA = $(GOBJECTS)
 # Handy way to remove the .go files without removing all the rest.
 clean-go:
 	-$(RM) -f $(GOBJECTS)
-	@find . -name '*.go' -print | \
+	@find . -path ./test-tmp -prune -o -name '*.go' -print | \
 	  if test -t 1; then \
 	    xargs -r echo -e "\033[31mwarning:\033[0m stray .go files:"; \
 	  else \
-- 
2.20.1

^ permalink raw reply related	[flat|nested] 3+ messages in thread

* [bug#34254] [PATCH] build: clean-go: Do not warn about *.go files in "test-tmp".
  2019-01-30  5:08 [bug#34254] [PATCH] build: clean-go: Do not warn about *.go files in "test-tmp" ericbavier
@ 2019-02-06 22:04 ` Ludovic Courtès
  2019-02-08  3:22   ` bug#34254: " Eric Bavier
  0 siblings, 1 reply; 3+ messages in thread
From: Ludovic Courtès @ 2019-02-06 22:04 UTC (permalink / raw)
  To: ericbavier; +Cc: Eric Bavier, 34254

ericbavier@centurylink.net skribis:

> From: Eric Bavier <bavier@member.fsf.org>
>
> * Makefile.am (clean-go): Ignore "test-tmp" directory.

Neat, go for it!  This had been annoying me for a while actually…

Thanks,
Ludo’.

^ permalink raw reply	[flat|nested] 3+ messages in thread

* bug#34254: [PATCH] build: clean-go: Do not warn about *.go files in "test-tmp".
  2019-02-06 22:04 ` Ludovic Courtès
@ 2019-02-08  3:22   ` Eric Bavier
  0 siblings, 0 replies; 3+ messages in thread
From: Eric Bavier @ 2019-02-08  3:22 UTC (permalink / raw)
  Cc: 34254-done

[-- Attachment #1: Type: text/plain, Size: 411 bytes --]

On Wed, 06 Feb 2019 23:04:36 +0100
Ludovic Courtès <ludo@gnu.org> wrote:

> ericbavier@centurylink.net skribis:
> 
> > From: Eric Bavier <bavier@member.fsf.org>
> >
> > * Makefile.am (clean-go): Ignore "test-tmp" directory.  
> 
> Neat, go for it!  This had been annoying me for a while actually…
> 
> Thanks,
> Ludo’.

Pushed to master in 92becc3f15ce196a94274f80ee0b6594774856fa

`~Eric

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 833 bytes --]

^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2019-02-08  3:24 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2019-01-30  5:08 [bug#34254] [PATCH] build: clean-go: Do not warn about *.go files in "test-tmp" ericbavier
2019-02-06 22:04 ` Ludovic Courtès
2019-02-08  3:22   ` bug#34254: " Eric Bavier

Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/guix.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).