From: Timothy Sample <samplet@ngyro.com>
To: 33916@debbugs.gnu.org
Subject: [bug#33916] [PATCH 3/4] services: gdm: Remove 'allow-root?' option.
Date: Sat, 29 Dec 2018 21:42:03 -0500 [thread overview]
Message-ID: <20181230024204.4230-3-samplet@ngyro.com> (raw)
In-Reply-To: <87bm53n3iu.fsf@ngyro.com>
This option results in allowing all login attempts without asking for
credentials. The name is confusing, but rather than rename it, we will
remove it, since it seems like a feature that no one would want.
* gnu/services/xorg.scm (<gdm-configuration>): Remove 'allow-root?'.
(gdm-pam-service): Do not use 'gdm-configuration-allow-root?'.
---
gnu/services/xorg.scm | 9 ++++-----
1 file changed, 4 insertions(+), 5 deletions(-)
diff --git a/gnu/services/xorg.scm b/gnu/services/xorg.scm
index ea8433af3..48aa8f68c 100644
--- a/gnu/services/xorg.scm
+++ b/gnu/services/xorg.scm
@@ -2,6 +2,7 @@
;;; Copyright © 2017 Andy Wingo <wingo@igalia.com>
;;; Copyright © 2013, 2014, 2015, 2016, 2017 Ludovic Courtès <ludo@gnu.org>
;;; Copyright © 2015 Sou Bunnbu <iyzsong@gmail.com>
+;;; Copyright © 2018 Timothy Sample <samplet@ngyro.com>
;;;
;;; This file is part of GNU Guix.
;;;
@@ -625,7 +626,6 @@ makes the good ol' XlockMore usable."
gdm-configuration?
(gdm gdm-configuration-gdm (default gdm))
(allow-empty-passwords? gdm-configuration-allow-empty-passwords? (default #t))
- (allow-root? gdm-configuration-allow-root? (default #t))
(auto-login? gdm-configuration-auto-login? (default #f))
(default-user gdm-configuration-default-user (default #f))
(x-server gdm-configuration-x-server))
@@ -680,10 +680,9 @@ makes the good ol' XlockMore usable."
(auth (list (pam-entry
(control "required")
(module "pam_permit.so")))))
- (unix-pam-service
- "gdm-password"
- #:allow-empty-passwords? (gdm-configuration-allow-empty-passwords? config)
- #:allow-root? (gdm-configuration-allow-root? config))))
+ (unix-pam-service "gdm-password"
+ #:allow-empty-passwords?
+ (gdm-configuration-allow-empty-passwords? config))))
(define (gdm-shepherd-service config)
(list (shepherd-service
--
2.20.1
next prev parent reply other threads:[~2018-12-30 2:59 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-12-30 2:37 [bug#33916] [PATCH 0/4] Make GDM usable Timothy Sample
2018-12-30 2:42 ` [bug#33916] [PATCH 1/4] gnu: gdm: Pass XDG_DATA_DIRS into session environment Timothy Sample
2018-12-30 2:42 ` [bug#33916] [PATCH 2/4] gnu: gdm: Change locale settings file Timothy Sample
2018-12-30 2:42 ` Timothy Sample [this message]
2018-12-30 2:42 ` [bug#33916] [PATCH 4/4] services: gdm: Enable auto-start Timothy Sample
2018-12-30 9:30 ` bug#33916: [PATCH 0/4] Make GDM usable Danny Milosavljevic
2018-12-30 14:42 ` [bug#33916] " Timothy Sample
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://guix.gnu.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20181230024204.4230-3-samplet@ngyro.com \
--to=samplet@ngyro.com \
--cc=33916@debbugs.gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/guix.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).