From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([208.118.235.92]:48848) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1gdRJy-0003R6-Sm for guix-patches@gnu.org; Sat, 29 Dec 2018 21:59:24 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1gdR4B-00042h-3f for guix-patches@gnu.org; Sat, 29 Dec 2018 21:43:07 -0500 Received: from debbugs.gnu.org ([208.118.235.43]:60026) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1gdR4A-00042G-Ti for guix-patches@gnu.org; Sat, 29 Dec 2018 21:43:03 -0500 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1gdR4A-0004vh-Q0 for guix-patches@gnu.org; Sat, 29 Dec 2018 21:43:02 -0500 Subject: [bug#33916] [PATCH 3/4] services: gdm: Remove 'allow-root?' option. Resent-Message-ID: From: Timothy Sample Date: Sat, 29 Dec 2018 21:42:03 -0500 Message-Id: <20181230024204.4230-3-samplet@ngyro.com> In-Reply-To: <87bm53n3iu.fsf@ngyro.com> References: <87bm53n3iu.fsf@ngyro.com> MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+kyle=kyleam.com@gnu.org Sender: "Guix-patches" To: 33916@debbugs.gnu.org This option results in allowing all login attempts without asking for credentials. The name is confusing, but rather than rename it, we will remove it, since it seems like a feature that no one would want. * gnu/services/xorg.scm (): Remove 'allow-root?'. (gdm-pam-service): Do not use 'gdm-configuration-allow-root?'. --- gnu/services/xorg.scm | 9 ++++----- 1 file changed, 4 insertions(+), 5 deletions(-) diff --git a/gnu/services/xorg.scm b/gnu/services/xorg.scm index ea8433af3..48aa8f68c 100644 --- a/gnu/services/xorg.scm +++ b/gnu/services/xorg.scm @@ -2,6 +2,7 @@ ;;; Copyright © 2017 Andy Wingo ;;; Copyright © 2013, 2014, 2015, 2016, 2017 Ludovic Courtès ;;; Copyright © 2015 Sou Bunnbu +;;; Copyright © 2018 Timothy Sample ;;; ;;; This file is part of GNU Guix. ;;; @@ -625,7 +626,6 @@ makes the good ol' XlockMore usable." gdm-configuration? (gdm gdm-configuration-gdm (default gdm)) (allow-empty-passwords? gdm-configuration-allow-empty-passwords? (default #t)) - (allow-root? gdm-configuration-allow-root? (default #t)) (auto-login? gdm-configuration-auto-login? (default #f)) (default-user gdm-configuration-default-user (default #f)) (x-server gdm-configuration-x-server)) @@ -680,10 +680,9 @@ makes the good ol' XlockMore usable." (auth (list (pam-entry (control "required") (module "pam_permit.so"))))) - (unix-pam-service - "gdm-password" - #:allow-empty-passwords? (gdm-configuration-allow-empty-passwords? config) - #:allow-root? (gdm-configuration-allow-root? config)))) + (unix-pam-service "gdm-password" + #:allow-empty-passwords? + (gdm-configuration-allow-empty-passwords? config)))) (define (gdm-shepherd-service config) (list (shepherd-service -- 2.20.1