unofficial mirror of guix-patches@gnu.org 
 help / color / mirror / code / Atom feed
From: "Björn Höfling" <bjoern.hoefling@bjoernhoefling.de>
To: Christopher Baines <mail@cbaines.net>
Cc: 32370@debbugs.gnu.org
Subject: [bug#32370] [PATCH 1/4] gnu: Add ruby-yajl-ruby.
Date: Tue, 11 Sep 2018 08:26:31 +0200	[thread overview]
Message-ID: <20180911082631.52ae2d70@alma-ubu> (raw)
In-Reply-To: <20180828203401.14685-1-mail@cbaines.net>

[-- Attachment #1: Type: text/plain, Size: 2356 bytes --]

On Tue, 28 Aug 2018 21:33:58 +0100
Christopher Baines <mail@cbaines.net> wrote:

> From: Ben Woodcroft <donttrustben@gmail.com>
> 
> * gnu/packages/ruby.scm (ruby-yajl-ruby): New variable.
> 
> Signed-off-by: Christopher Baines <mail@cbaines.net>
> ---
>  gnu/packages/ruby.scm | 36 ++++++++++++++++++++++++++++++++++++
>  1 file changed, 36 insertions(+)
> 
> diff --git a/gnu/packages/ruby.scm b/gnu/packages/ruby.scm
> index 908dfd5751..dabfc6511c 100644
> --- a/gnu/packages/ruby.scm
> +++ b/gnu/packages/ruby.scm
> @@ -3626,6 +3626,42 @@ features such as filtering and fine grained
> logging.") (home-page
> "https://github.com/pjotrp/bioruby-logger-plugin") (license
> license:expat))) 
> +(define-public ruby-yajl-ruby
> +  (package
> +    (name "ruby-yajl-ruby")
> +    (version "1.4.1")
> +    (source
> +     (origin
> +       (method url-fetch)
> +       (uri (rubygems-uri "yajl-ruby" version))
> +       (sha256
> +        (base32
> +         "16v0w5749qjp13xhjgr2gcsvjv6mf35br7iqwycix1n2h7kfcckf"))))
> +    (build-system ruby-build-system)
> +    (arguments
> +     '(#:test-target "spec"
> +       #:phases
> +       (modify-phases %standard-phases
> +         (add-before 'check 'patch-test-to-update-load-path
> +           (lambda _
> +             (substitute* "spec/parsing/large_number_spec.rb"
> +               (("require \"yajl\"")
> +                "$LOAD_PATH << 'lib'; require 'yajl'"))
> +             #t)))))
> +     (native-inputs
> +      `(("ruby-rake-compiler" ,ruby-rake-compiler)
> +        ("ruby-rspec" ,ruby-rspec)))
> +     (synopsis "Streaming JSON parsing and encoding library for
> Ruby")
> +     (description
> +      "Ruby C bindings to the Yajl JSON stream-based parser
> library.  The API +is compatible with the JSON gem, so yajl-ruby can
> act as a drop in +replacement.
> +
> +A modified copy of yajl is used, and included in the package.")
> +     (home-page "https://github.com/brianmario/yajl-ruby")
> +     (license (list license:expat     ; Ruby code, yajl_ext.c and
> yajl_ext.h
> +                    license:bsd-3)))) ; Included, modified copy of
> yajl +
>  (define-public ruby-yard
>    (package
>      (name "ruby-yard")

Hi Chris,

I haven't applied the patches again, but from reading the mails, it
LGTM.

Thanks,

Björn

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 181 bytes --]

  parent reply	other threads:[~2018-09-11  6:27 UTC|newest]

Thread overview: 20+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-08-05 14:39 [bug#32370] [PATCH 0/4] A few Ruby related patches Christopher Baines
2018-08-05 14:43 ` [bug#32370] [PATCH 1/4] gnu: Add ruby-yajl-ruby Christopher Baines
2018-08-05 14:43   ` [bug#32370] [PATCH 2/4] gnu: Add ruby-oj Christopher Baines
2018-08-06 22:30     ` Björn Höfling
2018-08-28 20:38       ` Christopher Baines
2018-08-05 14:43   ` [bug#32370] [PATCH 3/4] gnu: Enable tests for ruby-multi-json Christopher Baines
2018-08-06 22:31     ` Björn Höfling
2018-08-28 20:25       ` Christopher Baines
2018-08-05 14:43   ` [bug#32370] [PATCH 4/4] gnu: Add ruby-multi-test Christopher Baines
2018-08-06 22:30     ` Björn Höfling
2018-08-28 20:30       ` Christopher Baines
2018-08-29  4:53         ` Leo Famulari
2018-08-06 22:28   ` [bug#32370] [PATCH 1/4] gnu: Add ruby-yajl-ruby Björn Höfling
2018-08-28 20:47     ` Christopher Baines
2018-08-28 20:33 ` Christopher Baines
2018-08-28 20:33   ` [bug#32370] [PATCH 2/4] gnu: Add ruby-oj Christopher Baines
2018-08-28 20:34   ` [bug#32370] [PATCH 3/4] gnu: Enable tests for ruby-multi-json Christopher Baines
2018-08-28 20:34   ` [bug#32370] [PATCH 4/4] gnu: Add ruby-multi-test Christopher Baines
2018-09-11  6:26   ` Björn Höfling [this message]
2018-09-16 17:33     ` bug#32370: [PATCH 1/4] gnu: Add ruby-yajl-ruby Christopher Baines

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://guix.gnu.org/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20180911082631.52ae2d70@alma-ubu \
    --to=bjoern.hoefling@bjoernhoefling.de \
    --cc=32370@debbugs.gnu.org \
    --cc=mail@cbaines.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/guix.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).