unofficial mirror of guix-patches@gnu.org 
 help / color / mirror / code / Atom feed
From: "Björn Höfling" <bjoern.hoefling@bjoernhoefling.de>
To: Christopher Baines <mail@cbaines.net>
Cc: 32370@debbugs.gnu.org
Subject: [bug#32370] [PATCH 4/4] gnu: Add ruby-multi-test.
Date: Tue, 7 Aug 2018 00:30:15 +0200	[thread overview]
Message-ID: <20180807003015.7467dd90@alma-ubu> (raw)
In-Reply-To: <20180805144322.4705-4-mail@cbaines.net>

[-- Attachment #1: Type: text/plain, Size: 1088 bytes --]

On Sun,  5 Aug 2018 15:43:22 +0100
Christopher Baines <mail@cbaines.net> wrote:

> From: Ben Woodcroft <donttrustben@gmail.com>
> 
> * gnu/packages/ruby.scm (ruby-multi-test): New variable.
> 
> Signed-off-by: Christopher Baines <mail@cbaines.net>
> ---
>  gnu/packages/ruby.scm | 26 ++++++++++++++++++++++++++
>  1 file changed, 26 insertions(+)
> 
> diff --git a/gnu/packages/ruby.scm b/gnu/packages/ruby.scm
> index 888a31e89..e199d2b92 100644
> --- a/gnu/packages/ruby.scm
> +++ b/gnu/packages/ruby.scm
> @@ -2304,6 +2304,32 @@ NSJSONSerialization, gson.rb, JrJackson, and
> OkJson.") (home-page "https://github.com/intridea/multi_json")
>      (license license:expat)))
>  
> +(define-public ruby-multi-test
> +  (package
> +    (name "ruby-multi-test")

Do we have name conventions for Ruby? The original name is with
underscore: multi_test, here it is written with hyphen: multi-test.


Compare: ruby-data_uri is with underscore.


It also has this strange reproducibility-problem with diffoscope
showing nothing.

Otherwise, LGTM.

Björn



[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 181 bytes --]

  reply	other threads:[~2018-08-06 22:31 UTC|newest]

Thread overview: 20+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-08-05 14:39 [bug#32370] [PATCH 0/4] A few Ruby related patches Christopher Baines
2018-08-05 14:43 ` [bug#32370] [PATCH 1/4] gnu: Add ruby-yajl-ruby Christopher Baines
2018-08-05 14:43   ` [bug#32370] [PATCH 2/4] gnu: Add ruby-oj Christopher Baines
2018-08-06 22:30     ` Björn Höfling
2018-08-28 20:38       ` Christopher Baines
2018-08-05 14:43   ` [bug#32370] [PATCH 3/4] gnu: Enable tests for ruby-multi-json Christopher Baines
2018-08-06 22:31     ` Björn Höfling
2018-08-28 20:25       ` Christopher Baines
2018-08-05 14:43   ` [bug#32370] [PATCH 4/4] gnu: Add ruby-multi-test Christopher Baines
2018-08-06 22:30     ` Björn Höfling [this message]
2018-08-28 20:30       ` Christopher Baines
2018-08-29  4:53         ` Leo Famulari
2018-08-06 22:28   ` [bug#32370] [PATCH 1/4] gnu: Add ruby-yajl-ruby Björn Höfling
2018-08-28 20:47     ` Christopher Baines
2018-08-28 20:33 ` Christopher Baines
2018-08-28 20:33   ` [bug#32370] [PATCH 2/4] gnu: Add ruby-oj Christopher Baines
2018-08-28 20:34   ` [bug#32370] [PATCH 3/4] gnu: Enable tests for ruby-multi-json Christopher Baines
2018-08-28 20:34   ` [bug#32370] [PATCH 4/4] gnu: Add ruby-multi-test Christopher Baines
2018-09-11  6:26   ` [bug#32370] [PATCH 1/4] gnu: Add ruby-yajl-ruby Björn Höfling
2018-09-16 17:33     ` bug#32370: " Christopher Baines

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://guix.gnu.org/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20180807003015.7467dd90@alma-ubu \
    --to=bjoern.hoefling@bjoernhoefling.de \
    --cc=32370@debbugs.gnu.org \
    --cc=mail@cbaines.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/guix.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).