From: Danny Milosavljevic <dannym@scratchpost.org>
To: Julien Lepiller <julien@lepiller.eu>
Cc: 31239@debbugs.gnu.org
Subject: [bug#31239] Make alsa find its plugins
Date: Thu, 17 May 2018 08:01:43 +0200 [thread overview]
Message-ID: <20180517080143.06b1113a@scratchpost.org> (raw)
In-Reply-To: <20180422191345.1836dc69@lepiller.eu>
[-- Attachment #1: Type: text/plain, Size: 744 bytes --]
Hi Julien,
good idea!
The indentation in the patch files is off (alsa-lib uses tabs in its source code).
Also, what is 0001-Add-support-for-a-ALSA_PLUGIN_DIR-environment-variab.patch
embedded in this patch for? Maybe for upstream? Nice :)
You already patch the individual files in alsa-lib.
Note: It would be possible to use
++ char* plugdir = getenv("ALSA_PLUGIN_DIR") ?: ALSA_PLUGIN_DIR;
instead of
++ char* plugdir = ALSA_PLUGIN_DIR;
++ char* envplugdir = getenv("ALSA_PLUGIN_DIR");
++ if(envplugdir != NULL)
++ plugdir = envplugdir;
(especially since it's repeated multiple times) but maybe that's too obscure.
So LGTM except for the indentation and extra patch file!
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
next prev parent reply other threads:[~2018-05-17 6:02 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-04-22 17:13 [bug#31239] Make alsa find its plugins Julien Lepiller
2018-05-17 6:01 ` Danny Milosavljevic [this message]
2018-05-27 17:07 ` bug#31239: " Julien Lepiller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://guix.gnu.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180517080143.06b1113a@scratchpost.org \
--to=dannym@scratchpost.org \
--cc=31239@debbugs.gnu.org \
--cc=julien@lepiller.eu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/guix.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).