From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:52376) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1fJBzJ-0002nC-GB for guix-patches@gnu.org; Thu, 17 May 2018 02:02:06 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1fJBzG-0004vs-Cu for guix-patches@gnu.org; Thu, 17 May 2018 02:02:05 -0400 Received: from debbugs.gnu.org ([208.118.235.43]:58192) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1fJBzG-0004vo-AR for guix-patches@gnu.org; Thu, 17 May 2018 02:02:02 -0400 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1fJBzG-000370-0F for guix-patches@gnu.org; Thu, 17 May 2018 02:02:02 -0400 Subject: [bug#31239] Make alsa find its plugins Resent-Message-ID: Date: Thu, 17 May 2018 08:01:43 +0200 From: Danny Milosavljevic Message-ID: <20180517080143.06b1113a@scratchpost.org> In-Reply-To: <20180422191345.1836dc69@lepiller.eu> References: <20180422191345.1836dc69@lepiller.eu> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha256; boundary="Sig_/79Hvh5JLjo26mANbwOVvwNB"; protocol="application/pgp-signature" List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+kyle=kyleam.com@gnu.org Sender: "Guix-patches" To: Julien Lepiller Cc: 31239@debbugs.gnu.org --Sig_/79Hvh5JLjo26mANbwOVvwNB Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: quoted-printable Hi Julien, good idea! The indentation in the patch files is off (alsa-lib uses tabs in its source= code). Also, what is 0001-Add-support-for-a-ALSA_PLUGIN_DIR-environment-variab.pat= ch embedded in this patch for? Maybe for upstream? Nice :) You already patch the individual files in alsa-lib. Note: It would be possible to use ++ char* plugdir =3D getenv("ALSA_PLUGIN_DIR") ?: ALSA_PLUGIN_DIR; instead of ++ char* plugdir =3D ALSA_PLUGIN_DIR; ++ char* envplugdir =3D getenv("ALSA_PLUGIN_DIR"); ++ if(envplugdir !=3D NULL) ++ plugdir =3D envplugdir; (especially since it's repeated multiple times) but maybe that's too obscur= e. So LGTM except for the indentation and extra patch file! --Sig_/79Hvh5JLjo26mANbwOVvwNB Content-Type: application/pgp-signature Content-Description: OpenPGP digital signature -----BEGIN PGP SIGNATURE----- iQEzBAEBCAAdFiEEds7GsXJ0tGXALbPZ5xo1VCwwuqUFAlr9GscACgkQ5xo1VCww uqXY1gf+LT7qPxkyylXr7ALsy1Wv02AIiJsvQkfY1Vo56Eshq1iS6Bzqd6Mb2ElD 6m/6s5rYrjNxBFcGDFcnfyMt5kLNnpGTuLjJmjtCE4P1CiNiSPXQey99YkkuttFc NjrM2vHcohCfv60Ofq0CjJ3tV/QmfO/ZwLM6QR1dYKJ43YFp854jBLTd1iFf/XG3 qFhpYQePqTaV/tsUFZyKx9LTboQflus9R6YrFS3ZJx5GQfF1ZXL6ZYQID0/2nabW TKH/1NeUnBG2hK4vQVdfGRHAVPyPfeAAh5l94bUqHme5bLE/R7Pe5EnFKmRHwPX2 GUIxINJI83qf8bxWX0hf5R8GULNBhg== =J0as -----END PGP SIGNATURE----- --Sig_/79Hvh5JLjo26mANbwOVvwNB--