From: Danny Milosavljevic <dannym@scratchpost.org>
To: Julien Lepiller <julien@lepiller.eu>
Cc: 31265-done@debbugs.gnu.org
Subject: bug#31265: Add Android NDK build system.
Date: Wed, 9 May 2018 19:34:08 +0200 [thread overview]
Message-ID: <20180509193408.334ab558@scratchpost.org> (raw)
In-Reply-To: <20180501122714.24835731@lepiller.eu>
[-- Attachment #1: Type: text/plain, Size: 441 bytes --]
Hi Julien,
thanks for the review!
On Tue, 1 May 2018 12:27:14 +0200
Julien Lepiller <julien@lepiller.eu> wrote:
> this LGTM, but could you add android-make-stub in a separate patch?
Sure, done.
> Also, could you add a description of the new build system to the manual?
Yeah, did that now.
I pushed to master as commits 72aa295e44d46f80a037bfdc68f831bee56efbab to
ad23a3fbabb3cdc4ad19b524f517ad312768b92c (inclusive).
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
prev parent reply other threads:[~2018-05-09 17:35 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-04-26 0:13 [bug#31265] [PATCH 0/6] Add Android NDK build system Danny Milosavljevic
2018-04-26 0:15 ` [bug#31265] [PATCH 1/6] gnu: Add f2fs-tools@1.7.0 Danny Milosavljevic
2018-04-26 0:15 ` [bug#31265] [PATCH 2/6] build: Add the Android NDK build-system Danny Milosavljevic
2018-04-26 0:15 ` [bug#31265] [PATCH 3/6] gnu: liblog: Use android-ndk-build-system Danny Milosavljevic
2018-04-26 0:15 ` [bug#31265] [PATCH 4/6] gnu: libbase: " Danny Milosavljevic
2018-04-26 0:15 ` [bug#31265] [PATCH 5/6] gnu: adb: " Danny Milosavljevic
2018-04-26 0:16 ` [bug#31265] [PATCH 6/6] gnu: mkbootimg: Install "bootimg.h" Danny Milosavljevic
2018-05-01 10:27 ` [bug#31265] Add Android NDK build system Julien Lepiller
2018-05-09 17:34 ` Danny Milosavljevic [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://guix.gnu.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180509193408.334ab558@scratchpost.org \
--to=dannym@scratchpost.org \
--cc=31265-done@debbugs.gnu.org \
--cc=julien@lepiller.eu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/guix.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).