unofficial mirror of guix-patches@gnu.org 
 help / color / mirror / code / Atom feed
* [bug#31066] [PATCH] gnu: xapers: Fix man page and xapers-adder installation
@ 2018-04-04 23:10 Adam Massmann
  2018-04-05  2:32 ` bug#31066: " Eric Bavier
  0 siblings, 1 reply; 2+ messages in thread
From: Adam Massmann @ 2018-04-04 23:10 UTC (permalink / raw)
  To: 31066

[-- Attachment #1: Type: text/plain, Size: 365 bytes --]

Hi,

I found a bug in my recent contribution of xapers
(https://debbugs.gnu.org/cgi/bugreport.cgi?bug=31007); my use of
"install-file" placed the man pages and xaper-adder in the wrong
directories. I am not sure how this made it past my tests, but I will be
much more careful in the future. I'm sorry for any inconvenience. A
patch to fix is attached.

Best,
Adam


[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: gnu: xapers: Fix man page and xapers-adder installation --]
[-- Type: text/x-diff, Size: 1378 bytes --]

From edaca7682afa090a0ae056e4db7d68573915d98c Mon Sep 17 00:00:00 2001
From: Adam Massmann <massmannak@gmail.com>
Date: Wed, 4 Apr 2018 18:14:11 -0400
Subject: [PATCH] gnu: xapers: Fix man page and xapers-adder installation

---
 gnu/packages/search.scm | 9 +++------
 1 file changed, 3 insertions(+), 6 deletions(-)

diff --git a/gnu/packages/search.scm b/gnu/packages/search.scm
index 64846cffe..02deb5c4a 100644
--- a/gnu/packages/search.scm
+++ b/gnu/packages/search.scm
@@ -344,12 +344,9 @@ search the generated indexes.")
              (let* ((out (assoc-ref outputs "out"))
                     (bin (string-append out "/bin"))
                     (man1 (string-append out "/share/man/man1")))
-               (install-file "man/man1/xapers.1"
-                             (string-append man1 "/xapers.1"))
-               (install-file "man/man1/xapers-adder.1"
-                             (string-append man1 "/xapers-adder.1"))
-               (install-file "bin/xapers-adder"
-                             (string-append bin "/xapers-adder"))))))))
+               (install-file "man/man1/xapers.1"  man1)
+               (install-file "man/man1/xapers-adder.1" man1)
+               (install-file "bin/xapers-adder" bin)))))))
     (home-page "https://finestructure.net/xapers/")
     (synopsis "Personal document indexing system")
     (description
-- 
2.11.0


^ permalink raw reply related	[flat|nested] 2+ messages in thread

* bug#31066: [PATCH] gnu: xapers: Fix man page and xapers-adder installation
  2018-04-04 23:10 [bug#31066] [PATCH] gnu: xapers: Fix man page and xapers-adder installation Adam Massmann
@ 2018-04-05  2:32 ` Eric Bavier
  0 siblings, 0 replies; 2+ messages in thread
From: Eric Bavier @ 2018-04-05  2:32 UTC (permalink / raw)
  To: Adam Massmann; +Cc: 31066-done

[-- Attachment #1: Type: text/plain, Size: 594 bytes --]

On Wed, 04 Apr 2018 19:10:08 -0400
Adam Massmann <massmannak@gmail.com> wrote:

> Hi,
> 
> I found a bug in my recent contribution of xapers
> (https://debbugs.gnu.org/cgi/bugreport.cgi?bug=31007); my use of
> "install-file" placed the man pages and xaper-adder in the wrong
> directories. I am not sure how this made it past my tests, but I will be
> much more careful in the future. I'm sorry for any inconvenience. A
> patch to fix is attached.
> 
> Best,
> Adam
> 

Thank you for the quick fix.
Pushed in b357ccdd8b6824a49f750e0f6b1afb87683adb82

Happy Hacking,
`~Eric

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 833 bytes --]

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2018-04-05  2:33 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2018-04-04 23:10 [bug#31066] [PATCH] gnu: xapers: Fix man page and xapers-adder installation Adam Massmann
2018-04-05  2:32 ` bug#31066: " Eric Bavier

Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/guix.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).