unofficial mirror of guix-patches@gnu.org 
 help / color / mirror / code / Atom feed
* [bug#31007] [PATCH] gnu: Add xapers.
@ 2018-03-31 18:00 Adam Massmann
  2018-04-02 22:37 ` Eric Bavier
  0 siblings, 1 reply; 4+ messages in thread
From: Adam Massmann @ 2018-03-31 18:00 UTC (permalink / raw)
  To: 31007

[-- Attachment #1: Type: text/plain, Size: 304 bytes --]

Hi,

This is a patch to add xapers (https://finestructure.net/xapers/) and
dependencies. I followed the steps in Contributing: Submitting Patches,
but this is my first time contributing so I apologize if I made any
mistakes.

Thanks a lot for the work on Guix, I've really enjoyed using it.

Best,
Adam


[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: gnu: Add python-latexcodec --]
[-- Type: text/x-diff, Size: 1296 bytes --]

From 689559952c8fc7c4091d7239a25f1cec428aebac Mon Sep 17 00:00:00 2001
From: Adam Massmann <massmannak@gmail.com>
Date: Sat, 31 Mar 2018 12:55:42 -0400
Subject: [PATCH 1/3] gnu: Add python-latexcodec

---
 gnu/packages/python.scm | 19 +++++++++++++++++++
 1 file changed, 19 insertions(+)

diff --git a/gnu/packages/python.scm b/gnu/packages/python.scm
index 9e038ef4f..f505f15b2 100644
--- a/gnu/packages/python.scm
+++ b/gnu/packages/python.scm
@@ -13082,3 +13082,22 @@ file system events on Linux.")
         (base32
          "0svc9nla3b9145d6b7fb9dizx412l3difzqw0ilh9lz52nsixw8j"))
        (file-name (string-append name "-" version ".tar.gz"))))))
+
+(define-public python-latexcodec
+  (package
+    (name "python-latexcodec")
+    (version "1.0.5")
+    (source
+     (origin
+       (method url-fetch)
+       (uri (pypi-uri "latexcodec" version))
+       (sha256
+        (base32
+         "0zdd1gf24i83ykadx0y30n3001j43scqr2saql3vckk5c39dj1wn"))))
+    (build-system python-build-system)
+    (inputs
+     `(("python-six" ,python-six)))
+    (home-page "https://readthedocs.org/projects/latexcodec/")
+    (synopsis "Lexer and codec to work with LaTeX code in Python")
+    (description "Lexer and codec to work with LaTeX code in Python.")
+    (license license:expat)))
-- 
2.11.0


[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #3: gnu: Add python-pybtex --]
[-- Type: text/x-diff, Size: 1692 bytes --]

From f506eb11811eef1461b382d6d3cbcc273e62ad3d Mon Sep 17 00:00:00 2001
From: Adam Massmann <massmannak@gmail.com>
Date: Sat, 31 Mar 2018 13:08:11 -0400
Subject: [PATCH 2/3] gnu: Add python-pybtex.

---
 gnu/packages/python.scm | 32 ++++++++++++++++++++++++++++++++
 1 file changed, 32 insertions(+)

diff --git a/gnu/packages/python.scm b/gnu/packages/python.scm
index f505f15b2..056a05235 100644
--- a/gnu/packages/python.scm
+++ b/gnu/packages/python.scm
@@ -13101,3 +13101,35 @@ file system events on Linux.")
     (synopsis "Lexer and codec to work with LaTeX code in Python")
     (description "Lexer and codec to work with LaTeX code in Python.")
     (license license:expat)))
+
+(define-public python-pybtex
+  (package
+    (name "python-pybtex")
+    (version "0.21")
+    (source
+     (origin
+       (method url-fetch)
+       (uri (pypi-uri "pybtex" version))
+       (sha256
+        (base32
+         "00300j8dn5pxq4ndxmfmbmycg2znawkqs49val2x6jlmfiy6r2mg"))))
+    (build-system python-build-system)
+    (native-inputs
+     `(("python-nose" ,python-nose)))
+    (inputs
+     `(("python-latexcodec" ,python-latexcodec)
+       ("python-pyyaml" ,python-pyyaml)
+       ("python-six" ,python-six)))
+    (arguments
+     `(#:phases
+       (modify-phases %standard-phases
+         (replace 'check
+           ;; hack, where did the tests go?
+           (lambda _
+             (zero? 0))))))
+    (home-page "https://pybtex.org/")
+    (synopsis "BibTeX-compatible bibliography processor")
+    (description "Pybtex is a BibTeX-compatible bibliography
+processor written in Python.
+You can simply type pybtex instead of bibtex.")
+    (license license:expat)))
-- 
2.11.0


[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #4: gnu: Add xapers --]
[-- Type: text/x-diff, Size: 3356 bytes --]

From 30df21fe965fce403bb7950b1e1ef97759f4699c Mon Sep 17 00:00:00 2001
From: Adam Massmann <massmannak@gmail.com>
Date: Sat, 31 Mar 2018 13:19:48 -0400
Subject: [PATCH 3/3] gnu: Add xapers.

---
 gnu/packages/search.scm | 57 ++++++++++++++++++++++++++++++++++++++++++++++++-
 1 file changed, 56 insertions(+), 1 deletion(-)

diff --git a/gnu/packages/search.scm b/gnu/packages/search.scm
index a71981992..ebd084c88 100644
--- a/gnu/packages/search.scm
+++ b/gnu/packages/search.scm
@@ -26,6 +26,8 @@
   #:use-module (guix download)
   #:use-module (guix utils)
   #:use-module (guix build-system gnu)
+  #:use-module (guix build-system python)
+  #:use-module (gnu packages python-web)
   #:use-module (gnu packages)
   #:use-module (gnu packages compression)
   #:use-module (gnu packages check)
@@ -34,7 +36,8 @@
   #:use-module (gnu packages perl)
   #:use-module (gnu packages python)
   #:use-module (gnu packages web)
-  #:use-module (gnu packages xml))
+  #:use-module (gnu packages xml)
+  #:use-module (gnu packages pdf))
 
 (define-public xapian
   (package
@@ -307,4 +310,56 @@ can quickly and easily index directories of files or remote web sites and
 search the generated indexes.")
     (license gpl2+)))                   ;with exception
 
+(define-public xapers
+  (package
+    (name "xapers")
+    (version "0.8.2")
+    (source
+     (origin
+       (method url-fetch)
+       (uri (string-append
+             "https://finestructure.net/xapers/releases/xapers-"
+             version ".tar.gz"))
+       (sha256
+        (base32
+         "0ykz6hn3qj46w3c99d6q0pi5ncq2894simcl7vapv047zm3cylmd"))))
+    (build-system python-build-system)
+    (propagated-inputs
+     `(("python-urwid" ,python-urwid)))
+    (inputs
+     `(("poppler" ,poppler)
+       ("python" ,python)
+       ("python-xapian-bindings" ,python-xapian-bindings)
+       ("python-pycurl" ,python-pycurl)
+       ("python-latexcodec" ,python-latexcodec)
+       ("python-pybtex" ,python-pybtex)
+       ("python-pyyaml" ,python-pyyaml)
+       ("python-six" ,python-six)))
+    (arguments
+     `(#:phases
+       (modify-phases %standard-phases
+         (add-after
+             'install 'install-doc
+           (lambda* (#:key inputs outputs #:allow-other-keys)
+             (let* ((out (assoc-ref outputs "out"))
+                    (bin (string-append out "/bin"))
+                    (man1 (string-append out "/share/man/man1")))
+               (mkdir-p bin)
+               (mkdir-p man1)
+               (copy-file "man/man1/xapers.1"
+                          (string-append man1 "/xapers.1"))
+               (copy-file "man/man1/xapers-adder.1"
+                          (string-append man1 "/xapers-adder.1"))
+               (copy-file "bin/xapers-adder"
+                          (string-append bin "/xapers-adder"))))))))
+    (home-page "https://finestructure.net/xapers/")
+    (synopsis "Personal document indexing system")
+    (description
+     "Xapers is a personal document indexing system,
+geared towards academic journal articles build on the Xapian search engine.
+Think of it as your own personal document search engine, or a local cache of
+online libraries.  It provides fast search of document text and
+bibliographic data and simple document and bibtex retrieval.")
+    (license gpl3+)))
+
 ;;; search.scm ends here
-- 
2.11.0


^ permalink raw reply related	[flat|nested] 4+ messages in thread

* [bug#31007] [PATCH] gnu: Add xapers.
  2018-03-31 18:00 [bug#31007] [PATCH] gnu: Add xapers Adam Massmann
@ 2018-04-02 22:37 ` Eric Bavier
  2018-04-04  6:42   ` Adam Massmann
  0 siblings, 1 reply; 4+ messages in thread
From: Eric Bavier @ 2018-04-02 22:37 UTC (permalink / raw)
  To: Adam Massmann; +Cc: 31007

[-- Attachment #1: Type: text/plain, Size: 5037 bytes --]

Hello Adam,

On Sat, 31 Mar 2018 14:00:25 -0400
Adam Massmann <massmannak@gmail.com> wrote:

> Hi,
> 
> This is a patch to add xapers (https://finestructure.net/xapers/) and
> dependencies. I followed the steps in Contributing: Submitting Patches,
> but this is my first time contributing so I apologize if I made any
> mistakes.

Welcome!  Thank you for your contribution.

> Thanks a lot for the work on Guix, I've really enjoyed using it.

Glad you've enjoyed it.

Just a few suggestions:

First, could you add a copyright line for yourself on each of the
affected files?

> ---
>  gnu/packages/python.scm | 19 +++++++++++++++++++
>  1 file changed, 19 insertions(+)
> 
> diff --git a/gnu/packages/python.scm b/gnu/packages/python.scm
> index 9e038ef4f..f505f15b2 100644
> --- a/gnu/packages/python.scm
> +++ b/gnu/packages/python.scm
> @@ -13082,3 +13082,22 @@ file system events on Linux.")
>          (base32
>           "0svc9nla3b9145d6b7fb9dizx412l3difzqw0ilh9lz52nsixw8j"))
>         (file-name (string-append name "-" version ".tar.gz"))))))
> +
> +(define-public python-latexcodec
> +  (package
> +    (name "python-latexcodec")
[...]
> +    (synopsis "Lexer and codec to work with LaTeX code in Python")

Maybe leave out the "Lexer and codec to" bit so this becomes "Work with
LaTeX code in Python" to make the synopsis more approachable.


> 
> 
> From f506eb11811eef1461b382d6d3cbcc273e62ad3d Mon Sep 17 00:00:00 2001
> From: Adam Massmann <massmannak@gmail.com>
> Date: Sat, 31 Mar 2018 13:08:11 -0400
> Subject: [PATCH 2/3] gnu: Add python-pybtex.
> 
> ---
>  gnu/packages/python.scm | 32 ++++++++++++++++++++++++++++++++
>  1 file changed, 32 insertions(+)
> 
> diff --git a/gnu/packages/python.scm b/gnu/packages/python.scm
> index f505f15b2..056a05235 100644
> --- a/gnu/packages/python.scm
> +++ b/gnu/packages/python.scm
> @@ -13101,3 +13101,35 @@ file system events on Linux.")
>      (synopsis "Lexer and codec to work with LaTeX code in Python")
>      (description "Lexer and codec to work with LaTeX code in Python.")
>      (license license:expat)))
> +
> +(define-public python-pybtex
> +  (package
> +    (name "python-pybtex")
> +    (version "0.21")
> +    (source
> +     (origin
> +       (method url-fetch)
> +       (uri (pypi-uri "pybtex" version))
> +       (sha256
> +        (base32
> +         "00300j8dn5pxq4ndxmfmbmycg2znawkqs49val2x6jlmfiy6r2mg"))))
> +    (build-system python-build-system)
> +    (native-inputs
> +     `(("python-nose" ,python-nose)))
> +    (inputs
> +     `(("python-latexcodec" ,python-latexcodec)
> +       ("python-pyyaml" ,python-pyyaml)
> +       ("python-six" ,python-six)))
> +    (arguments
> +     `(#:phases
> +       (modify-phases %standard-phases
> +         (replace 'check
> +           ;; hack, where did the tests go?
> +           (lambda _
> +             (zero? 0))))))

Could you use "#:tests? #f" instead, and expand on exactly why the
tests are not being run (seems there are none?).


> +(define-public xapers
> +  (package
> +    (name "xapers")
> +    (version "0.8.2")
> +    (source
> +     (origin
> +       (method url-fetch)
> +       (uri (string-append
> +             "https://finestructure.net/xapers/releases/xapers-"
> +             version ".tar.gz"))
> +       (sha256
> +        (base32
> +         "0ykz6hn3qj46w3c99d6q0pi5ncq2894simcl7vapv047zm3cylmd"))))
> +    (build-system python-build-system)
> +    (propagated-inputs
> +     `(("python-urwid" ,python-urwid)))
> +    (inputs
> +     `(("poppler" ,poppler)
> +       ("python" ,python)
> +       ("python-xapian-bindings" ,python-xapian-bindings)
> +       ("python-pycurl" ,python-pycurl)
> +       ("python-latexcodec" ,python-latexcodec)
> +       ("python-pybtex" ,python-pybtex)
> +       ("python-pyyaml" ,python-pyyaml)
> +       ("python-six" ,python-six)))
> +    (arguments
> +     `(#:phases
> +       (modify-phases %standard-phases
> +         (add-after
> +             'install 'install-doc

Put these on the same line as "add-after".

> +           (lambda* (#:key inputs outputs #:allow-other-keys)
> +             (let* ((out (assoc-ref outputs "out"))
> +                    (bin (string-append out "/bin"))
> +                    (man1 (string-append out "/share/man/man1")))
> +               (mkdir-p bin)
> +               (mkdir-p man1)
> +               (copy-file "man/man1/xapers.1"
> +                          (string-append man1 "/xapers.1"))
> +               (copy-file "man/man1/xapers-adder.1"
> +                          (string-append man1 "/xapers-adder.1"))
> +               (copy-file "bin/xapers-adder"
> +                          (string-append bin "/xapers-adder"))))))))
                   ^

Use "install-file" here.  It also creates the target directory, so you
can remove the mkdir-p's above.

Otherwise looks good to me.  Could you send an updated patch?

Thanks,
`~Eric


[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 833 bytes --]

^ permalink raw reply	[flat|nested] 4+ messages in thread

* [bug#31007] [PATCH] gnu: Add xapers.
  2018-04-02 22:37 ` Eric Bavier
@ 2018-04-04  6:42   ` Adam Massmann
  2018-04-04 14:39     ` bug#31007: " Eric Bavier
  0 siblings, 1 reply; 4+ messages in thread
From: Adam Massmann @ 2018-04-04  6:42 UTC (permalink / raw)
  To: ericbavier, 31007

[-- Attachment #1: Type: text/plain, Size: 691 bytes --]


Hi Eric,

Thank you very much for reviewing the patch and providing the
feedback. I was able to make the fixes you pointed out and attached the
updated patches below. I also fixed some mistakes on alphabetical order
I had missed.

While digging more into the missing tests for pybtex I realized that the
problems with tests were actually an error on my part - I apologize! I
misinterpreted some output as suggesting that tests were missing, when
in reality I was letting Guix send the wrong test target to
python-build. This is fixed now and the tests work.

Thanks again for your time spent on the contribution; it's a big help
particularly for someone new to this like me. 

Best,
Adam



[-- Attachment #2: gnu: Add python-latexcodec --]
[-- Type: text/x-diff, Size: 1645 bytes --]

From 255654e8bed9df609c824f4687ef0b673bcc3c09 Mon Sep 17 00:00:00 2001
From: Adam Massmann <massmannak@gmail.com>
Date: Wed, 4 Apr 2018 02:09:28 -0400
Subject: [PATCH 1/3] gnu: Add python-latexcodec

---
 gnu/packages/python.scm | 22 ++++++++++++++++++++++
 1 file changed, 22 insertions(+)

diff --git a/gnu/packages/python.scm b/gnu/packages/python.scm
index 9e038ef4f..946bf7916 100644
--- a/gnu/packages/python.scm
+++ b/gnu/packages/python.scm
@@ -48,6 +48,7 @@
 ;;; Copyright © 2018 Ethan R. Jones <ethanrjones97@gmail.com
 ;;; Copyright © 2018 Fis Trivial <ybbs.daans@hotmail.com>
 ;;; Copyright © 2018 Vijayalakshmi Vedantham <vijimay12@gmail.com>
+;;; Copyright © 2018 Adam Massmann <massmannak@gmail.com>
 
 ;;; This file is part of GNU Guix.
 ;;;
@@ -13082,3 +13083,24 @@ file system events on Linux.")
         (base32
          "0svc9nla3b9145d6b7fb9dizx412l3difzqw0ilh9lz52nsixw8j"))
        (file-name (string-append name "-" version ".tar.gz"))))))
+
+(define-public python-latexcodec
+  (package
+    (name "python-latexcodec")
+    (version "1.0.5")
+    (source
+     (origin
+       (method url-fetch)
+       (uri (pypi-uri "latexcodec" version))
+       (sha256
+        (base32
+         "0zdd1gf24i83ykadx0y30n3001j43scqr2saql3vckk5c39dj1wn"))))
+    (build-system python-build-system)
+    (inputs
+     `(("python-six" ,python-six)))
+    (home-page "https://readthedocs.org/projects/latexcodec/")
+    (synopsis "Work with LaTeX code in Python")
+    (description "Lexer and codec to work with LaTeX code in Python.")
+    (license license:expat)))
+
+
-- 
2.11.0


[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #3: gnu: Add python-pybtex --]
[-- Type: text/x-diff, Size: 1475 bytes --]

From 175d4c538b997485500aae112ac734ec452a242f Mon Sep 17 00:00:00 2001
From: Adam Massmann <massmannak@gmail.com>
Date: Wed, 4 Apr 2018 02:10:32 -0400
Subject: [PATCH 2/3] gnu: Add python-pybtex

---
 gnu/packages/python.scm | 26 ++++++++++++++++++++++++++
 1 file changed, 26 insertions(+)

diff --git a/gnu/packages/python.scm b/gnu/packages/python.scm
index 946bf7916..d874b4e3d 100644
--- a/gnu/packages/python.scm
+++ b/gnu/packages/python.scm
@@ -13103,4 +13103,30 @@ file system events on Linux.")
     (description "Lexer and codec to work with LaTeX code in Python.")
     (license license:expat)))
 
+(define-public python-pybtex
+  (package
+    (name "python-pybtex")
+    (version "0.21")
+    (source
+     (origin
+       (method url-fetch)
+       (uri (pypi-uri "pybtex" version))
+       (sha256
+        (base32
+         "00300j8dn5pxq4ndxmfmbmycg2znawkqs49val2x6jlmfiy6r2mg"))))
+    (build-system python-build-system)
+    (native-inputs
+     `(("python-nose" ,python-nose)))
+    (inputs
+     `(("python-latexcodec" ,python-latexcodec)
+       ("python-pyyaml" ,python-pyyaml)
+       ("python-six" ,python-six)))
+    (arguments
+     `(#:test-target "nosetests"))
+    (home-page "https://pybtex.org/")
+    (synopsis "BibTeX-compatible bibliography processor")
+    (description "Pybtex is a BibTeX-compatible bibliography
+processor written in Python.
+You can simply type pybtex instead of bibtex.")
+    (license license:expat)))
 
-- 
2.11.0


[-- Attachment #4: gnu: Add xapers --]
[-- Type: text/x-diff, Size: 3680 bytes --]

From 0dd76dc1b5f89500ba4e9dcfbe34fca6a5f9c48e Mon Sep 17 00:00:00 2001
From: Adam Massmann <massmannak@gmail.com>
Date: Wed, 4 Apr 2018 02:13:30 -0400
Subject: [PATCH 3/3] gnu: Add xapers

---
 gnu/packages/search.scm | 53 +++++++++++++++++++++++++++++++++++++++++++++++++
 1 file changed, 53 insertions(+)

diff --git a/gnu/packages/search.scm b/gnu/packages/search.scm
index a71981992..64846cffe 100644
--- a/gnu/packages/search.scm
+++ b/gnu/packages/search.scm
@@ -3,6 +3,7 @@
 ;;; Copyright © 2015, 2016 Eric Bavier <bavier@member.fsf.org>
 ;;; Copyright © 2017 Thomas Danckaert <post@thomasdanckaert.be>
 ;;; Copyright © 2017 Ricardo Wurmus <rekado@elephly.net>
+;;; Copyright © 2018 Adam Massmann <massmannak@gmail.com>
 ;;;
 ;;; This file is part of GNU Guix.
 ;;;
@@ -26,13 +27,16 @@
   #:use-module (guix download)
   #:use-module (guix utils)
   #:use-module (guix build-system gnu)
+  #:use-module (guix build-system python)
   #:use-module (gnu packages)
   #:use-module (gnu packages compression)
   #:use-module (gnu packages check)
   #:use-module (gnu packages databases)
   #:use-module (gnu packages linux)
   #:use-module (gnu packages perl)
+  #:use-module (gnu packages pdf)
   #:use-module (gnu packages python)
+  #:use-module (gnu packages python-web)
   #:use-module (gnu packages web)
   #:use-module (gnu packages xml))
 
@@ -307,4 +311,53 @@ can quickly and easily index directories of files or remote web sites and
 search the generated indexes.")
     (license gpl2+)))                   ;with exception
 
+(define-public xapers
+  (package
+    (name "xapers")
+    (version "0.8.2")
+    (source
+     (origin
+       (method url-fetch)
+       (uri (string-append
+             "https://finestructure.net/xapers/releases/xapers-"
+             version ".tar.gz"))
+       (sha256
+        (base32
+         "0ykz6hn3qj46w3c99d6q0pi5ncq2894simcl7vapv047zm3cylmd"))))
+    (build-system python-build-system)
+    (propagated-inputs
+     `(("python-urwid" ,python-urwid)))
+    (inputs
+     `(("poppler" ,poppler)
+       ("python" ,python)
+       ("python-latexcodec" ,python-latexcodec)
+       ("python-pybtex" ,python-pybtex)
+       ("python-pycurl" ,python-pycurl)
+       ("python-pyyaml" ,python-pyyaml)
+       ("python-six" ,python-six)
+       ("python-xapian-bindings" ,python-xapian-bindings)))
+    (arguments
+     `(#:phases
+       (modify-phases %standard-phases
+         (add-after 'install 'install-doc
+           (lambda* (#:key inputs outputs #:allow-other-keys)
+             (let* ((out (assoc-ref outputs "out"))
+                    (bin (string-append out "/bin"))
+                    (man1 (string-append out "/share/man/man1")))
+               (install-file "man/man1/xapers.1"
+                             (string-append man1 "/xapers.1"))
+               (install-file "man/man1/xapers-adder.1"
+                             (string-append man1 "/xapers-adder.1"))
+               (install-file "bin/xapers-adder"
+                             (string-append bin "/xapers-adder"))))))))
+    (home-page "https://finestructure.net/xapers/")
+    (synopsis "Personal document indexing system")
+    (description
+     "Xapers is a personal document indexing system,
+geared towards academic journal articles build on the Xapian search engine.
+Think of it as your own personal document search engine, or a local cache of
+online libraries.  It provides fast search of document text and
+bibliographic data and simple document and bibtex retrieval.")
+    (license gpl3+)))
+
 ;;; search.scm ends here
-- 
2.11.0


^ permalink raw reply related	[flat|nested] 4+ messages in thread

* bug#31007: [PATCH] gnu: Add xapers.
  2018-04-04  6:42   ` Adam Massmann
@ 2018-04-04 14:39     ` Eric Bavier
  0 siblings, 0 replies; 4+ messages in thread
From: Eric Bavier @ 2018-04-04 14:39 UTC (permalink / raw)
  To: Adam Massmann; +Cc: 31007-done

[-- Attachment #1: Type: text/plain, Size: 1153 bytes --]

On Wed, 04 Apr 2018 02:42:34 -0400
Adam Massmann <massmannak@gmail.com> wrote:

> Hi Eric,
> 
> Thank you very much for reviewing the patch and providing the
> feedback. I was able to make the fixes you pointed out and attached the
> updated patches below. I also fixed some mistakes on alphabetical order
> I had missed.

Great, thank you!

> 
> While digging more into the missing tests for pybtex I realized that the
> problems with tests were actually an error on my part - I apologize! I
> misinterpreted some output as suggesting that tests were missing, when
> in reality I was letting Guix send the wrong test target to
> python-build. This is fixed now and the tests work.

Awesome.

> 
> Thanks again for your time spent on the contribution; it's a big help
> particularly for someone new to this like me. 
> 

No problem; just paying it forward.

I've pushed these three patches in 

c2b2f0c86691f6d76f528b6366c866b8f3665c3c
2514fc1d69ec556c9c18d2463a892f43fa175557
f50bad80a93eabab598f3d6d621818b67cefb70b

with minor changes.  Thank you for the contribution; hope to see some
more from you! :)

`~Eric

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 833 bytes --]

^ permalink raw reply	[flat|nested] 4+ messages in thread

end of thread, other threads:[~2018-04-04 14:40 UTC | newest]

Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2018-03-31 18:00 [bug#31007] [PATCH] gnu: Add xapers Adam Massmann
2018-04-02 22:37 ` Eric Bavier
2018-04-04  6:42   ` Adam Massmann
2018-04-04 14:39     ` bug#31007: " Eric Bavier

Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/guix.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).