[bug#30970] Add package definition for screen message

[bug#30970] Add package definition for screen message

[Ton]

[-- Attachment #1.1: Type: text/plain, Size: 366 bytes --]

Here is the package definition for screen message. A simple program to fill
your screen with text input either as an argument to the program or input
during execution.

Built and tested on GuixSD Linux merlin 4.15.8-gnu #1 SMP 1 x86_64 GNU/Linux.

It passes guix lint without errors.

It builds 5 times deterministicly.

Guix size says "total: 568.0 MiB"

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #1.2: 0001-Add-package-definition-screen-message.patch --]
[-- Type: text/x-patch, Size: 2227 bytes --]

From c6ddc41853ff22acb3923b221b8530a057875253 Mon Sep 17 00:00:00 2001
From: Tonton <tonton@riseup.net>
Date: Wed, 28 Mar 2018 15:45:07 +0200
Subject: [PATCH] Add package definition screen message

Built and tested on GuixSD Linux merlin 4.15.8-gnu #1 SMP 1 x86_64 GNU/Linux.

It passes guix lint without errors.

It builds 5 times deterministicly.

Guix size says "total: 568.0 MiB"
---
 gnu/packages/screen-message.scm | 36 ++++++++++++++++++++++++++++++++++++
 1 file changed, 36 insertions(+)
 create mode 100644 gnu/packages/screen-message.scm

diff --git a/gnu/packages/screen-message.scm b/gnu/packages/screen-message.scm
new file mode 100644
index 000000000..6afd18aae
--- /dev/null
+++ b/gnu/packages/screen-message.scm
@@ -0,0 +1,36 @@
+(define-module (screen-message)
+  #:use-module (guix packages)
+  #:use-module (guix download)
+  #:use-module (guix build-system gnu)
+  #:use-module ((guix licenses) #:prefix license:)
+  #:use-module (gnu packages pkg-config)
+  #:use-module (gnu packages gtk)
+  #:use-module (gnu packages glib))
+
+(define-public screen-message
+  (package
+    (name "screen-message")
+    (version "0.25")
+    (source (origin
+              (method url-fetch)
+              (uri
+               (string-append
+                "http://www.joachim-breitner.de/archive/screen-message/screen-message-"
+                                  version ".tar.gz"))
+              (sha256
+               (base32
+                "1lw955qq5pq010lzmaf32ylj2iprgsri9ih4hx672c3f794ilab0"))))
+    (build-system gnu-build-system)
+    (inputs `(("gtk3" ,gtk+)
+              ("gdk" ,gdk-pixbuf)
+              ("pango" ,pango)))
+    (native-inputs `(("pkgconfig" ,pkg-config)))
+    (arguments
+     `(#:make-flags (list (string-append "execgamesdir=" %output "/bin"))))
+    (synopsis "Prints messages on your screen")
+    (description "If you just want to disply a word or a short, possilby
+multi-line, text as large and as quickly as possible on your screen,
+then “screen-message” is the right tool for you.")
+    (home-page "http://www.joachim-breitner.de/projects#screen-message")
+    (license license:gpl2+)))
+
-- 
2.16.3


[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 833 bytes --]

[bug#30970] Add package definition for screen message

[Marius Bakke]

[-- Attachment #1: Type: text/plain, Size: 2918 bytes --]

Ton <tonton@riseup.net> writes:

> Here is the package definition for screen message. A simple program to fill
> your screen with text input either as an argument to the program or input
> during execution.
>
> Built and tested on GuixSD Linux merlin 4.15.8-gnu #1 SMP 1 x86_64 GNU/Linux.
>
> It passes guix lint without errors.
>
> It builds 5 times deterministicly.
>
> Guix size says "total: 568.0 MiB"

Thank you for this patch, and for testing reproducibility and linting!
I think it can go to 'xdisorg.scm' instead of a separate module.  Can
you also add a copyright line for yourself?  Pseudonyms are fine.

Overall the patch LGTM, some nitpicks:

> From c6ddc41853ff22acb3923b221b8530a057875253 Mon Sep 17 00:00:00 2001
> From: Tonton <tonton@riseup.net>
> Date: Wed, 28 Mar 2018 15:45:07 +0200
> Subject: [PATCH] Add package definition screen message
>
> Built and tested on GuixSD Linux merlin 4.15.8-gnu #1 SMP 1 x86_64 GNU/Linux.
>
> It passes guix lint without errors.
>
> It builds 5 times deterministicly.
>
> Guix size says "total: 568.0 MiB"

Please see 'git log' for commit message conventions.

[...]

> +(define-public screen-message
> +  (package
> +    (name "screen-message")
> +    (version "0.25")
> +    (source (origin
> +              (method url-fetch)
> +              (uri
> +               (string-append
> +                "http://www.joachim-breitner.de/archive/screen-message/screen-message-"
> +                                  version ".tar.gz"))

Use HTTPS here, and on the home page.

> +              (sha256
> +               (base32
> +                "1lw955qq5pq010lzmaf32ylj2iprgsri9ih4hx672c3f794ilab0"))))
> +    (build-system gnu-build-system)
> +    (inputs `(("gtk3" ,gtk+)
> +              ("gdk" ,gdk-pixbuf)
> +              ("pango" ,pango)))
> +    (native-inputs `(("pkgconfig" ,pkg-config)))
                            ^^^
                         "pkg-config"

> +    (arguments
> +     `(#:make-flags (list (string-append "execgamesdir=" %output "/bin"))))
> +    (synopsis "Prints messages on your screen")

s/Prints/Print/

> +    (description "If you just want to disply a word or a short, possilby
                                                                        ^^^
Typo:

> +multi-line, text as large and as quickly as possible on your screen,
> +then “screen-message” is the right tool for you.")

Use @code{screen-message} instead of quotes.

However I would rewrite this to something along the lines of
"@code{screen-message} is a tool for displaying text on your screen.  It
will make the text as large as possible and display it with black color
on a white background."

This was shamelessly adapted from Debians description, feel free to
expand on it: <https://packages.debian.org/sid/sm>.

Can you send an updated patch please?  Thanks in advance!

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 487 bytes --]

[bug#30970] Add package definition for screen message

[Ton]

[-- Attachment #1.1: Type: text/plain, Size: 49 bytes --]

Here is a new patch with the requested changes.

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #1.2: 0001-gnu-packages-xdisorg.scm-screen-message-New-variable.patch --]
[-- Type: text/x-patch, Size: 2334 bytes --]

From b993e9eb9ed2d7c1d8ca80a33d046c7ccf54be32 Mon Sep 17 00:00:00 2001
From: Tonton <tonton@riseup.net>
Date: Thu, 29 Mar 2018 11:38:11 +0200
Subject: [PATCH] * gnu/packages/xdisorg.scm (screen-message): New variable

Signed-off-by: Tonton <tonton@riseup.net>
---
 gnu/packages/xdisorg.scm | 32 ++++++++++++++++++++++++++++++++
 1 file changed, 32 insertions(+)

diff --git a/gnu/packages/xdisorg.scm b/gnu/packages/xdisorg.scm
index 6663a0e74..66f29a8b6 100644
--- a/gnu/packages/xdisorg.scm
+++ b/gnu/packages/xdisorg.scm
@@ -21,6 +21,7 @@
 ;;; Copyright © 2017 Tobias Geerinckx-Rice <me@tobias.gr>
 ;;; Copyright © 2017 Marek Benc <dusxmt@gmx.com>
 ;;; Copyright © 2017 Mike Gerwitz <mtg@gnu.org>
+;;; Copyright © 2018 Thomas Sigurdsen <tonton@riseup.net>
 ;;;
 ;;; This file is part of GNU Guix.
 ;;;
@@ -1408,3 +1409,34 @@ or playing a PCM encoded WAVE file.")
 System, and launches a program of your choice if there is no activity after
 a user-configurable period of time.")
     (license license:gpl2)))
+
+(define-public screen-message
+  (package
+    (name "screen-message")
+    (version "0.25")
+    (source (origin
+              (method url-fetch)
+              (uri
+               (string-append
+                "https://www.joachim-breitner.de/archive/screen-message/screen-message-"
+                                  version ".tar.gz"))
+              (sha256
+               (base32
+                "1lw955qq5pq010lzmaf32ylj2iprgsri9ih4hx672c3f794ilab0"))))
+    (build-system gnu-build-system)
+    (inputs `(("gtk3" ,gtk+)
+              ("gdk" ,gdk-pixbuf)
+              ("pango" ,pango)))
+    (native-inputs `(("pkg-config" ,pkg-config)))
+    (arguments
+     ;; The default configure puts the 'sm' binary in games/ instead of bin/ -
+     ;; this fixes it:
+     `(#:make-flags (list (string-append "execgamesdir=" %output "/bin"))))
+    (synopsis "Print messages on your screen")
+    (description "@code{screen-message} is a tool for displaying text on
+your screen.  It will make the text as large as possible and display it
+with black color on a white background (colors are configurable on the
+commandline).")
+    (home-page "https://www.joachim-breitner.de/projects#screen-message")
+    (license license:gpl2+)))
+
-- 
2.16.3


[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 833 bytes --]

bug#30970: Add package definition for screen message

[Marius Bakke]

[-- Attachment #1: Type: text/plain, Size: 368 bytes --]

Ton <tonton@riseup.net> writes:

> Here is a new patch with the requested changes.
> From b993e9eb9ed2d7c1d8ca80a33d046c7ccf54be32 Mon Sep 17 00:00:00 2001
> From: Tonton <tonton@riseup.net>
> Date: Thu, 29 Mar 2018 11:38:11 +0200
> Subject: [PATCH] * gnu/packages/xdisorg.scm (screen-message): New variable

Excellent, applied with a full commit message.  Thank you!

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 487 bytes --]