unofficial mirror of guix-patches@gnu.org 
 help / color / mirror / code / Atom feed
From: "Björn Höfling" <bjoern.hoefling@bjoernhoefling.de>
To: Arun Isaac <arunisaac@systemreboot.net>
Cc: 30456@debbugs.gnu.org
Subject: [bug#30456] [PATCH 1/2] gnu: Add mapnik.
Date: Wed, 14 Feb 2018 23:50:34 +0100	[thread overview]
Message-ID: <20180214235034.1f31ce7f@alma-ubu> (raw)
In-Reply-To: <20180214162903.23995-1-arunisaac@systemreboot.net>

Thanks for adding this!

On Wed, 14 Feb 2018 21:59:03 +0530
Arun Isaac <arunisaac@systemreboot.net> wrote:

> * gnu/packages/geo.scm (mapnik): New variable.

[..]

> +    (inputs
> +     `(("boost" ,boost)
> +       ("freetype" ,freetype)
> +       ("harfbuzz" ,harfbuzz)
> +       ("icu4c" ,icu4c)
> +       ("libjpeg-turbo" ,libjpeg-turbo)
> +       ("libpng" ,libpng)
> +       ("libtiff" ,libtiff)
> +       ("proj.4" ,proj.4)
> +       ("zlib" ,zlib)))

Have you tried to add these dependencies to gain potentially more
rendering input/output:

libwebp
cairo
sqlite

[..]

> +    (license license:lgpl2.1+)))

Many files under ./demo are licensed under "license:gpl2.0+". Add that
license, too.

Furthermore, there are:

license:boost1.0 ;; deps/boost
license:bsd3 ;; deps/mapbox and deps/mapnik/sparsehash

Finally, dep/agg has another license. Is it expat or even less? Here it
is:

// Permission to copy, use, modify, sell and distribute this software
// is granted provided this copyright notice appears in all copies.
// This software is provided "as is" without express or implied
// warranty, and with no claim as to its suitability for any purpose.



Otherwise, LGTM.

Björn

  parent reply	other threads:[~2018-02-14 22:51 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-02-14 16:29 [bug#30456] [PATCH 1/2] gnu: Add mapnik Arun Isaac
2018-02-14 16:38 ` [bug#30456] [PATCH 2/2] gnu: Add python2-mapnik Arun Isaac
2018-02-14 21:12   ` Leo Famulari
2018-02-14 21:11 ` [bug#30456] [PATCH 1/2] gnu: Add mapnik Leo Famulari
2018-02-14 22:50 ` Björn Höfling [this message]
2018-02-14 23:12   ` Leo Famulari
2018-02-15 22:27 ` [bug#30456] [PATCH 0/2] Mapnik Arun Isaac
2018-02-15 22:27   ` [bug#30456] [PATCH 1/2] gnu: Add mapnik Arun Isaac
2018-02-15 22:27   ` [bug#30456] [PATCH 2/2] gnu: Add python2-mapnik Arun Isaac
2018-02-16 12:46   ` [bug#30456] [PATCH 0/2] Mapnik Björn Höfling
2018-02-18 12:51     ` bug#30456: " Arun Isaac

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://guix.gnu.org/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20180214235034.1f31ce7f@alma-ubu \
    --to=bjoern.hoefling@bjoernhoefling.de \
    --cc=30456@debbugs.gnu.org \
    --cc=arunisaac@systemreboot.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/guix.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).