From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:46240)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <Debian-debbugs@debbugs.gnu.org>) id 1em5tL-0007hz-BT
	for guix-patches@gnu.org; Wed, 14 Feb 2018 17:51:08 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <Debian-debbugs@debbugs.gnu.org>) id 1em5tI-0007dP-9c
	for guix-patches@gnu.org; Wed, 14 Feb 2018 17:51:07 -0500
Received: from debbugs.gnu.org ([208.118.235.43]:35550)
	by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16)
	(Exim 4.71) (envelope-from <Debian-debbugs@debbugs.gnu.org>)
	id 1em5tI-0007dH-5c
	for guix-patches@gnu.org; Wed, 14 Feb 2018 17:51:04 -0500
Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2)
	(envelope-from <Debian-debbugs@debbugs.gnu.org>) id 1em5tH-0003ih-Uq
	for guix-patches@gnu.org; Wed, 14 Feb 2018 17:51:03 -0500
Subject: [bug#30456] [PATCH 1/2] gnu: Add mapnik.
Resent-Message-ID: <handler.30456.B30456.151864863914250@debbugs.gnu.org>
Date: Wed, 14 Feb 2018 23:50:34 +0100
From: =?UTF-8?Q?Bj=C3=B6rn_?= =?UTF-8?Q?H=C3=B6fling?=
	<bjoern.hoefling@bjoernhoefling.de>
Message-ID: <20180214235034.1f31ce7f@alma-ubu>
In-Reply-To: <20180214162903.23995-1-arunisaac@systemreboot.net>
References: <20180214162903.23995-1-arunisaac@systemreboot.net>
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: quoted-printable
List-Id: <guix-patches.gnu.org>
List-Unsubscribe: <https://lists.gnu.org/mailman/options/guix-patches>,
	<mailto:guix-patches-request@gnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/archive/html/guix-patches/>
List-Post: <mailto:guix-patches@gnu.org>
List-Help: <mailto:guix-patches-request@gnu.org?subject=help>
List-Subscribe: <https://lists.gnu.org/mailman/listinfo/guix-patches>,
	<mailto:guix-patches-request@gnu.org?subject=subscribe>
Errors-To: guix-patches-bounces+kyle=kyleam.com@gnu.org
Sender: "Guix-patches" <guix-patches-bounces+kyle=kyleam.com@gnu.org>
To: Arun Isaac <arunisaac@systemreboot.net>
Cc: 30456@debbugs.gnu.org

Thanks for adding this!

On Wed, 14 Feb 2018 21:59:03 +0530
Arun Isaac <arunisaac@systemreboot.net> wrote:

> * gnu/packages/geo.scm (mapnik): New variable.

[..]

> +    (inputs
> +     `(("boost" ,boost)
> +       ("freetype" ,freetype)
> +       ("harfbuzz" ,harfbuzz)
> +       ("icu4c" ,icu4c)
> +       ("libjpeg-turbo" ,libjpeg-turbo)
> +       ("libpng" ,libpng)
> +       ("libtiff" ,libtiff)
> +       ("proj.4" ,proj.4)
> +       ("zlib" ,zlib)))

Have you tried to add these dependencies to gain potentially more
rendering input/output:

libwebp
cairo
sqlite

[..]

> +    (license license:lgpl2.1+)))

Many files under ./demo are licensed under "license:gpl2.0+". Add that
license, too.

Furthermore, there are:

license:boost1.0 ;; deps/boost
license:bsd3 ;; deps/mapbox and deps/mapnik/sparsehash

Finally, dep/agg has another license. Is it expat or even less? Here it
is:

// Permission to copy, use, modify, sell and distribute this software
// is granted provided this copyright notice appears in all copies.
// This software is provided "as is" without express or implied
// warranty, and with no claim as to its suitability for any purpose.



Otherwise, LGTM.

Bj=C3=B6rn