* [bug#30433] [PATCH] gnu: Add epipe.
@ 2018-02-12 7:48 Oleg Pykhalov
2018-02-12 19:38 ` Leo Famulari
0 siblings, 1 reply; 5+ messages in thread
From: Oleg Pykhalov @ 2018-02-12 7:48 UTC (permalink / raw)
To: 30433
* gnu/packages/emacs.scm (epipe): New public variable.
---
gnu/packages/emacs.scm | 45 +++++++++++++++++++++++++++++++++++++++++++++
1 file changed, 45 insertions(+)
diff --git a/gnu/packages/emacs.scm b/gnu/packages/emacs.scm
index 99e78d454..98d0ee1fb 100644
--- a/gnu/packages/emacs.scm
+++ b/gnu/packages/emacs.scm
@@ -7064,3 +7064,48 @@ navigation with the grails mode.")
@code{org-tree-slide-mode} to enter the slideshow mode, and then @kbd{C->} and
@kbd{C-<} to jump to the next and previous slide.")
(license license:gpl3+))))
+
+(define-public epipe
+ (let ((commit "c966d549d5416fb92ecf4bd4a0a5a8fc9239e3af")
+ (revision "1"))
+ (package
+ (name "epipe")
+ (version (string-append "0.0.1" "-" revision "."
+ (string-take commit 7)))
+ (source (origin
+ (method git-fetch)
+ (uri (git-reference
+ (url "https://github.com/cute-jumper/epipe")
+ (commit commit)))
+ (file-name (string-append name "-" version "-checkout"))
+ (sha256
+ (base32
+ "0lkisi1s7sn12nx8zh58qmsxwnk1rjwryj18wcbr148xqz3swg57"))))
+ (build-system trivial-build-system)
+ (inputs
+ `(("bash" ,bash)
+ ("perl" ,perl)))
+ (arguments
+ '(#:modules ((guix build utils))
+ #:builder
+ (begin
+ (use-modules (guix build utils))
+ ;; Copy source
+ (copy-recursively (assoc-ref %build-inputs "source") ".")
+ ;; Patch shebangs
+ (substitute* "epipe"
+ (("/usr/bin/env bash")
+ (string-append (assoc-ref %build-inputs "bash") "/bin/bash")))
+ (substitute* "epipe.pl"
+ (("/usr/bin/perl")
+ (string-append (assoc-ref %build-inputs "perl") "/bin/perl")))
+ ;; Installation
+ (for-each (lambda (file)
+ (install-file file (string-append %output "/bin")))
+ '("epipe" "epipe.pl"))
+ #t)))
+ (home-page "https://github.com/cute-jumper/epipe")
+ (synopsis "Pipe to the @code{emacsclient}")
+ (description "@code{epipe} provides an utility to use your editor in
+the pipeline, featuring the support for running @code{emacsclient}.")
+ (license license:gpl3+))))
--
2.15.1
^ permalink raw reply related [flat|nested] 5+ messages in thread* [bug#30433] [PATCH] gnu: Add epipe.
2018-02-12 7:48 [bug#30433] [PATCH] gnu: Add epipe Oleg Pykhalov
@ 2018-02-12 19:38 ` Leo Famulari
2018-02-14 13:14 ` Oleg Pykhalov
0 siblings, 1 reply; 5+ messages in thread
From: Leo Famulari @ 2018-02-12 19:38 UTC (permalink / raw)
To: Oleg Pykhalov; +Cc: 30433
[-- Attachment #1: Type: text/plain, Size: 1706 bytes --]
On Mon, Feb 12, 2018 at 10:48:51AM +0300, Oleg Pykhalov wrote:
> * gnu/packages/emacs.scm (epipe): New public variable.
Thanks!
> +(define-public epipe
> + (let ((commit "c966d549d5416fb92ecf4bd4a0a5a8fc9239e3af")
> + (revision "1"))
> + (package
> + (name "epipe")
> + (version (string-append "0.0.1" "-" revision "."
> + (string-take commit 7)))
This commit corresponds to the upstream tag "0.1.0", so you can omit the
commit and revision variables, and just set the version to "0.1.0"...
> + (source (origin
> + (method git-fetch)
> + (uri (git-reference
> + (url "https://github.com/cute-jumper/epipe")
> + (commit commit)))
... and here use (commit version).
> + (arguments
> + '(#:modules ((guix build utils))
> + #:builder
> + (begin
> + (use-modules (guix build utils))
> + ;; Copy source
> + (copy-recursively (assoc-ref %build-inputs "source") ".")
> + ;; Patch shebangs
> + (substitute* "epipe"
> + (("/usr/bin/env bash")
> + (string-append (assoc-ref %build-inputs "bash") "/bin/bash")))
> + (substitute* "epipe.pl"
> + (("/usr/bin/perl")
> + (string-append (assoc-ref %build-inputs "perl") "/bin/perl")))
> + ;; Installation
> + (for-each (lambda (file)
> + (install-file file (string-append %output "/bin")))
> + '("epipe" "epipe.pl"))
> + #t)))
I think you could use the patch-shebang procedure from (guix build
utils), as in the package for woof.
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
^ permalink raw reply [flat|nested] 5+ messages in thread* [bug#30433] [PATCH] gnu: Add epipe.
2018-02-12 19:38 ` Leo Famulari
@ 2018-02-14 13:14 ` Oleg Pykhalov
2018-02-14 20:51 ` Leo Famulari
0 siblings, 1 reply; 5+ messages in thread
From: Oleg Pykhalov @ 2018-02-14 13:14 UTC (permalink / raw)
To: Leo Famulari; +Cc: 30433
[-- Attachment #1: Type: text/plain, Size: 2210 bytes --]
Leo Famulari <leo@famulari.name> writes:
> On Mon, Feb 12, 2018 at 10:48:51AM +0300, Oleg Pykhalov wrote:
>> * gnu/packages/emacs.scm (epipe): New public variable.
>
> Thanks!
Thank you for review.
>> +(define-public epipe
>> + (let ((commit "c966d549d5416fb92ecf4bd4a0a5a8fc9239e3af")
>> + (revision "1"))
>> + (package
>> + (name "epipe")
>> + (version (string-append "0.0.1" "-" revision "."
>> + (string-take commit 7)))
>
> This commit corresponds to the upstream tag "0.1.0", so you can omit the
> commit and revision variables, and just set the version to "0.1.0"...
Maybe it's better to get a source via url-fetch from GitHub archive
tarball?
>> + (source (origin
>> + (method git-fetch)
>> + (uri (git-reference
>> + (url "https://github.com/cute-jumper/epipe")
>> + (commit commit)))
>
> ... and here use (commit version).
OK.
>> + (arguments
>> + '(#:modules ((guix build utils))
>> + #:builder
>> + (begin
>> + (use-modules (guix build utils))
>> + ;; Copy source
>> + (copy-recursively (assoc-ref %build-inputs "source") ".")
>> + ;; Patch shebangs
>> + (substitute* "epipe"
>> + (("/usr/bin/env bash")
>> + (string-append (assoc-ref %build-inputs "bash") "/bin/bash")))
>> + (substitute* "epipe.pl"
>> + (("/usr/bin/perl")
>> + (string-append (assoc-ref %build-inputs "perl") "/bin/perl")))
>> + ;; Installation
>> + (for-each (lambda (file)
>> + (install-file file (string-append %output "/bin")))
>> + '("epipe" "epipe.pl"))
>> + #t)))
>
> I think you could use the patch-shebang procedure from (guix build
> utils), as in the package for woof.
As I see only for Perl, because folling does nothing:
--8<---------------cut here---------------start------------->8---
(patch-shebang "epipe"
(list (string-append (assoc-ref %build-inputs "bash")
"/bin")))
--8<---------------cut here---------------end--------------->8---
Oleg.
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 832 bytes --]
^ permalink raw reply [flat|nested] 5+ messages in thread* [bug#30433] [PATCH] gnu: Add epipe.
2018-02-14 13:14 ` Oleg Pykhalov
@ 2018-02-14 20:51 ` Leo Famulari
2018-02-15 17:47 ` Oleg Pykhalov
0 siblings, 1 reply; 5+ messages in thread
From: Leo Famulari @ 2018-02-14 20:51 UTC (permalink / raw)
To: Oleg Pykhalov; +Cc: 30433
[-- Attachment #1: Type: text/plain, Size: 921 bytes --]
On Wed, Feb 14, 2018 at 04:14:15PM +0300, Oleg Pykhalov wrote:
> Leo Famulari <leo@famulari.name> writes:
> > This commit corresponds to the upstream tag "0.1.0", so you can omit the
> > commit and revision variables, and just set the version to "0.1.0"...
>
> Maybe it's better to get a source via url-fetch from GitHub archive
> tarball?
Yeah, if the result is the same I think it's better to use url-fetch.
> > I think you could use the patch-shebang procedure from (guix build
> > utils), as in the package for woof.
>
> As I see only for Perl, because folling does nothing:
> --8<---------------cut here---------------start------------->8---
> (patch-shebang "epipe"
> (list (string-append (assoc-ref %build-inputs "bash")
> "/bin")))
> --8<---------------cut here---------------end--------------->8---
Huh, weird! Well, I think that whatever works should be fine.
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
^ permalink raw reply [flat|nested] 5+ messages in thread
* [bug#30433] [PATCH] gnu: Add epipe.
2018-02-14 20:51 ` Leo Famulari
@ 2018-02-15 17:47 ` Oleg Pykhalov
0 siblings, 0 replies; 5+ messages in thread
From: Oleg Pykhalov @ 2018-02-15 17:47 UTC (permalink / raw)
To: Leo Famulari; +Cc: 30433, 30433-done
[-- Attachment #1: Type: text/plain, Size: 1088 bytes --]
Leo Famulari <leo@famulari.name> writes:
> On Wed, Feb 14, 2018 at 04:14:15PM +0300, Oleg Pykhalov wrote:
>> Leo Famulari <leo@famulari.name> writes:
>> > This commit corresponds to the upstream tag "0.1.0", so you can omit the
>> > commit and revision variables, and just set the version to "0.1.0"...
>>
>> Maybe it's better to get a source via url-fetch from GitHub archive
>> tarball?
>
> Yeah, if the result is the same I think it's better to use url-fetch.
OK.
>> > I think you could use the patch-shebang procedure from (guix build
>> > utils), as in the package for woof.
>>
>> As I see only for Perl, because folling does nothing:
>> --8<---------------cut here---------------start------------->8---
>> (patch-shebang "epipe"
>> (list (string-append (assoc-ref %build-inputs "bash")
>> "/bin")))
>> --8<---------------cut here---------------end--------------->8---
>
> Huh, weird! Well, I think that whatever works should be fine.
Pushed as 5b2382929959db9d883982329ec8fdf4103a9351
I'll close the bug report.
Oleg.
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 832 bytes --]
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2018-02-15 17:48 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2018-02-12 7:48 [bug#30433] [PATCH] gnu: Add epipe Oleg Pykhalov
2018-02-12 19:38 ` Leo Famulari
2018-02-14 13:14 ` Oleg Pykhalov
2018-02-14 20:51 ` Leo Famulari
2018-02-15 17:47 ` Oleg Pykhalov
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/guix.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).