From: Leo Famulari <leo@famulari.name>
To: Pierre Langlois <pierre.langlois@gmx.com>
Cc: 30400@debbugs.gnu.org
Subject: [bug#30400] [PATCH] gnu: clementine: Remove Spotify downloader.
Date: Fri, 9 Feb 2018 13:36:35 -0500 [thread overview]
Message-ID: <20180209183635.GB2356@jasmine.lan> (raw)
In-Reply-To: <cubd11f6puo.fsf@gmx.com>
[-- Attachment #1: Type: text/plain, Size: 1094 bytes --]
On Thu, Feb 08, 2018 at 11:09:19PM +0000, Pierre Langlois wrote:
> Hi Guix!
>
> I realized today that a new version of crypto++ was out so I set out to
> update it but Clementine failed to compile. There's a patch on master [0]
> that fixes the issue so I was going to apply it when I realized the bit
> of code in question downloads a binary blob to support Spotify. It
> turns out there's a button in the preference menu that allows users to
> download this proprietary blob, and crypto++ appears to be used to check
> it.
Thanks for pointing this out! I reindented the #:configure-flags and
added some comments to the first patch, and pushed as
af414f34fb6e3609e572880f3b0b3bbcb1b3bfc6
My understanding of the FSDG [0] makes me think that we'll need to go
further and, in an origin snippet, remove the code performs the download
of the non-free component. This would mean that `guix build --source
clementine` would return something that follows the FSDG. CC-ing Ludo
for clarification.
[0]
https://www.gnu.org/distros/free-system-distribution-guidelines.en.html
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
next prev parent reply other threads:[~2018-02-09 18:37 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-02-08 23:09 [bug#30400] [PATCH] gnu: clementine: Remove Spotify downloader Pierre Langlois
2018-02-09 18:36 ` Leo Famulari [this message]
2018-02-09 22:12 ` Ludovic Courtès
2018-02-09 18:37 ` Leo Famulari
2018-02-15 9:33 ` bug#30400: " Ludovic Courtès
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://guix.gnu.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180209183635.GB2356@jasmine.lan \
--to=leo@famulari.name \
--cc=30400@debbugs.gnu.org \
--cc=pierre.langlois@gmx.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/guix.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).