From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:40641) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ekDXm-0000kw-4u for guix-patches@gnu.org; Fri, 09 Feb 2018 13:37:07 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1ekDXi-00051w-6u for guix-patches@gnu.org; Fri, 09 Feb 2018 13:37:06 -0500 Received: from debbugs.gnu.org ([208.118.235.43]:56010) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1ekDXh-00051m-UA for guix-patches@gnu.org; Fri, 09 Feb 2018 13:37:02 -0500 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1ekDXh-0002pw-L3 for guix-patches@gnu.org; Fri, 09 Feb 2018 13:37:01 -0500 Subject: [bug#30400] [PATCH] gnu: clementine: Remove Spotify downloader. Resent-Message-ID: Date: Fri, 9 Feb 2018 13:36:35 -0500 From: Leo Famulari Message-ID: <20180209183635.GB2356@jasmine.lan> References: MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="NMuMz9nt05w80d4+" Content-Disposition: inline In-Reply-To: List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+kyle=kyleam.com@gnu.org Sender: "Guix-patches" To: Pierre Langlois Cc: 30400@debbugs.gnu.org --NMuMz9nt05w80d4+ Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Thu, Feb 08, 2018 at 11:09:19PM +0000, Pierre Langlois wrote: > Hi Guix! >=20 > I realized today that a new version of crypto++ was out so I set out to > update it but Clementine failed to compile. There's a patch on master [0] > that fixes the issue so I was going to apply it when I realized the bit > of code in question downloads a binary blob to support Spotify. It > turns out there's a button in the preference menu that allows users to > download this proprietary blob, and crypto++ appears to be used to check > it. Thanks for pointing this out! I reindented the #:configure-flags and added some comments to the first patch, and pushed as af414f34fb6e3609e572880f3b0b3bbcb1b3bfc6 My understanding of the FSDG [0] makes me think that we'll need to go further and, in an origin snippet, remove the code performs the download of the non-free component. This would mean that `guix build --source clementine` would return something that follows the FSDG. CC-ing Ludo for clarification. [0] https://www.gnu.org/distros/free-system-distribution-guidelines.en.html --NMuMz9nt05w80d4+ Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQIzBAABCAAdFiEEsFFZSPHn08G5gDigJkb6MLrKfwgFAlp96jMACgkQJkb6MLrK fwj9iA/9GWdwDPvcxTfjNsZM/z+M7kjJ0/QLtU49MqdrN7aIpvpzDTXYocMIqoMi vncs4xK+xbWQiA/fcE1hpJjIYW0wyqhwqRwb67UjeG18/rctlv12/2j1pU5ZVBFe yDppLkKe89uQaDI7xum2XRra5DiHQxuc5DK4dHSTluEO9kgFc8TE4vVcT8YBTwIX ACnW6264ub4RNXsbJB6iaLPc+szUtbxrULFISVojyxbJ9nmq/MVkNpvHcwcO3DuD /hyVDZ+5UJDDKhcopHgj8vjsPCTLIcNFx8UJ/BfM2UuYTzd0SkhBSDHvS7eSuDEu rZ64tFp6WzLL8rD6CvDKrYcwQelZb1XRzwHVgOMS1Y1et5lKyp5VT+/uey0NCELp gPPRYr/OW6tj6bx8TuIZxJBjc9K8EGe/7LoUhLHVaNCyATPdaOGtS/xGWjTVx9hY RzKefct904JcA2XULKHSFWKN7STFeK+3Uc49orInCZF5YuAjhrgMiHUHPgD8stXt fPjtrhhc50ZqUM2S84fxipQeGq8d8OQzn9hQt1LwsBRxuuQdYYlOushErCkwS2Hi oOJ3ZyrS4t3LEn4j7TM7KP5AyVz94K/Z0WHsgS4lBgO4C+yKT+bJO3dOQK/tDirB 1894Ep1LRqRLC5t7h37nb3Ld4t1SOkUqlbaITFr7plSpmtdI8F8= =8fpS -----END PGP SIGNATURE----- --NMuMz9nt05w80d4+--