[bug#29764] [PATCH] gnu: lollypop: Use meson-build-system.

[bug#29764] [PATCH] gnu: lollypop: Use meson-build-system.

[Thomas Danckaert]

[-- Attachment #1: Type: Text/Plain, Size: 175 bytes --]

Hi Guix,

this patch replaces the “pseudo meson build system” for lollypop by 
the real thing ;-) (By the way, the current build doesn't succeed 
anymore.)

Thomas

[-- Attachment #2: 0001-gnu-lollypop-Use-meson-build-system.patch --]
[-- Type: Text/X-Patch, Size: 3069 bytes --]

From fb89164e2983ebb61b0920d52fcce04d6ac9e9da Mon Sep 17 00:00:00 2001
From: Thomas Danckaert <thomas.danckaert@gmail.com>
Date: Mon, 18 Dec 2017 11:10:27 +0100
Subject: [PATCH] gnu: lollypop: Use meson-build-system.

* gnu/packages/gnome.scm (lollypop) [build-system]: Use meson-build-system.
[arguments]: Remove phases for "pseudo meson build system", enable
glib-or-gtk?
[native-inputs]: Add glib:bin and gtk+:bin, remove ninja.
[inputs]: Remove gtk+ and meson.
---
 gnu/packages/gnome.scm | 26 +++++---------------------
 1 file changed, 5 insertions(+), 21 deletions(-)

diff --git a/gnu/packages/gnome.scm b/gnu/packages/gnome.scm
index 7b93ddd14..71a675169 100644
--- a/gnu/packages/gnome.scm
+++ b/gnu/packages/gnome.scm
@@ -6925,47 +6925,31 @@ views can be printed as PDF or PostScript files, or exported to HTML.")
        (sha256
         (base32
          "070y6wf1180hbl1ix8al7fmc6y06jb5m14h73g509g4xbwlk62g8"))))
-    ;; TODO: Use meson-build-system
-    (build-system glib-or-gtk-build-system)
+    (build-system meson-build-system)
     (arguments
-     `(#:imported-modules ((guix build python-build-system)
-                           ,@%glib-or-gtk-build-system-modules)
+     `(#:glib-or-gtk? #t
        #:tests? #f ; no test suite
        #:phases
        (modify-phases %standard-phases
-         (delete 'configure)
-         (replace 'build
-           (lambda* (#:key inputs outputs #:allow-other-keys)
-             (let ((out (assoc-ref outputs "out")))
-               ;; remove post-install script, we update the caches later
-               (substitute* "meson.build"
-                 (("meson.add_install_script\\('meson_post_install.py'\\)") ""))
-               (zero?
-                 (system* "meson" "builddir" (string-append "--prefix=" out))))))
-         (replace 'install
-           (lambda _ (zero? (system* "ninja" "-C" "builddir" "install"))))
          (add-after 'install 'wrap-program
            (lambda* (#:key outputs #:allow-other-keys)
              (let ((out               (assoc-ref outputs "out"))
                    (gi-typelib-path   (getenv "GI_TYPELIB_PATH")))
                (wrap-program (string-append out "/bin/lollypop")
                  `("GI_TYPELIB_PATH" ":" prefix (,gi-typelib-path))))
-             #t))
-         (add-after 'install 'wrap
-           (@@ (guix build python-build-system) wrap)))))
+             #t)))))
     (native-inputs
      `(("intltool" ,intltool)
        ("itstool" ,itstool)
-       ("ninja" ,ninja)
+       ("glib:bin" ,glib "bin")         ; For glib-compile-resources
+       ("gtk+:bin" ,gtk+ "bin")         ; For gtk-update-icon-cache
        ("pkg-config" ,pkg-config)))
     (inputs
      `(("gobject-introspection" ,gobject-introspection)
        ("gst-plugins-base" ,gst-plugins-base)
-       ("gtk+" ,gtk+)
        ("libnotify" ,libnotify)
        ("libsecret" ,libsecret)
        ("libsoup" ,libsoup)
-       ("meson" ,meson)
        ("python" ,python)
        ("python-beautifulsoup4" ,python-beautifulsoup4)
        ("python-gst" ,python-gst)
-- 
2.15.1

[bug#29764] [PATCH] gnu: lollypop: Use meson-build-system.

[Catonano]

[-- Attachment #1: Type: text/plain, Size: 2756 bytes --]

2017-12-18 11:19 GMT+01:00 Thomas Danckaert <post@thomasdanckaert.be>:

> Hi Guix,
>
> this patch replaces the “pseudo meson build system” for lollypop by the
> real thing ;-) (By the way, the current build doesn't succeed anymore.)
>
> Thomas
>

Hi Thomas !

I built it successfully, but then it doesn't run

When I launch it I get this


~$ lollypop
Traceback (most recent call last):
  File
"/gnu/store/l5n28ysri426fnmavvlbqrkrqxl15xvm-lollypop-0.9.304/bin/..lollypop-real-real",
line 17, in <module>
    from gi.repository import Gio
ImportError: No module named 'gi'

Sorry 😯

Is it missing a module or did I do anything wrong ?

To be noted that I had these messages, when I installed it

warning: collision encountered:
/gnu/store/l5n28ysri426fnmavvlbqrkrqxl15xvm-lollypop-0.9.304/share/icons/hicolor/icon-theme.cache
/gnu/store/cgss6y4pmpj7y9sysnab3k1nirw0fkyv-polari-3.27.2/share/icons/hicolor/icon-theme.cache
/gnu/store/6pcjpiznq2vrjr7aj14qkf6fkfw7qgxc-eolie-0.9.12/share/icons/hicolor/icon-theme.cache

warning: arbitrarily choosing
/gnu/store/l5n28ysri426fnmavvlbqrkrqxl15xvm-lollypop-0.9.304/share/icons/hicolor/icon-theme.cache
Creating manual page database...
726 entries processed in 0.5 s
warning: collision encountered:
/gnu/store/0hsyvrykwyjsr2f4bm75nhrk5xz5gz0l-gtk-icon-themes/share/icons/hicolor/icon-theme.cache
/gnu/store/l5n28ysri426fnmavvlbqrkrqxl15xvm-lollypop-0.9.304/share/icons/hicolor/icon-theme.cache
/gnu/store/cgss6y4pmpj7y9sysnab3k1nirw0fkyv-polari-3.27.2/share/icons/hicolor/icon-theme.cache
/gnu/store/6pcjpiznq2vrjr7aj14qkf6fkfw7qgxc-eolie-0.9.12/share/icons/hicolor/icon-theme.cache

warning: arbitrarily choosing
/gnu/store/0hsyvrykwyjsr2f4bm75nhrk5xz5gz0l-gtk-icon-themes/share/icons/hicolor/icon-theme.cache
warning: collision encountered:
/gnu/store/l5n28ysri426fnmavvlbqrkrqxl15xvm-lollypop-0.9.304/share/glib-2.0/schemas/gschemas.compiled
/gnu/store/cgss6y4pmpj7y9sysnab3k1nirw0fkyv-polari-3.27.2/share/glib-2.0/schemas/gschemas.compiled
/gnu/store/snrq9ciwygj318s5jp5d2rg0zgr8hx2n-gnome-screenshot-3.22.0/share/glib-2.0/schemas/gschemas.compiled
/gnu/store/6pcjpiznq2vrjr7aj14qkf6fkfw7qgxc-eolie-0.9.12/share/glib-2.0/schemas/gschemas.compiled

warning: arbitrarily choosing
/gnu/store/l5n28ysri426fnmavvlbqrkrqxl15xvm-lollypop-0.9.304/share/glib-2.0/schemas/gschemas.compiled
warning: collision encountered:
/gnu/store/zihybmvkccjb310fsxc2sad5j0w5vdi1-magit-2.11.0/share/info/magit-popup.info.gz
/gnu/store/mwpzwplrdvzzhnzkzf2nc8hyskk27ris-emacs-magit-popup-2.12.0/share/info/magit-popup.info.gz

warning: arbitrarily choosing
/gnu/store/zihybmvkccjb310fsxc2sad5j0w5vdi1-magit-2.11.0/share/info/magit-popup.info.gz
64 packages in profile

[-- Attachment #2: Type: text/html, Size: 3417 bytes --]

[bug#29764] [PATCH] gnu: lollypop: Use meson-build-system.

[Thomas Danckaert]

[-- Attachment #1: Type: Text/Plain, Size: 1016 bytes --]

From: Catonano <catonano@gmail.com>
Subject: Re: [bug#29764] [PATCH] gnu: lollypop: Use 
meson-build-system.
Date: Thu, 21 Dec 2017 21:54:50 +0100

> Hi Thomas !
>
> I built it successfully, but then it doesn't run
>
> When I launch it I get this
>
> ~$ lollypop
> Traceback (most recent call last):
>   File 
> "/gnu/store/l5n28ysri426fnmavvlbqrkrqxl15xvm-lollypop-0.9.304/bin/..lollypop-real-real", 
> line
> 17, in <module>
>     from gi.repository import Gio
> ImportError: No module named 'gi'
>
> Sorry 😯
>
> Is it missing a module or did I do anything wrong ?

Hi Catonano,

thanks for the test!  There was a bug in the patch: I shouldn't have 
deleted the “wrap” phase from the Python build system, because 
lollypop needs the python bindings for GObject (python-pygobject) at 
runtime.  I didn't notice the problem myself, because I have 
python-pygobject installed in my user profile.

The attached patch should fix it... would you mind testing again?

Thomas

[-- Attachment #2: 0001-gnu-lollypop-Use-meson-build-system.patch --]
[-- Type: Text/X-Patch, Size: 2866 bytes --]

From 1f330428d76b6cb4f7bedb8b09cb8359ac927dc2 Mon Sep 17 00:00:00 2001
From: Thomas Danckaert <thomas.danckaert@gmail.com>
Date: Mon, 18 Dec 2017 11:10:27 +0100
Subject: [PATCH] gnu: lollypop: Use meson-build-system.

* gnu/packages/gnome.scm (lollypop) [build-system]: Use meson-build-system.
[arguments]: Remove phases for "pseudo meson build system", enable
[native-inputs]: Add glib:bin and gtk+:bin, remove ninja.
[inputs]: Remove gtk+ and meson.
---
 gnu/packages/gnome.scm | 22 +++++-----------------
 1 file changed, 5 insertions(+), 17 deletions(-)

diff --git a/gnu/packages/gnome.scm b/gnu/packages/gnome.scm
index 7b93ddd14..80f210bd6 100644
--- a/gnu/packages/gnome.scm
+++ b/gnu/packages/gnome.scm
@@ -6925,25 +6925,14 @@ views can be printed as PDF or PostScript files, or exported to HTML.")
        (sha256
         (base32
          "070y6wf1180hbl1ix8al7fmc6y06jb5m14h73g509g4xbwlk62g8"))))
-    ;; TODO: Use meson-build-system
-    (build-system glib-or-gtk-build-system)
+    (build-system meson-build-system)
     (arguments
      `(#:imported-modules ((guix build python-build-system)
-                           ,@%glib-or-gtk-build-system-modules)
+                           ,@%meson-build-system-modules)
+       #:glib-or-gtk? #t
        #:tests? #f ; no test suite
        #:phases
        (modify-phases %standard-phases
-         (delete 'configure)
-         (replace 'build
-           (lambda* (#:key inputs outputs #:allow-other-keys)
-             (let ((out (assoc-ref outputs "out")))
-               ;; remove post-install script, we update the caches later
-               (substitute* "meson.build"
-                 (("meson.add_install_script\\('meson_post_install.py'\\)") ""))
-               (zero?
-                 (system* "meson" "builddir" (string-append "--prefix=" out))))))
-         (replace 'install
-           (lambda _ (zero? (system* "ninja" "-C" "builddir" "install"))))
          (add-after 'install 'wrap-program
            (lambda* (#:key outputs #:allow-other-keys)
              (let ((out               (assoc-ref outputs "out"))
@@ -6956,16 +6945,15 @@ views can be printed as PDF or PostScript files, or exported to HTML.")
     (native-inputs
      `(("intltool" ,intltool)
        ("itstool" ,itstool)
-       ("ninja" ,ninja)
+       ("glib:bin" ,glib "bin")         ; For glib-compile-resources
+       ("gtk+:bin" ,gtk+ "bin")         ; For gtk-update-icon-cache
        ("pkg-config" ,pkg-config)))
     (inputs
      `(("gobject-introspection" ,gobject-introspection)
        ("gst-plugins-base" ,gst-plugins-base)
-       ("gtk+" ,gtk+)
        ("libnotify" ,libnotify)
        ("libsecret" ,libsecret)
        ("libsoup" ,libsoup)
-       ("meson" ,meson)
        ("python" ,python)
        ("python-beautifulsoup4" ,python-beautifulsoup4)
        ("python-gst" ,python-gst)
-- 
2.15.1

[bug#29764] [PATCH] gnu: lollypop: Use meson-build-system.

[Ludovic Courtès]

Hello Thomas,

Thomas Danckaert <post@thomasdanckaert.be> skribis:

> this patch replaces the “pseudo meson build system” for lollypop by
> the real thing ;-) (By the way, the current build doesn't succeed
> anymore.)
>
> Thomas
>
>>From fb89164e2983ebb61b0920d52fcce04d6ac9e9da Mon Sep 17 00:00:00 2001
> From: Thomas Danckaert <thomas.danckaert@gmail.com>
> Date: Mon, 18 Dec 2017 11:10:27 +0100
> Subject: [PATCH] gnu: lollypop: Use meson-build-system.
>
> * gnu/packages/gnome.scm (lollypop) [build-system]: Use meson-build-system.
> [arguments]: Remove phases for "pseudo meson build system", enable
> glib-or-gtk?
> [native-inputs]: Add glib:bin and gtk+:bin, remove ninja.
> [inputs]: Remove gtk+ and meson.

Go for it!

I suspect the error Catonano reports is not new and might be because
GI_TYPELIB_PATH lacks an entry or something along these lines.  This can
be investigated separately though.

Thanks,
Ludo’.

[bug#29764] [PATCH] gnu: lollypop: Use meson-build-system.

[Catonano]

[-- Attachment #1: Type: text/plain, Size: 2721 bytes --]

Thomas, Ludovic

2017-12-22 9:51 GMT+01:00 Ludovic Courtès <ludo@gnu.org>:

> Hello Thomas,
>
> Thomas Danckaert <post@thomasdanckaert.be> skribis:
>
> > this patch replaces the “pseudo meson build system” for lollypop by
> > the real thing ;-) (By the way, the current build doesn't succeed
> > anymore.)
> >
> > Thomas
> >
> >>From fb89164e2983ebb61b0920d52fcce04d6ac9e9da Mon Sep 17 00:00:00 2001
> > From: Thomas Danckaert <thomas.danckaert@gmail.com>
> > Date: Mon, 18 Dec 2017 11:10:27 +0100
> > Subject: [PATCH] gnu: lollypop: Use meson-build-system.
> >
> > * gnu/packages/gnome.scm (lollypop) [build-system]: Use
> meson-build-system.
> > [arguments]: Remove phases for "pseudo meson build system", enable
> > glib-or-gtk?
> > [native-inputs]: Add glib:bin and gtk+:bin, remove ninja.
> > [inputs]: Remove gtk+ and meson.
>
> Go for it!
>
> I suspect the error Catonano reports is not new and might be because
> GI_TYPELIB_PATH lacks an entry or something along these lines.  This can
> be investigated separately though.
>

I tested it with the new patch and this time it run

I have no music on this laptop so I didn't test it throughly

I did play with the preferences switches though and I didn't run into
runtime errors

This is a picture
https://imgur.com/a/kWAre

This is what happened in the terminal (is this phisiological or
pathological ?)

~$ lollypop
cannot import name 'BadAuthenticationError'
    - Scrobbler disabled
    - Auto cover download disabled
    - Artist information disabled
$ sudo pip3 install pylast
/gnu/store/ci1r0vymm49jlxhwv394aqk4shjmd6gh-python-pygobject-3.24.1/lib/python3.5/site-packages/gi/module.py:178:
Warning: g_array_append_vals: assertion 'array' failed
  g_type = info.get_g_type()
/gnu/store/ci1r0vymm49jlxhwv394aqk4shjmd6gh-python-pygobject-3.24.1/lib/python3.5/site-packages/gi/module.py:178:
Warning: g_hash_table_lookup: assertion 'hash_table != NULL' failed
  g_type = info.get_g_type()
/gnu/store/ci1r0vymm49jlxhwv394aqk4shjmd6gh-python-pygobject-3.24.1/lib/python3.5/site-packages/gi/module.py:178:
Warning: g_hash_table_insert_internal: assertion 'hash_table != NULL' failed
  g_type = info.get_g_type()


As you can see there's a

$ sudo pip3 install pylast

line in the output

I don't really understand how that's possible, but I checked this 2 times

Where can I download some mp3s legally ?
I would test it with some real music

When I quit it, there's this warning

(lollypop:2031): Gtk-WARNING **: Allocating size to
lollypop+selectionlist+SelectionList 0x13b2860 without calling
gtk_widget_get_preferred_width/height(). How does the code know the size to
allocate?

[-- Attachment #2: Type: text/html, Size: 3624 bytes --]

[bug#29764] [PATCH] gnu: lollypop: Use meson-build-system.

[Thomas Danckaert]

[-- Attachment #1: Type: Text/Plain, Size: 2006 bytes --]

From: Catonano <catonano@gmail.com>
Subject: Re: [bug#29764] [PATCH] gnu: lollypop: Use 
meson-build-system.
Date: Fri, 22 Dec 2017 20:02:38 +0100

> This is what happened in the terminal (is this phisiological or
> pathological ?)
>
> ~$ lollypop
> cannot import name 'BadAuthenticationError'
>     - Scrobbler disabled
>     - Auto cover download disabled
>     - Artist information disabled
> $ sudo pip3 install pylast
> /gnu/store/ci1r0vymm49jlxhwv394aqk4shjmd6gh-python-pygobject-3.24.1/
> lib/python3.5/site-packages/gi/module.py:178: Warning:
> g_array_append_vals: assertion 'array' failed
>   g_type = info.get_g_type()
> /gnu/store/ci1r0vymm49jlxhwv394aqk4shjmd6gh-python-pygobject-3.24.1/
> lib/python3.5/site-packages/gi/module.py:178: Warning:
> g_hash_table_lookup: assertion 'hash_table != NULL' failed
>   g_type = info.get_g_type()
> /gnu/store/ci1r0vymm49jlxhwv394aqk4shjmd6gh-python-pygobject-3.24.1/
> lib/python3.5/site-packages/gi/module.py:178: Warning:
> g_hash_table_insert_internal: assertion 'hash_table != NULL' failed
>   g_type = info.get_g_type()
>
> As you can see there's a
>
> $ sudo pip3 install pylast
>
> line in the output
>
> I don't really understand how that's possible, but I checked this 2
> times

Hi,

thanks for testing again.  I think the line about pylast is meant as 
an advice to install pylast, because there was an error interacting 
with that library.  This is fixed in version 0.9.306, so I included 
an update to this version in the patch.

I think the other warnings are “harmless”.

> Where can I download some mp3s legally ?
> I would test it with some real music

I can confirm it works here.  If you want to try it yourself: I don't 
have an example of an mp3 sample ready, but you could always extract 
the audio from an online video (youtube, vimeo, ...) using 
youtube-dl? (Or, if you still have cd's and such: extract one of your 
cd's to ogg or mp3)

cheers,

Thomas

[-- Attachment #2: 0001-gnu-lollypop-Use-meson-build-system-update-to-0.9.30.patch --]
[-- Type: Text/X-Patch, Size: 3514 bytes --]

From 4943ad1cd088f7d4328971cc0f5742d315612073 Mon Sep 17 00:00:00 2001
From: Thomas Danckaert <thomas.danckaert@gmail.com>
Date: Mon, 18 Dec 2017 11:10:27 +0100
Subject: [PATCH] gnu: lollypop: Use meson-build-system, update to 0.9.306.

* gnu/packages/gnome.scm (lollypop) [origin]: Update version to 0.9.306,
download tarball from gitlab.
[build-system]: Use meson-build-system.
[arguments]: Remove phases for "pseudo meson build system".
[native-inputs]: Add glib:bin and gtk+:bin, remove ninja.
[inputs]: Remove gtk+ and meson.
---
 gnu/packages/gnome.scm | 30 +++++++++---------------------
 1 file changed, 9 insertions(+), 21 deletions(-)

diff --git a/gnu/packages/gnome.scm b/gnu/packages/gnome.scm
index 7b93ddd14..6c1f41fd4 100644
--- a/gnu/packages/gnome.scm
+++ b/gnu/packages/gnome.scm
@@ -6915,35 +6915,24 @@ views can be printed as PDF or PostScript files, or exported to HTML.")
 (define-public lollypop
   (package
     (name "lollypop")
-    (version "0.9.304")
+    (version "0.9.306")
     (source
      (origin
        (method url-fetch)
-       (uri (string-append "https://github.com/gnumdk/lollypop/"
-                           "releases/download/" version "/"
+       (uri (string-append "https://gitlab.gnome.org/gnumdk/lollypop/uploads/"
+                           "b769805b7063ef9807e4e832e7e87ad2/"
                            name "-" version ".tar.xz"))
        (sha256
         (base32
-         "070y6wf1180hbl1ix8al7fmc6y06jb5m14h73g509g4xbwlk62g8"))))
-    ;; TODO: Use meson-build-system
-    (build-system glib-or-gtk-build-system)
+         "0c49v6793bywvh295xbii9yq21hh3qpmxwbgp9i71kj6r9grvhan"))))
+    (build-system meson-build-system)
     (arguments
      `(#:imported-modules ((guix build python-build-system)
-                           ,@%glib-or-gtk-build-system-modules)
+                           ,@%meson-build-system-modules)
+       #:glib-or-gtk? #t
        #:tests? #f ; no test suite
        #:phases
        (modify-phases %standard-phases
-         (delete 'configure)
-         (replace 'build
-           (lambda* (#:key inputs outputs #:allow-other-keys)
-             (let ((out (assoc-ref outputs "out")))
-               ;; remove post-install script, we update the caches later
-               (substitute* "meson.build"
-                 (("meson.add_install_script\\('meson_post_install.py'\\)") ""))
-               (zero?
-                 (system* "meson" "builddir" (string-append "--prefix=" out))))))
-         (replace 'install
-           (lambda _ (zero? (system* "ninja" "-C" "builddir" "install"))))
          (add-after 'install 'wrap-program
            (lambda* (#:key outputs #:allow-other-keys)
              (let ((out               (assoc-ref outputs "out"))
@@ -6956,16 +6945,15 @@ views can be printed as PDF or PostScript files, or exported to HTML.")
     (native-inputs
      `(("intltool" ,intltool)
        ("itstool" ,itstool)
-       ("ninja" ,ninja)
+       ("glib:bin" ,glib "bin")         ; For glib-compile-resources
+       ("gtk+:bin" ,gtk+ "bin")         ; For gtk-update-icon-cache
        ("pkg-config" ,pkg-config)))
     (inputs
      `(("gobject-introspection" ,gobject-introspection)
        ("gst-plugins-base" ,gst-plugins-base)
-       ("gtk+" ,gtk+)
        ("libnotify" ,libnotify)
        ("libsecret" ,libsecret)
        ("libsoup" ,libsoup)
-       ("meson" ,meson)
        ("python" ,python)
        ("python-beautifulsoup4" ,python-beautifulsoup4)
        ("python-gst" ,python-gst)
-- 
2.15.1

[bug#29764] [PATCH] gnu: lollypop: Use meson-build-system.

[Catonano]

[-- Attachment #1: Type: text/plain, Size: 2365 bytes --]

Hi Thomas !

2017-12-26 13:13 GMT+01:00 Thomas Danckaert <post@thomasdanckaert.be>:

> From: Catonano <catonano@gmail.com>
> Subject: Re: [bug#29764] [PATCH] gnu: lollypop: Use meson-build-system.
> Date: Fri, 22 Dec 2017 20:02:38 +0100
>
>
> This is what happened in the terminal (is this phisiological or
>> pathological ?)
>>
>> ~$ lollypop
>> cannot import name 'BadAuthenticationError'
>>     - Scrobbler disabled
>>     - Auto cover download disabled
>>     - Artist information disabled
>> $ sudo pip3 install pylast
>> /gnu/store/ci1r0vymm49jlxhwv394aqk4shjmd6gh-python-pygobject-3.24.1/
>> lib/python3.5/site-packages/gi/module.py:178: Warning:
>> g_array_append_vals: assertion 'array' failed
>>   g_type = info.get_g_type()
>> /gnu/store/ci1r0vymm49jlxhwv394aqk4shjmd6gh-python-pygobject-3.24.1/
>> lib/python3.5/site-packages/gi/module.py:178: Warning:
>> g_hash_table_lookup: assertion 'hash_table != NULL' failed
>>   g_type = info.get_g_type()
>> /gnu/store/ci1r0vymm49jlxhwv394aqk4shjmd6gh-python-pygobject-3.24.1/
>> lib/python3.5/site-packages/gi/module.py:178: Warning:
>> g_hash_table_insert_internal: assertion 'hash_table != NULL' failed
>>   g_type = info.get_g_type()
>>
>> As you can see there's a
>>
>> $ sudo pip3 install pylast
>>
>> line in the output
>>
>> I don't really understand how that's possible, but I checked this 2
>> times
>>
>
> Hi,
>
> thanks for testing again.  I think the line about pylast is meant as an
> advice to install pylast, because there was an error interacting with that
> library.  This is fixed in version 0.9.306, so I included an update to this
> version in the patch.
>
> I think the other warnings are “harmless”.


Ok, I built it again and there are no issues now, only those harmless
warnings


>
>
> Where can I download some mp3s legally ?
>> I would test it with some real music
>>
>
> I can confirm it works here.  If you want to try it yourself: I don't have
> an example of an mp3 sample ready, but you could always extract the audio
> from an online video (youtube, vimeo, ...) using youtube-dl? (Or, if you
> still have cd's and such: extract one of your cd's to ogg or mp3)
>

ehm, if you say it works for you, I'll believe you. I'm not ready to fiddle
with mp3 extrraction now

So, as far as I am concerned, LGTM !

[-- Attachment #2: Type: text/html, Size: 3363 bytes --]

bug#29764: [PATCH] gnu: lollypop: Use meson-build-system.

[Thomas Danckaert]

From: Catonano <catonano@gmail.com>
Subject: Re: [bug#29764] [PATCH] gnu: lollypop: Use 
meson-build-system.
Date: Tue, 26 Dec 2017 14:56:37 +0100

> ehm, if you say it works for you, I'll believe you. I'm not ready 
> to fiddle with mp3 extrraction now

Well I just meant, perhaps you wanted to check if it works on your 
system, too (because sometimes certain issues only occur on specific 
configurations).  Anyway, I'm quite confident it's ok now, and the 
patch is definitely an improvement over the status quo, so I pushed 
it :)

Thanks for your time!

Thomas