From: Julien Lepiller <julien@lepiller.eu>
To: 29359@debbugs.gnu.org
Subject: [bug#29359] [PATCH 20/31] gnu: Add java-xpp3.
Date: Sat, 16 Dec 2017 21:17:11 +0100 [thread overview]
Message-ID: <20171216211711.4c324573@lepiller.eu> (raw)
In-Reply-To: <87fu8aocm4.fsf@elephly.net>
Le Sat, 16 Dec 2017 17:34:43 +0100,
Ricardo Wurmus <rekado@elephly.net> a écrit :
> Julien Lepiller <julien@lepiller.eu> writes:
>
> > * gnu/packages/java.scm (java-xpp3): New variable.
>
> Please move it to xml.scm.
>
> […]
>
> > + (modify-phases %standard-phases
> > + (replace 'install
> > + (lambda* (#:key outputs #:allow-other-keys)
> > + (let ((out (string-append (assoc-ref outputs "out")
> > "/share/java")))
> > + (mkdir-p out)
> > + (copy-file (string-append "build/xpp3-" ,version
> > ".jar")
> > + (string-append out "/xpp3.jar")))
> > + #t)))))
>
> Same as for java-xmlpull2: please use “install-jars”, if possible.
>
> > + (home-page "http://www.extreme.indiana.edu/xgws/xsoap/xpp/")
> > + (synopsis "Streaming pull XML parser")
> > + (description "Xml Pull Parser (in short XPP) is a streaming
> > pull XML +parser and should be used when there is a need to process
> > quickly and +efficiently all input elements (for example in SOAP
> > processors).")
>
> Please capitalize “Xml”. How does this differ from java-xmlpull2?
> Could you come up with a better description maybe?
>
> (AIUI java-xmlpull2 is in maintenance mode, so it may be worth adding
> that information to the package description.)
>
> > + (license license:public-domain)))
>
> Where did you find the public domain declaration? I only see this
> BSD-4 variant, which means this should be (license:non-copyleft
> "file://LICENSE.txt").
Indeed, you're right. I can't remember where I saw this, maybe I just
forgot to check the license... Thanks for your reviews! I'll try to be
more careful about licenses in the future.
>
> --
> Ricardo
>
> GPG: BCA6 89B6 3655 3801 C3C6 2150 197A 5888 235F ACAC
> https://elephly.net
>
>
next prev parent reply other threads:[~2017-12-16 20:18 UTC|newest]
Thread overview: 65+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <handler.29359.B.151111429223890.ack@debbugs.gnu.org>
2017-11-19 17:57 ` [bug#29359] [PATCH 01/31] gnu: Add java-gson Julien Lepiller
2017-11-19 17:57 ` [bug#29359] [PATCH 02/31] gnu: Add java-jsoup Julien Lepiller
2017-12-17 22:42 ` Ricardo Wurmus
2017-11-19 17:57 ` [bug#29359] [PATCH 03/31] gnu: Add java-geronimo-xbean-bundleutils Julien Lepiller
2017-12-17 22:44 ` Ricardo Wurmus
2017-11-19 17:57 ` [bug#29359] [PATCH 04/31] gnu: Add java-geronimo-xbean-asm-util Julien Lepiller
2017-12-17 22:46 ` Ricardo Wurmus
2017-11-19 17:57 ` [bug#29359] [PATCH 05/31] gnu: Add java-geronimo-xbean-finder Julien Lepiller
2017-12-17 22:47 ` Ricardo Wurmus
2017-11-19 17:57 ` [bug#29359] [PATCH 06/31] gnu: Add java-hawtjni Julien Lepiller
2017-12-17 22:51 ` Ricardo Wurmus
2017-11-19 17:57 ` [bug#29359] [PATCH 07/31] gnu: Add java-jansi-native Julien Lepiller
2017-12-17 22:57 ` Ricardo Wurmus
2017-11-19 17:57 ` [bug#29359] [PATCH 08/31] gnu: Add java-jansi Julien Lepiller
2017-11-22 9:33 ` julien lepiller
2017-11-24 14:41 ` Leo Famulari
2017-11-19 17:57 ` [bug#29359] [PATCH 09/31] gnu: Add java-jboss-el-api-spec Julien Lepiller
2017-12-17 23:00 ` Ricardo Wurmus
2017-11-19 17:57 ` [bug#29359] [PATCH 10/31] gnu: Add java-jboss-interceptors-api-spec Julien Lepiller
2018-02-02 22:45 ` Björn Höfling
2017-11-19 17:57 ` [bug#29359] [PATCH 11/31] gnu: Add java-cdi-api Julien Lepiller
2018-02-03 21:33 ` Björn Höfling
2017-11-19 17:57 ` [bug#29359] [PATCH 12/31] gnu: Add java-joda-convert Julien Lepiller
2018-02-04 5:39 ` Björn Höfling
2017-11-19 17:57 ` [bug#29359] [PATCH 13/31] gnu: Add java-joda-time Julien Lepiller
2018-02-04 6:28 ` Björn Höfling
2018-02-05 13:32 ` Ricardo Wurmus
2018-02-05 13:34 ` Ricardo Wurmus
2017-11-19 17:57 ` [bug#29359] [PATCH 14/31] gnu: Add java-jaxp Julien Lepiller
2018-02-03 22:52 ` Björn Höfling
2018-02-03 23:01 ` Björn Höfling
2017-11-19 17:57 ` [bug#29359] [PATCH 15/31] gnu: Add java-apache-xml-commons-resolver Julien Lepiller
2018-02-04 18:52 ` Björn Höfling
2017-11-19 17:57 ` [bug#29359] [PATCH 16/31] gnu: Add java-xerces Julien Lepiller
2017-11-19 17:57 ` [bug#29359] [PATCH 17/31] gnu: Add java-xom Julien Lepiller
2017-11-19 17:57 ` [bug#29359] [PATCH 18/31] gnu: Fix java-eclipse-jetty-security-9.2 build failure Julien Lepiller
2017-11-19 17:57 ` [bug#29359] [PATCH 19/31] gnu: Add java-xsdlib Julien Lepiller
2017-11-19 17:57 ` [bug#29359] [PATCH 20/31] gnu: Add java-xpp3 Julien Lepiller
2017-12-16 16:34 ` Ricardo Wurmus
2017-12-16 20:17 ` Julien Lepiller [this message]
2017-11-19 17:57 ` [bug#29359] [PATCH 21/31] gnu: Add java-xmlpull2 Julien Lepiller
2017-12-16 16:30 ` Ricardo Wurmus
2017-11-19 17:57 ` [bug#29359] [PATCH 22/31] gnu: Add java-dom4j Julien Lepiller
2017-11-20 8:58 ` Ricardo Wurmus
2017-11-20 9:07 ` julien lepiller
2017-11-19 17:57 ` [bug#29359] [PATCH 23/31] gnu: Add java-jaxen Julien Lepiller
2017-11-20 8:50 ` Ricardo Wurmus
2017-11-19 17:57 ` [bug#29359] [PATCH 24/31] gnu: Add java-kxml2 Julien Lepiller
2017-11-20 8:09 ` Ricardo Wurmus
2017-11-19 17:57 ` [bug#29359] [PATCH 25/31] gnu: Add java-stax Julien Lepiller
2017-11-20 8:05 ` Ricardo Wurmus
2017-11-19 17:58 ` [bug#29359] [PATCH 26/31] gnu: Add java-jettison Julien Lepiller
2017-11-20 7:53 ` Ricardo Wurmus
2017-11-19 17:58 ` [bug#29359] [PATCH 27/31] gnu: Add java-jdom2 Julien Lepiller
2017-11-20 7:50 ` Ricardo Wurmus
2017-11-19 17:58 ` [bug#29359] [PATCH 28/31] gnu: Add java-xstream Julien Lepiller
2017-11-20 7:44 ` Ricardo Wurmus
2017-11-19 17:58 ` [bug#29359] [PATCH 29/31] gnu: Add java-jline Julien Lepiller
2017-11-20 7:39 ` Ricardo Wurmus
2017-11-20 7:46 ` Ricardo Wurmus
2017-11-19 17:58 ` [bug#29359] [PATCH 30/31] gnu: Add java-xmlunit Julien Lepiller
2017-11-20 7:35 ` Ricardo Wurmus
2017-11-19 17:58 ` [bug#29359] [PATCH 31/31] gnu: Add java-xmlunit-legacy Julien Lepiller
2017-11-20 7:35 ` Ricardo Wurmus
2017-11-20 7:33 ` [bug#29359] [PATCH 01/31] gnu: Add java-gson Ricardo Wurmus
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://guix.gnu.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20171216211711.4c324573@lepiller.eu \
--to=julien@lepiller.eu \
--cc=29359@debbugs.gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/guix.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).