From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:52805)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <Debian-debbugs@debbugs.gnu.org>) id 1eQIuN-0005tG-9H
	for guix-patches@gnu.org; Sat, 16 Dec 2017 15:18:08 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <Debian-debbugs@debbugs.gnu.org>) id 1eQIuI-0003GT-CI
	for guix-patches@gnu.org; Sat, 16 Dec 2017 15:18:07 -0500
Received: from debbugs.gnu.org ([208.118.235.43]:57252)
	by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16)
	(Exim 4.71) (envelope-from <Debian-debbugs@debbugs.gnu.org>)
	id 1eQIuI-0003GB-8c
	for guix-patches@gnu.org; Sat, 16 Dec 2017 15:18:02 -0500
Subject: [bug#29359] [PATCH 20/31] gnu: Add java-xpp3.
Resent-Message-ID: <handler.29359.B29359.15134554408264@debbugs.gnu.org>
Date: Sat, 16 Dec 2017 21:17:11 +0100
From: Julien Lepiller <julien@lepiller.eu>
Message-ID: <20171216211711.4c324573@lepiller.eu>
In-Reply-To: <87fu8aocm4.fsf@elephly.net>
References: <handler.29359.B.151111429223890.ack@debbugs.gnu.org>
	<20171119175805.902-1-julien@lepiller.eu>
	<20171119175805.902-20-julien@lepiller.eu>
	<87fu8aocm4.fsf@elephly.net>
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: quoted-printable
List-Id: <guix-patches.gnu.org>
List-Unsubscribe: <https://lists.gnu.org/mailman/options/guix-patches>,
	<mailto:guix-patches-request@gnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/archive/html/guix-patches/>
List-Post: <mailto:guix-patches@gnu.org>
List-Help: <mailto:guix-patches-request@gnu.org?subject=help>
List-Subscribe: <https://lists.gnu.org/mailman/listinfo/guix-patches>,
	<mailto:guix-patches-request@gnu.org?subject=subscribe>
Errors-To: guix-patches-bounces+kyle=kyleam.com@gnu.org
Sender: "Guix-patches" <guix-patches-bounces+kyle=kyleam.com@gnu.org>
To: 29359@debbugs.gnu.org

Le Sat, 16 Dec 2017 17:34:43 +0100,
Ricardo Wurmus <rekado@elephly.net> a =C3=A9crit :

> Julien Lepiller <julien@lepiller.eu> writes:
>=20
> > * gnu/packages/java.scm (java-xpp3): New variable. =20
>=20
> Please move it to xml.scm.
>=20
> [=E2=80=A6]
>=20
> > +       (modify-phases %standard-phases
> > +         (replace 'install
> > +           (lambda* (#:key outputs #:allow-other-keys)
> > +             (let ((out (string-append (assoc-ref outputs "out")
> > "/share/java")))
> > +               (mkdir-p out)
> > +               (copy-file (string-append "build/xpp3-" ,version
> > ".jar")
> > +                          (string-append out "/xpp3.jar")))
> > +             #t))))) =20
>=20
> Same as for java-xmlpull2: please use =E2=80=9Cinstall-jars=E2=80=9D, if =
possible.
>=20
> > +    (home-page "http://www.extreme.indiana.edu/xgws/xsoap/xpp/")
> > +    (synopsis "Streaming pull XML parser")
> > +    (description "Xml Pull Parser (in short XPP) is a streaming
> > pull XML +parser and should be used when there is a need to process
> > quickly and +efficiently all input elements (for example in SOAP
> > processors).") =20
>=20
> Please capitalize =E2=80=9CXml=E2=80=9D.  How does this differ from java-=
xmlpull2?
> Could you come up with a better description maybe?
>=20
> (AIUI java-xmlpull2 is in maintenance mode, so it may be worth adding
> that information to the package description.)
>=20
> > +    (license license:public-domain))) =20
>=20
> Where did you find the public domain declaration?  I only see this
> BSD-4 variant, which means this should be (license:non-copyleft
> "file://LICENSE.txt").

Indeed, you're right. I can't remember where I saw this, maybe I just
forgot to check the license... Thanks for your reviews! I'll try to be
more careful about licenses in the future.

>=20
> --
> Ricardo
>=20
> GPG: BCA6 89B6 3655 3801 C3C6  2150 197A 5888 235F ACAC
> https://elephly.net
>=20
>=20