[bug#28473] networkmanager hostname woes

[bug#28473] networkmanager hostname woes

[Thomas Danckaert]

[-- Attachment #1: Type: Text/Plain, Size: 1297 bytes --]



From: ludo@gnu.org (Ludovic Courtès)
Subject: Re: networkmanager hostname woes
Date: Fri, 15 Sep 2017 22:34:44 +0200

> Thomas Danckaert <post@thomasdanckaert.be> skribis:
>
>> From: ludo@gnu.org (Ludovic Courtès)
>> Subject: Re: networkmanager hostname woes
>> Date: Thu, 14 Sep 2017 10:17:08 +0200
>>
>>> I don’t understand the logic in there, but a quick fix would be 
>>> to have
>>> ‘network-manager-service-type’ create /etc/hostname.
>>>
>>> What do people think?
>>
>> I agree.  What is the best way to do that?
>>
>>  - make network-manager-service extend etc-service?  I think in 
>> this
>>    case we'd need to pass the host-name to
>>    network-manager-service-type somehow?  It feels strange to make 
>> the
>>    system config's host-name a configuration parameter of
>>    network-manager-service-type just for this reason.
>>
>>  - Create /etc/hosts in network-manager activation, using the 
>> result
>>    of ‘hostname’ at that point?
>>
>>  - ...?
>
> Hmm, good points.  Maybe just create /etc/hostname unconditionally 
> from
> ‘essential-services’?  It can’t hurt, right?

I don't think so, only for people committed to extreme minimalism.  
The attached patch fixes the issue on my system.  Will it do?

Thomas

[-- Attachment #2: 0001-system-Create-etc-hostname.patch --]
[-- Type: Text/X-Patch, Size: 975 bytes --]

From 76a461ff1540807d8beb98c298a8ea0165a6aaa4 Mon Sep 17 00:00:00 2001
From: Thomas Danckaert <thomas.danckaert@gmail.com>
Date: Sat, 16 Sep 2017 13:54:40 +0200
Subject: [PATCH] system: Create "/etc/hostname".

* gnu/system.scm (operating-system-etc-service): Add a plain-file with the
  operating-system-host-name.
---
 gnu/system.scm | 1 +
 1 file changed, 1 insertion(+)

diff --git a/gnu/system.scm b/gnu/system.scm
index bb7e8531e..2ad4b3054 100644
--- a/gnu/system.scm
+++ b/gnu/system.scm
@@ -642,6 +642,7 @@ fi\n")))
        ("bashrc" ,#~#$bashrc)
        ("hosts" ,#~#$(or (operating-system-hosts-file os)
                          (default-/etc/hosts (operating-system-host-name os))))
+       ("hostname" ,(plain-file "hostname" (operating-system-host-name os)))
        ("localtime" ,(file-append tzdata "/share/zoneinfo/"
                                   (operating-system-timezone os)))
        ("sudoers" ,(operating-system-sudoers-file os))))))
-- 
2.14.1

[bug#28473] networkmanager hostname woes

[Ludovic Courtès]

Hi Thomas!

Thomas Danckaert <post@thomasdanckaert.be> skribis:

> From: ludo@gnu.org (Ludovic Courtès)
> Subject: Re: networkmanager hostname woes
> Date: Fri, 15 Sep 2017 22:34:44 +0200

[...]

>> Hmm, good points.  Maybe just create /etc/hostname unconditionally
>> from
>> ‘essential-services’?  It can’t hurt, right?
>
> I don't think so, only for people committed to extreme minimalism.
> The attached patch fixes the issue on my system.  Will it do?
>
> Thomas
>
> From 76a461ff1540807d8beb98c298a8ea0165a6aaa4 Mon Sep 17 00:00:00 2001
> From: Thomas Danckaert <thomas.danckaert@gmail.com>
> Date: Sat, 16 Sep 2017 13:54:40 +0200
> Subject: [PATCH] system: Create "/etc/hostname".
>
> * gnu/system.scm (operating-system-etc-service): Add a plain-file with the
>   operating-system-host-name.
> ---
>  gnu/system.scm | 1 +
>  1 file changed, 1 insertion(+)
>
> diff --git a/gnu/system.scm b/gnu/system.scm
> index bb7e8531e..2ad4b3054 100644
> --- a/gnu/system.scm
> +++ b/gnu/system.scm
> @@ -642,6 +642,7 @@ fi\n")))
>         ("bashrc" ,#~#$bashrc)
>         ("hosts" ,#~#$(or (operating-system-hosts-file os)
>                           (default-/etc/hosts (operating-system-host-name os))))
> +       ("hostname" ,(plain-file "hostname" (operating-system-host-name os)))

LGTM.  Maybe just add a comment pointing to this discussion, so we know
why this file matters.

Thank you!

Ludo’.

bug#28473: (no subject)

[Thomas Danckaert]