[bug#28217] [PATCH] gnu: hdf4: Avoid unneeded store references to compilers.

[bug#28217] [PATCH] gnu: hdf4: Avoid unneeded store references to compilers.

[Thomas Danckaert]

[-- Attachment #1: Type: Text/Plain, Size: 110 bytes --]

Hi,

this patch removes unnecessary references to the C and Fortran 
compilers from the HDF4 package.

Thomas

[-- Attachment #2: 0001-gnu-hdf4-Avoid-unneeded-store-references-to-compiler.patch --]
[-- Type: Text/X-Patch, Size: 1556 bytes --]

From 6c6c0df09c48c6f2f9b8e77f5e0f88d61f812f3f Mon Sep 17 00:00:00 2001
From: Thomas Danckaert <post@thomasdanckaert.be>
Date: Thu, 24 Aug 2017 14:27:29 +0200
Subject: [PATCH] gnu: hdf4: Avoid unneeded store references to compilers.

* gnu/packages/maths.scm (hdf4) [arguments]: Add phase 'patch-settings to
  truncate hashes of compiler store items.
---
 gnu/packages/maths.scm | 13 ++++++++++++-
 1 file changed, 12 insertions(+), 1 deletion(-)

diff --git a/gnu/packages/maths.scm b/gnu/packages/maths.scm
index 07784defb..16c61dda9 100644
--- a/gnu/packages/maths.scm
+++ b/gnu/packages/maths.scm
@@ -605,7 +605,18 @@ computations.")
                (("@HDF_BUILD_SHARED_TRUE@AM_LDFLAGS = \
 -R\\$\\(abs_top_builddir\\)/mfhdf/libsrc/\\.libs \
 -R\\$\\(abs_top_builddir\\)/hdf/src/\\.libs \\$\\(XDR_ADD\\)") ""))
-             #t)))))
+             #t))
+         (add-after 'configure 'patch-settings
+           (lambda _
+             ;; libhdf4.settings contains the full path of the
+             ;; compilers used, and its contents are included in
+             ;; .so-files.  We truncate the hashes to avoid
+             ;; unnecessary store references to those compilers:
+             (substitute* "libhdf4.settings"
+               (("(/gnu/store/)([a-Z0-9]*)" all prefix hash)
+                (string-append prefix (string-take hash 10) "...")))
+             #t))
+         )))
     (home-page "https://www.hdfgroup.org/products/hdf4/")
     (synopsis
      "Library and multi-object file format for storing and managing data")
-- 
2.14.1

[bug#28217] [PATCH] gnu: hdf4: Avoid unneeded store references to compilers.

[Ludovic Courtès]

Thomas Danckaert <post@thomasdanckaert.be> skribis:

> From 6c6c0df09c48c6f2f9b8e77f5e0f88d61f812f3f Mon Sep 17 00:00:00 2001
> From: Thomas Danckaert <post@thomasdanckaert.be>
> Date: Thu, 24 Aug 2017 14:27:29 +0200
> Subject: [PATCH] gnu: hdf4: Avoid unneeded store references to compilers.
>
> * gnu/packages/maths.scm (hdf4) [arguments]: Add phase 'patch-settings to
>   truncate hashes of compiler store items.

LGTM, it’s a good idea.

I assume hdf4 doesn’t rely on these file names at all for its
functionality, right?

Thanks!

Ludo’.

bug#28217: [PATCH] gnu: hdf4: Avoid unneeded store references to compilers.

[Thomas Danckaert]

From: ludo@gnu.org (Ludovic Courtès)
Subject: Re: [bug#28217] [PATCH] gnu: hdf4: Avoid unneeded store 
references to compilers.
Date: Thu, 31 Aug 2017 15:00:34 +0200

> I assume hdf4 doesn’t rely on these file names at all for its
> functionality, right?

No, it's just some extra information.

I pushed this, as well as the hdf5 patches.  Thanks for having a look!

Thomas