unofficial mirror of guix-patches@gnu.org 
 help / color / mirror / code / Atom feed
From: Christopher Baines <mail@cbaines.net>
To: 28021-done@debbugs.gnu.org
Subject: bug#28021: [PATCH] gnu: Fix memcached service startup.
Date: Tue, 15 Aug 2017 22:26:10 +0100	[thread overview]
Message-ID: <20170815222610.1f24c7df@cbaines.net> (raw)
In-Reply-To: <20170808204839.23723-1-mail@cbaines.net>

[-- Attachment #1: Type: text/plain, Size: 1078 bytes --]

On Tue,  8 Aug 2017 21:48:39 +0100
Christopher Baines <mail@cbaines.net> wrote:

> Memcached changes to the memcached user from root before writing the
> PID file. This means that it must be able to write the PID file as
> the memcached user.
> 
> To make this work, create the /var/run/memcached directory when the
> service starts, make it owned by memcached, and change memcached to
> write the PID file to /var/run/memcached/pid.
> 
> This wasn't picked up by the system test as the "service running"
> part was too permissive, and only failed on an error. Instead, test
> the response from calling start-service and check that the PID is a
> number.
> 
> * gnu/services/databases.scm (memcached-activation): New variable.
>   (memcached-shepherd-service): Change PID file location.
>   (memcached-service-type): Extend the activation-service-type.
> * gnu/tests/databases.scm (run-memcached-test)[test]: Change the
> "service running" test to check the response from the shepherd.

This was reviewed by lfam and rekado on IRC, and I've now pushed :)

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 963 bytes --]

      reply	other threads:[~2017-08-15 21:27 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-08-08 20:48 [bug#28021] [PATCH] gnu: Fix memcached service startup Christopher Baines
2017-08-15 21:26 ` Christopher Baines [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://guix.gnu.org/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20170815222610.1f24c7df@cbaines.net \
    --to=mail@cbaines.net \
    --cc=28021-done@debbugs.gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/guix.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).