From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:58211) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1dhjMg-0006cc-TR for guix-patches@gnu.org; Tue, 15 Aug 2017 17:27:07 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1dhjMc-0001R1-TL for guix-patches@gnu.org; Tue, 15 Aug 2017 17:27:06 -0400 Received: from debbugs.gnu.org ([208.118.235.43]:59346) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1dhjMc-0001Pr-K9 for guix-patches@gnu.org; Tue, 15 Aug 2017 17:27:02 -0400 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1dhjMc-0005d8-8b for guix-patches@gnu.org; Tue, 15 Aug 2017 17:27:02 -0400 Subject: bug#28021: [PATCH] gnu: Fix memcached service startup. Resent-To: guix-patches@gnu.org Resent-Message-ID: Date: Tue, 15 Aug 2017 22:26:10 +0100 From: Christopher Baines Message-ID: <20170815222610.1f24c7df@cbaines.net> In-Reply-To: <20170808204839.23723-1-mail@cbaines.net> References: <20170808204839.23723-1-mail@cbaines.net> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; boundary="Sig_/TrXNpXfgWLKtgGdi90S4Wu+"; protocol="application/pgp-signature" List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+kyle=kyleam.com@gnu.org Sender: "Guix-patches" To: 28021-done@debbugs.gnu.org --Sig_/TrXNpXfgWLKtgGdi90S4Wu+ Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: quoted-printable On Tue, 8 Aug 2017 21:48:39 +0100 Christopher Baines wrote: > Memcached changes to the memcached user from root before writing the > PID file. This means that it must be able to write the PID file as > the memcached user. >=20 > To make this work, create the /var/run/memcached directory when the > service starts, make it owned by memcached, and change memcached to > write the PID file to /var/run/memcached/pid. >=20 > This wasn't picked up by the system test as the "service running" > part was too permissive, and only failed on an error. Instead, test > the response from calling start-service and check that the PID is a > number. >=20 > * gnu/services/databases.scm (memcached-activation): New variable. > (memcached-shepherd-service): Change PID file location. > (memcached-service-type): Extend the activation-service-type. > * gnu/tests/databases.scm (run-memcached-test)[test]: Change the > "service running" test to check the response from the shepherd. This was reviewed by lfam and rekado on IRC, and I've now pushed :) --Sig_/TrXNpXfgWLKtgGdi90S4Wu+ Content-Type: application/pgp-signature Content-Description: OpenPGP digital signature -----BEGIN PGP SIGNATURE----- iQKTBAEBCgB9FiEEPonu50WOcg2XVOCyXiijOwuE9XcFAlmTZvJfFIAAAAAALgAo aXNzdWVyLWZwckBub3RhdGlvbnMub3BlbnBncC5maWZ0aGhvcnNlbWFuLm5ldDNF ODlFRUU3NDU4RTcyMEQ5NzU0RTBCMjVFMjhBMzNCMEI4NEY1NzcACgkQXiijOwuE 9XcZXRAApfrh5lLTUJdWRXNitbgIWC3kWJ1+qG82XEYC/e9PCVVj3oMBqtwUt5Ck ZGZgH712jjsBHkMkZNfRAWV9874t1bOs2HqpThvTaSEhqsGLp6/qEqGSH2lA2Qbi rmZnx55zK0Pn9MfWN5mUHsw3DYujXXcZ/lFqokvsx9tCLOi4VeEOmDxePexkkcI5 Ivd3TXpw24g6tSS7e/Z1pbZDdiWN8phiQHbSykCPeohh6whuSXbn9LVU1wHeWA2f D4ldG18B4GFv21UMwQcE7y85AGAuS/CV8Hq3KilnitINyP4Br8FDORmJstRFkn+a F0vDyt01KmXXGNniclhC8MOBLI9jdnhnJsf7RHezNtyuTTDlX1U8Bve0pepJaH5P CMUMJoYFZnw18YFiEoa3XbEZLACt6ehWV8K/g7E7uSEyKCWOs3BsprhLwNmxYmmj 3Rnh8DuVlwV4Iq/ciP7x5eRC9tT7HypoyJpW0WgcrtdIoaIqcm6g2rOFL8ZUyRfS Bz4KWfLsUIhTuluPzJbuPrQFt7G09w2lz+mwaG2oPyWwNot4k4SHstQegjQAlCry T8MtftyLzykZwfPR+kCmBE8iyvVZColuYlqYlScnI0BHIl76vhb3IAwsiB2B97aF hHajCmpJoPHyFtd9qKrbyQbLC0vJX03lNKQ58/qzB2Pj2U30t5M= =h6zY -----END PGP SIGNATURE----- --Sig_/TrXNpXfgWLKtgGdi90S4Wu+--