unofficial mirror of guix-patches@gnu.org 
 help / color / mirror / code / Atom feed
* [bug#27568] Bigloo update
@ 2017-07-03 19:36 Kei Kebreau
  2017-07-03 19:45 ` [bug#27568] [PATCH 1/2] gnu: bigloo: Update to 4.3a Kei Kebreau
  2017-07-03 20:08 ` [bug#27568] Bigloo update Tobias Geerinckx-Rice
  0 siblings, 2 replies; 10+ messages in thread
From: Kei Kebreau @ 2017-07-03 19:36 UTC (permalink / raw)
  To: 27568

[-- Attachment #1: Type: text/plain, Size: 196 bytes --]

These two packages should be updated at the same time, as the old hop
won't build with the new bigloo.

I'd feel better if a bigloo and hop user verified that everything still
works as it should.

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 832 bytes --]

^ permalink raw reply	[flat|nested] 10+ messages in thread

* [bug#27568] [PATCH 1/2] gnu: bigloo: Update to 4.3a.
  2017-07-03 19:36 [bug#27568] Bigloo update Kei Kebreau
@ 2017-07-03 19:45 ` Kei Kebreau
  2017-07-03 19:45   ` [bug#27568] [PATCH 2/2] gnu: hop: Update to 3.0.0-rc10 Kei Kebreau
  2017-07-10 10:11   ` [bug#27568] [PATCH 1/2] gnu: bigloo: Update to 4.3a Ludovic Courtès
  2017-07-03 20:08 ` [bug#27568] Bigloo update Tobias Geerinckx-Rice
  1 sibling, 2 replies; 10+ messages in thread
From: Kei Kebreau @ 2017-07-03 19:45 UTC (permalink / raw)
  To: 27568; +Cc: Kei Kebreau

* gnu/packages/scheme.scm (bigloo): Update to 4.3a.
[source]: Remove old patch. Add snippet.
[arguments]: Adjust the build phases accordingly.
[inputs]: Add libgc, libunistring, libuv, openssl, pcre and sqlite.
[native-inputs]: Add autoconf, automake and libtool.
---
 gnu/local.mk                                  |  1 -
 gnu/packages/patches/bigloo-gc-shebangs.patch | 18 -------
 gnu/packages/scheme.scm                       | 73 +++++++++++++++------------
 3 files changed, 40 insertions(+), 52 deletions(-)
 delete mode 100644 gnu/packages/patches/bigloo-gc-shebangs.patch

diff --git a/gnu/local.mk b/gnu/local.mk
index 22df8dfdd..0aca052ea 100644
--- a/gnu/local.mk
+++ b/gnu/local.mk
@@ -517,7 +517,6 @@ dist_patch_DATA =						\
   %D%/packages/patches/awesome-reproducible-png.patch		\
   %D%/packages/patches/azr3.patch				\
   %D%/packages/patches/bash-completion-directories.patch	\
-  %D%/packages/patches/bigloo-gc-shebangs.patch			\
   %D%/packages/patches/binutils-ld-new-dtags.patch		\
   %D%/packages/patches/binutils-loongson-workaround.patch	\
   %D%/packages/patches/binutils-mips-bash-bug.patch		\
diff --git a/gnu/packages/patches/bigloo-gc-shebangs.patch b/gnu/packages/patches/bigloo-gc-shebangs.patch
deleted file mode 100644
index 367708610..000000000
--- a/gnu/packages/patches/bigloo-gc-shebangs.patch
+++ /dev/null
@@ -1,18 +0,0 @@
-Patch shebangs in source that gets unpacked by `configure'.
-
---- bigloo4.1a/gc/install-gc-7.4.0	2014-02-04 14:55:03.000000000 +0100
-+++ bigloo4.1a/gc/install-gc-7.4.0	2014-02-04 14:55:36.000000000 +0100
-@@ -29,10 +29,12 @@ fi
- 
- # untar the two versions of the GC
- $tar xfz $src -C ../gc || (echo "$tar xfz $src failed"; exit 1)
--/bin/rm -rf "../gc/$gc"_fth
-+rm -rf "../gc/$gc"_fth
-+find ../gc/$gc -perm /111 -type f | xargs sed -i -e"s|/bin/sh|`type -P sh`|g"
- mv ../gc/$gc "../gc/$gc"_fth || (echo "mv $gc failed"; exit 1)
- 
- $tar xfz $src  -C ../gc || (echo "$tar xfz $src failed"; exit 1)
-+find ../gc/$gc -perm /111 -type f | xargs sed -i -e"s|/bin/sh|`type -P sh`|g"
- 
- # general Bigloo patch
- (cd "../gc/$gc"_fth && $patch -p1 < ../$gc.patch > /dev/null)
diff --git a/gnu/packages/scheme.scm b/gnu/packages/scheme.scm
index dae00732a..39240ea84 100644
--- a/gnu/packages/scheme.scm
+++ b/gnu/packages/scheme.scm
@@ -35,10 +35,15 @@
   #:use-module (guix utils)
   #:use-module (guix build-system gnu)
   #:use-module (guix build-system trivial)
+  #:use-module (gnu packages autotools)
+  #:use-module (gnu packages bdw-gc)
   #:use-module (gnu packages compression)
+  #:use-module (gnu packages libevent)
+  #:use-module (gnu packages libunistring)
   #:use-module (gnu packages m4)
   #:use-module (gnu packages multiprecision)
   #:use-module (gnu packages ncurses)
+  #:use-module (gnu packages pcre)
   #:use-module (gnu packages databases)
   #:use-module (gnu packages emacs)
   #:use-module (gnu packages ghostscript)
@@ -195,47 +200,35 @@ features an integrated Emacs-like editor and a large runtime library.")
 (define-public bigloo
   (package
     (name "bigloo")
-    (version "4.1a")
+    (version "4.3a")
     (source (origin
              (method url-fetch)
              (uri (string-append "ftp://ftp-sop.inria.fr/indes/fp/Bigloo/bigloo"
                                  version ".tar.gz"))
              (sha256
               (base32
-               "170q7nh08n4v20xl81fxb0xcdxphqqacfa643hsa8i2ar6pki04c"))
-             (patches (search-patches "bigloo-gc-shebangs.patch"))))
+               "03rcqs6kvy2j5lqk4fidqay5qfyp474qqspbh6wk4qdbds6w599w"))
+             ;; Remove bundled libraries.
+             (modules '((guix build utils)))
+             (snippet
+              '(for-each delete-file-recursively
+                         '("gc" "gmp" "libuv")))))
     (build-system gnu-build-system)
     (arguments
      `(#:test-target "test"
        #:phases
        (modify-phases %standard-phases
          (replace 'configure
-           (lambda* (#:key outputs #:allow-other-keys)
+           (lambda* (#:key inputs outputs #:allow-other-keys)
 
              (substitute* "configure"
                (("^shell=.*$")
-                (string-append "shell=" (which "bash") "\n")))
-
-             ;; Since libgc's pthread redirects are used, we end up
-             ;; using libgc symbols, so we must link against it.
-             ;; Reported on 2013-06-25.
-             (substitute* "api/pthread/src/Makefile"
-               (("^EXTRALIBS[[:blank:]]*=(.*)$" _ value)
-                (string-append "EXTRALIBS = "
-                               (string-trim-right value)
-                               " -l$(GCLIB)_fth-$(RELEASE)"
-                               " -Wl,-rpath=" (assoc-ref outputs "out")
-                               "/lib/bigloo/" ,version)))
-
-             ;; Those variables are used by libgc's `configure'.
-             (setenv "SHELL" (which "sh"))
-             (setenv "CONFIG_SHELL" (which "sh"))
-
-             ;; ... but they turned out to be overridden later, so work
-             ;; around that.
-             (substitute* (find-files "gc" "^configure-gc")
-               (("sh=/bin/sh")
-                (string-append "sh=" (which "sh"))))
+                (string-append "shell=" (which "bash") "\n"))
+               (("`date`") "0"))
+             (substitute* "autoconf/runtest.in"
+               ((", @DATE@") ""))
+             (substitute* "autoconf/osversion"
+               (("^version.*$") "version=\"\"\n"))
 
              ;; The `configure' script doesn't understand options
              ;; of those of Autoconf.
@@ -243,30 +236,44 @@ features an integrated Emacs-like editor and a large runtime library.")
                (zero?
                 (system* "./configure"
                          (string-append "--prefix=" out)
-                         ;; FIXME: Currently fails, see
-                         ;; <http://article.gmane.org/gmane.lisp.scheme.bigloo/6126>.
-                         ;; "--customgc=no" ; use our libgc
+                         ; use system libraries
+                         "--customgc=no"
+                         "--customunistring=no"
+                         "--customlibuv=no"
                          (string-append"--mv=" (which "mv"))
                          (string-append "--rm=" (which "rm"))
                          "--cflags=-fPIC"
                          (string-append "--ldflags=-Wl,-rpath="
                                         (assoc-ref outputs "out")
-                                        "/lib/bigloo/" ,version))))))
+                                        "/lib/bigloo/" ,version)
+                         (string-append "--lispdir=" out
+                                        "/share/emacs/site-lisp")
+                         "--sharedbde=yes"
+                         "--sharedcompiler=yes")))))
          (add-after 'install 'install-emacs-modes
            (lambda* (#:key outputs #:allow-other-keys)
              (let* ((out (assoc-ref outputs "out"))
                     (dir (string-append out "/share/emacs/site-lisp")))
                (zero? (system* "make" "-C" "bmacs" "all" "install"
-                               (string-append "EMACSBRAND=emacs24")
+                               (string-append "EMACSBRAND=emacs25")
                                (string-append "EMACSDIR=" dir)))))))))
     (inputs
      `(("emacs" ,emacs)                      ;UDE needs the X version of Emacs
+       ("libgc" ,libgc)
+       ("libunistring" ,libunistring)
+       ("libuv" ,libuv)
+       ("openssl" ,openssl)
+       ("sqlite" ,sqlite)
 
        ;; Optional APIs for which Bigloo has bindings.
        ("avahi" ,avahi)
-       ("libphidget" ,libphidget)))
+       ("libphidget" ,libphidget)
+       ("pcre" ,pcre)))
     (native-inputs
-     `(("pkg-config" ,pkg-config)))
+     `(("autoconf" ,autoconf)
+       ("automake" ,automake)
+       ("libtool" ,libtool)
+       ("pkg-config" ,pkg-config)))
     (propagated-inputs
      `(("gmp" ,gmp)))                             ; bigloo.h refers to gmp.h
     (home-page "http://www-sop.inria.fr/indes/fp/Bigloo/")
-- 
2.13.2

^ permalink raw reply related	[flat|nested] 10+ messages in thread

* [bug#27568] [PATCH 2/2] gnu: hop: Update to 3.0.0-rc10.
  2017-07-03 19:45 ` [bug#27568] [PATCH 1/2] gnu: bigloo: Update to 4.3a Kei Kebreau
@ 2017-07-03 19:45   ` Kei Kebreau
  2017-07-10 10:11   ` [bug#27568] [PATCH 1/2] gnu: bigloo: Update to 4.3a Ludovic Courtès
  1 sibling, 0 replies; 10+ messages in thread
From: Kei Kebreau @ 2017-07-03 19:45 UTC (permalink / raw)
  To: 27568; +Cc: Kei Kebreau

* gnu/packages/scheme.scm (hop): Update to 3.0.0-rc10.
[source]: Remove unnecessary patch.
[arguments]: Enable tests; disable parallel building; specify BIGLOO in
make-flags.
[inputs]: Add libgc, libunistring, libuv, pcre and sqlite.
* gnu/local.mk (dist_patch_DATA): Remove unnecessary patch.
* gnu/packages/patches/hop-linker-flags.patch: Delete file.
---
 gnu/local.mk                                |  1 -
 gnu/packages/patches/hop-linker-flags.patch | 60 -----------------------------
 gnu/packages/scheme.scm                     | 23 +++++++----
 3 files changed, 15 insertions(+), 69 deletions(-)
 delete mode 100644 gnu/packages/patches/hop-linker-flags.patch

diff --git a/gnu/local.mk b/gnu/local.mk
index 0aca052ea..131f05ddb 100644
--- a/gnu/local.mk
+++ b/gnu/local.mk
@@ -685,7 +685,6 @@ dist_patch_DATA =						\
   %D%/packages/patches/hdf-eos5-fix-szip.patch			\
   %D%/packages/patches/hdf-eos5-fortrantests.patch		\
   %D%/packages/patches/higan-remove-march-native-flag.patch	\
-  %D%/packages/patches/hop-linker-flags.patch			\
   %D%/packages/patches/hubbub-sort-entities.patch		\
   %D%/packages/patches/hurd-fix-eth-multiplexer-dependency.patch        \
   %D%/packages/patches/hydra-disable-darcs-test.patch		\
diff --git a/gnu/packages/patches/hop-linker-flags.patch b/gnu/packages/patches/hop-linker-flags.patch
deleted file mode 100644
index f1f5dbfbd..000000000
--- a/gnu/packages/patches/hop-linker-flags.patch
+++ /dev/null
@@ -1,60 +0,0 @@
-Make hop's link rules honor flags set by the --blflags configure argument.
-
---- hop-2.4.0/src/Makefile	2015-05-05 19:41:04.800151036 -0500
-+++ hop-2.4.0/src/Makefile	2015-05-05 19:40:40.916150417 -0500
-@@ -69,10 +69,10 @@
- 	$(MAKE) link.$(LINK) DEST=$@
- 
- link.dynamic:
--	@ $(call link,$(BIGLOO),$(BCFLAGS),$(BCFLAGSDEV),$(OBJECTS),-o,$(DEST))
-+	@ $(call link,$(BIGLOO),$(BCFLAGS) $(BLFLAGS),$(BCFLAGSDEV),$(OBJECTS),-o,$(DEST))
- 
- link.static:
--	@ $(call link,$(BIGLOO),$(BCFLAGS),$(BCFLAGSDEV),-static-all-bigloo $(OBJECTS),-o,$(DEST))
-+	@ $(call link,$(BIGLOO),$(BCFLAGS) $(BLFLAGS),$(BCFLAGSDEV),-static-all-bigloo $(OBJECTS),-o,$(DEST))
- 
- link.library:
- 	echo "***ERROR: link.library not currently supported!"
---- hop-2.4.0/hopc/Makefile	2013-01-30 07:17:59.000000000 -0600
-+++ hop-2.4.0/hopc/Makefile	2015-05-05 19:45:21.876157699 -0500
-@@ -62,7 +62,7 @@
- 	mkdir -p $@
- 
- $(BUILDBINDIR)/$(EXEC): .afile .etags $(OBJECTS)
--	@ $(call link,$(BIGLOO),$(BCFLAGS),,$(OBJECTS),-o,$@)
-+	@ $(call link,$(BIGLOO),$(BCFLAGS) $(BLFLAGS),$(BCFLAGSDEV),$(OBJECTS),-o,$@)
- 
- $(BUILDBINDIR)/$(EXEC).jar: .afile .etags .jfile $(BGL_CLASSES) META-INF/MANIFEST.MF jvm-stdlibs jvm-share jvm-lib
- 	$(JAR) $@ META-INF/MANIFEST.MF -C o/class_s .
---- hop-2.4.0/hophz/Makefile	2013-01-30 07:17:59.000000000 -0600
-+++ hop-2.4.0/hophz/Makefile	2015-05-05 19:59:42.996180030 -0500
-@@ -16,9 +16,6 @@
- -include ../etc/Makefile.hopconfig
- -include ../etc/Makefile.version
- 
--BLFLAGS		= 
--BLINKFLAGS 	= -suffix hop
--
- #*---------------------------------------------------------------------*/
- #*    Target and Project                                               */
- #*---------------------------------------------------------------------*/
-@@ -72,7 +69,7 @@
- 	mkdir -p $@
- 
- $(BUILDBINDIR)/$(EXEC): .afile .etags $(OBJECTS)
--	@ $(call link,$(BIGLOO),$(BCFLAGS),$(BLINKFLAGS),$(OBJECTS),-o,$@)
-+	@ $(call link,$(BIGLOO),$(BCFLAGS) $(BLFLAGS),$(BCFLAGSDEV),$(OBJECTS),-o,$@)
- 
- $(BUILDBINDIR)/$(EXEC).jar: .afile .etags .jfile $(BGL_CLASSES) META-INF/MANIFEST.MF jvm-stdlibs jvm-share jvm-lib
- 	@ $(JAR) $@ META-INF/MANIFEST.MF -C o/class_s .
---- hop-2.4.0/hopsh/Makefile	2013-01-30 07:17:59.000000000 -0600
-+++ hop-2.4.0/hopsh/Makefile	2015-05-05 19:46:36.060159626 -0500
-@@ -60,7 +60,7 @@
- 	mkdir -p $@
- 
- $(BUILDBINDIR)/$(EXEC): .afile .etags $(OBJECTS)
--	@ $(call link,$(BIGLOO),$(BCFLAGS),$(BCFLAGSDEV),$(OBJECTS),-o,$@)
-+	@ $(call link,$(BIGLOO),$(BCFLAGS) $(BLFLAGS),$(BCFLAGSDEV),$(OBJECTS),-o,$@)
- 
- $(BUILDBINDIR)/$(EXEC).jar: .afile .etags .jfile $(BGL_CLASSES) META-INF/MANIFEST.MF jvm-stdlibs jvm-share jvm-lib
- 	@ $(JAR) $@ META-INF/MANIFEST.MF -C o/class_s .
diff --git a/gnu/packages/scheme.scm b/gnu/packages/scheme.scm
index 39240ea84..f9fcff795 100644
--- a/gnu/packages/scheme.scm
+++ b/gnu/packages/scheme.scm
@@ -292,21 +292,23 @@ Scheme and C programs and between Scheme and Java programs.")
 (define-public hop
   (package
     (name "hop")
-    (version "2.5.1")
+    (version "3.0.0-rc10")
     (source (origin
              (method url-fetch)
              (uri (string-append "ftp://ftp-sop.inria.fr/indes/fp/Hop/hop-"
                                  version ".tar.gz"))
              (sha256
               (base32
-               "1bvp7pc71bln5yvfj87s8750c6l53wjl6f8m12v62q9926adhwys"))
-             (patches (search-patches "hop-linker-flags.patch"))))
+               "1fn8bzb86g67rmfcnxxib0ahy48njbnnr3dq923b6ywwifsxdx80"))))
     (build-system gnu-build-system)
     (arguments
-     `(#:phases
+     `(#:test-target "test"
+       #:make-flags '("BIGLOO=bigloo")
+       #:parallel-build? #f
+       #:phases
        (modify-phases %standard-phases
          (replace 'configure
-           (lambda* (#:key outputs #:allow-other-keys)
+           (lambda* (#:key inputs outputs #:allow-other-keys)
              (let ((out (assoc-ref outputs "out")))
                (zero?
                 (system* "./configure"
@@ -314,11 +316,16 @@ Scheme and C programs and between Scheme and Java programs.")
                          (string-append "--blflags="
                                         ;; user flags completely override useful
                                         ;; default flags, so repeat them here.
-                                        "-copt \\$(CPICFLAGS) -L\\$(BUILDLIBDIR) "
-                                        "-ldopt -Wl,-rpath," out "/lib")))))))
-       #:tests? #f))                                ; no test suite
+                                        "-copt \\$(CPICFLAGS) "
+                                        "-L \\$(BUILDLIBDIR) "
+                                        "-ldopt -Wl,-rpath," out "/lib")))))))))
     (inputs `(("avahi" ,avahi)
               ("bigloo" ,bigloo)
+              ("libgc" ,libgc)
+              ("libunistring" ,libunistring)
+              ("libuv" ,libuv)
+              ("pcre" ,pcre)
+              ("sqlite" ,sqlite)
               ("which" ,which)))
     (home-page "http://hop.inria.fr/")
     (synopsis "Multi-tier programming language for the Web 2.0")
-- 
2.13.2

^ permalink raw reply related	[flat|nested] 10+ messages in thread

* [bug#27568] Bigloo update
  2017-07-03 19:36 [bug#27568] Bigloo update Kei Kebreau
  2017-07-03 19:45 ` [bug#27568] [PATCH 1/2] gnu: bigloo: Update to 4.3a Kei Kebreau
@ 2017-07-03 20:08 ` Tobias Geerinckx-Rice
  2017-07-03 23:02   ` Kei Kebreau
  1 sibling, 1 reply; 10+ messages in thread
From: Tobias Geerinckx-Rice @ 2017-07-03 20:08 UTC (permalink / raw)
  To: kei, 27568


[-- Attachment #1.1: Type: text/plain, Size: 674 bytes --]

Kei,

On 03/07/17 21:36, Kei Kebreau wrote:
> These two packages should be updated at the same time, as the old hop
> won't build with the new bigloo.
> 
> I'd feel better if a bigloo and hop user verified that everything still
> works as it should.

I'm afraid I can't help you with that, but I can always ask annoying
questions: why the update to a release candidate?

The web site[1] left me more confused than I entered. The ‘file you
should download if you want to build the Hop stable [sic] version from
the sources’ is the even less stable-looking hop-3.1.0-pre1.tar.gz...

Kind regards,

T G-R

[1]: http://hop.inria.fr/home/download.html


[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 504 bytes --]

^ permalink raw reply	[flat|nested] 10+ messages in thread

* [bug#27568] Bigloo update
  2017-07-03 20:08 ` [bug#27568] Bigloo update Tobias Geerinckx-Rice
@ 2017-07-03 23:02   ` Kei Kebreau
  2017-07-10 10:14     ` Ludovic Courtès
  0 siblings, 1 reply; 10+ messages in thread
From: Kei Kebreau @ 2017-07-03 23:02 UTC (permalink / raw)
  To: Tobias Geerinckx-Rice; +Cc: 27568

[-- Attachment #1: Type: text/plain, Size: 1116 bytes --]

Tobias Geerinckx-Rice <me@tobias.gr> writes:

> Kei,
>
> On 03/07/17 21:36, Kei Kebreau wrote:
>> These two packages should be updated at the same time, as the old hop
>> won't build with the new bigloo.
>> 
>> I'd feel better if a bigloo and hop user verified that everything still
>> works as it should.
>
> I'm afraid I can't help you with that, but I can always ask annoying
> questions: why the update to a release candidate?
>

Mainly because the existing (stable?) hop wasn't building correctly and
had mysteriously absent make targets.

> The web site[1] left me more confused than I entered. The ‘file you
> should download if you want to build the Hop stable [sic] version from
> the sources’ is the even less stable-looking hop-3.1.0-pre1.tar.gz...
>

The same thing happened to me! I noticed that hop version 3.1.x only
existed in the developer's git repository on GitHub[2], so I just got
the latest available source tarball from the FTP server.

> Kind regards,
>
> T G-R
>
> [1]: http://hop.inria.fr/home/download.html

[2]: https://github.com/manuel-serrano/hop

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 832 bytes --]

^ permalink raw reply	[flat|nested] 10+ messages in thread

* [bug#27568] [PATCH 1/2] gnu: bigloo: Update to 4.3a.
  2017-07-03 19:45 ` [bug#27568] [PATCH 1/2] gnu: bigloo: Update to 4.3a Kei Kebreau
  2017-07-03 19:45   ` [bug#27568] [PATCH 2/2] gnu: hop: Update to 3.0.0-rc10 Kei Kebreau
@ 2017-07-10 10:11   ` Ludovic Courtès
  2017-07-10 23:42     ` Kei Kebreau
  1 sibling, 1 reply; 10+ messages in thread
From: Ludovic Courtès @ 2017-07-10 10:11 UTC (permalink / raw)
  To: Kei Kebreau; +Cc: 27568

Kei Kebreau <kei@openmailbox.org> skribis:

> * gnu/packages/scheme.scm (bigloo): Update to 4.3a.
> [source]: Remove old patch. Add snippet.
> [arguments]: Adjust the build phases accordingly.
> [inputs]: Add libgc, libunistring, libuv, openssl, pcre and sqlite.
> [native-inputs]: Add autoconf, automake and libtool.

[...]

> +     `(("autoconf" ,autoconf)
> +       ("automake" ,automake)
> +       ("libtool" ,libtool)
> +       ("pkg-config" ,pkg-config)))

I’m confident Bigloo itself doesn’t use the Autotools.  Do you remember
why they were needed?  (libgc uses them but I think we arrange not to
use the bundled libgc.)

Apart from that, if it builds, go for it!

Thanks,
Ludo’.

^ permalink raw reply	[flat|nested] 10+ messages in thread

* [bug#27568] Bigloo update
  2017-07-03 23:02   ` Kei Kebreau
@ 2017-07-10 10:14     ` Ludovic Courtès
  2017-07-10 23:51       ` bug#27568: " Kei Kebreau
  0 siblings, 1 reply; 10+ messages in thread
From: Ludovic Courtès @ 2017-07-10 10:14 UTC (permalink / raw)
  To: Kei Kebreau; +Cc: 27568

Hello gentlefolks,

Kei Kebreau <kei@openmailbox.org> skribis:

> Tobias Geerinckx-Rice <me@tobias.gr> writes:
>
>> Kei,
>>
>> On 03/07/17 21:36, Kei Kebreau wrote:
>>> These two packages should be updated at the same time, as the old hop
>>> won't build with the new bigloo.
>>> 
>>> I'd feel better if a bigloo and hop user verified that everything still
>>> works as it should.
>>
>> I'm afraid I can't help you with that, but I can always ask annoying
>> questions: why the update to a release candidate?
>>
>
> Mainly because the existing (stable?) hop wasn't building correctly and
> had mysteriously absent make targets.
>
>> The web site[1] left me more confused than I entered. The ‘file you
>> should download if you want to build the Hop stable [sic] version from
>> the sources’ is the even less stable-looking hop-3.1.0-pre1.tar.gz...
>>
>
> The same thing happened to me! I noticed that hop version 3.1.x only
> existed in the developer's git repository on GitHub[2], so I just got
> the latest available source tarball from the FTP server.

Hop 3.x has been in the works for a couple of years but I think they
never put out a proper release.

So I think it’s OK to upgrade to this “RC”.  (Even though I preferred
2.5 since 3.x is actually a JavaScript implementation…)

As for testing, I’d say that if the tests pass, that’s OK.

Thank you!

Ludo’.

^ permalink raw reply	[flat|nested] 10+ messages in thread

* [bug#27568] [PATCH 1/2] gnu: bigloo: Update to 4.3a.
  2017-07-10 10:11   ` [bug#27568] [PATCH 1/2] gnu: bigloo: Update to 4.3a Ludovic Courtès
@ 2017-07-10 23:42     ` Kei Kebreau
  0 siblings, 0 replies; 10+ messages in thread
From: Kei Kebreau @ 2017-07-10 23:42 UTC (permalink / raw)
  To: Ludovic Courtès; +Cc: 27568

ludo@gnu.org (Ludovic Courtès) writes:

> Kei Kebreau <kei@openmailbox.org> skribis:
>
>> * gnu/packages/scheme.scm (bigloo): Update to 4.3a.
>> [source]: Remove old patch. Add snippet.
>> [arguments]: Adjust the build phases accordingly.
>> [inputs]: Add libgc, libunistring, libuv, openssl, pcre and sqlite.
>> [native-inputs]: Add autoconf, automake and libtool.
>
> [...]
>
>> +     `(("autoconf" ,autoconf)
>> +       ("automake" ,automake)
>> +       ("libtool" ,libtool)
>> +       ("pkg-config" ,pkg-config)))
>
> I’m confident Bigloo itself doesn’t use the Autotools.  Do you remember
> why they were needed?  (libgc uses them but I think we arrange not to
> use the bundled libgc.)
>
They were for one of the in-tree third-party packages. I've removed the
autotools packages from the inputs.

> Apart from that, if it builds, go for it!
>
> Thanks,
> Ludo’.

^ permalink raw reply	[flat|nested] 10+ messages in thread

* bug#27568: Bigloo update
  2017-07-10 10:14     ` Ludovic Courtès
@ 2017-07-10 23:51       ` Kei Kebreau
  2017-07-11  8:27         ` [bug#27568] " Ludovic Courtès
  0 siblings, 1 reply; 10+ messages in thread
From: Kei Kebreau @ 2017-07-10 23:51 UTC (permalink / raw)
  To: Ludovic Courtès; +Cc: 27568-done

[-- Attachment #1: Type: text/plain, Size: 1826 bytes --]

ludo@gnu.org (Ludovic Courtès) writes:

> Hello gentlefolks,
>
> Kei Kebreau <kei@openmailbox.org> skribis:
>
>> Tobias Geerinckx-Rice <me@tobias.gr> writes:
>>
>>> Kei,
>>>
>>> On 03/07/17 21:36, Kei Kebreau wrote:
>>>> These two packages should be updated at the same time, as the old hop
>>>> won't build with the new bigloo.
>>>> 
>>>> I'd feel better if a bigloo and hop user verified that everything still
>>>> works as it should.
>>>
>>> I'm afraid I can't help you with that, but I can always ask annoying
>>> questions: why the update to a release candidate?
>>>
>>
>> Mainly because the existing (stable?) hop wasn't building correctly and
>> had mysteriously absent make targets.
>>
>>> The web site[1] left me more confused than I entered. The ‘file you
>>> should download if you want to build the Hop stable [sic] version from
>>> the sources’ is the even less stable-looking hop-3.1.0-pre1.tar.gz...
>>>
>>
>> The same thing happened to me! I noticed that hop version 3.1.x only
>> existed in the developer's git repository on GitHub[2], so I just got
>> the latest available source tarball from the FTP server.
>
> Hop 3.x has been in the works for a couple of years but I think they
> never put out a proper release.
>
> So I think it’s OK to upgrade to this “RC”.  (Even though I preferred
> 2.5 since 3.x is actually a JavaScript implementation…)
>
> As for testing, I’d say that if the tests pass, that’s OK.
>
> Thank you!
>
> Ludo’.

Thanks to both of you for the review. Changes pushed as
5e3ea571c5ac10858b2a1d6d3dc94a26408ae601 and
082725b5027a3782f242b634f94b9049d4c7f309!

P.S. The most recent Hop version is 3.1.0-pre2 as of today and the older
RC was removed from the FTP server. I updated the package definition
accordingly.

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 832 bytes --]

^ permalink raw reply	[flat|nested] 10+ messages in thread

* [bug#27568] Bigloo update
  2017-07-10 23:51       ` bug#27568: " Kei Kebreau
@ 2017-07-11  8:27         ` Ludovic Courtès
  0 siblings, 0 replies; 10+ messages in thread
From: Ludovic Courtès @ 2017-07-11  8:27 UTC (permalink / raw)
  To: Kei Kebreau; +Cc: 27568-done

Kei Kebreau <kei@openmailbox.org> skribis:

> P.S. The most recent Hop version is 3.1.0-pre2 as of today and the older
> RC was removed from the FTP server. I updated the package definition
> accordingly.

In the past, release tarballs have sometimes been removed or modified in
place.

Ludo’.

^ permalink raw reply	[flat|nested] 10+ messages in thread

end of thread, other threads:[~2017-07-11  8:28 UTC | newest]

Thread overview: 10+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2017-07-03 19:36 [bug#27568] Bigloo update Kei Kebreau
2017-07-03 19:45 ` [bug#27568] [PATCH 1/2] gnu: bigloo: Update to 4.3a Kei Kebreau
2017-07-03 19:45   ` [bug#27568] [PATCH 2/2] gnu: hop: Update to 3.0.0-rc10 Kei Kebreau
2017-07-10 10:11   ` [bug#27568] [PATCH 1/2] gnu: bigloo: Update to 4.3a Ludovic Courtès
2017-07-10 23:42     ` Kei Kebreau
2017-07-03 20:08 ` [bug#27568] Bigloo update Tobias Geerinckx-Rice
2017-07-03 23:02   ` Kei Kebreau
2017-07-10 10:14     ` Ludovic Courtès
2017-07-10 23:51       ` bug#27568: " Kei Kebreau
2017-07-11  8:27         ` [bug#27568] " Ludovic Courtès

Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/guix.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).