unofficial mirror of guix-patches@gnu.org 
 help / color / mirror / code / Atom feed
* [bug#27377] [PATCH] gnu: Add f-seq.
@ 2017-06-15 15:26 Ricardo Wurmus
  2017-06-17  3:31 ` Ben Woodcroft
  0 siblings, 1 reply; 2+ messages in thread
From: Ricardo Wurmus @ 2017-06-15 15:26 UTC (permalink / raw)
  To: 27377; +Cc: Ricardo Wurmus

* gnu/packages/bioinformatics.scm (f-seq): New variable.
---
 gnu/packages/bioinformatics.scm | 50 +++++++++++++++++++++++++++++++++++++++++
 1 file changed, 50 insertions(+)

diff --git a/gnu/packages/bioinformatics.scm b/gnu/packages/bioinformatics.scm
index c1c0faf24..4c81f0741 100644
--- a/gnu/packages/bioinformatics.scm
+++ b/gnu/packages/bioinformatics.scm
@@ -9655,3 +9655,53 @@ browser.")
     (license (license:non-copyleft
               "http://genome.ucsc.edu/license/"
               "The contents of this package are free for all uses."))))
+
+(define-public f-seq
+  (let ((commit "6ccded34cff38cf432deed8503648b4a66953f9b")
+        (revision "1"))
+    (package
+      (name "f-seq")
+      (version (string-append "1.1-" revision "." commit))
+      (source (origin
+                (method git-fetch)
+                (uri (git-reference
+                      (url "https://github.com/aboyle/F-seq.git")
+                      (commit commit)))
+                (file-name (string-append name "-" version))
+                (sha256
+                 (base32
+                  "1nk33k0yajg2id4g59bc4szr58r2q6pdq42vgcw054m8ip9wv26h"))
+                (modules '((guix build utils)))
+                ;; Remove bundled Java library archives.
+                (snippet
+                 '(begin
+                    (for-each delete-file (find-files "lib" ".*"))
+                    #t))))
+      (build-system ant-build-system)
+      (arguments
+       `(#:tests? #f ; no tests included
+         #:phases
+         (modify-phases %standard-phases
+           (replace 'install
+             (lambda* (#:key outputs #:allow-other-keys)
+               (let* ((target (assoc-ref outputs "out"))
+                      (doc (string-append target "/share/doc/f-seq/")))
+                 (mkdir-p target)
+                 (mkdir-p doc)
+                 (substitute* "bin/linux/fseq"
+                   (("java") (which "java")))
+                 (install-file "README.txt" doc)
+                 (install-file "bin/linux/fseq" (string-append target "/bin"))
+                 (install-file "build~/fseq.jar" (string-append target "/lib"))
+                 (copy-recursively "lib" (string-append target "/lib"))
+                 #t))))))
+      (inputs
+       `(("perl" ,perl)
+         ("java-commons-cli" ,java-commons-cli)))
+      (home-page "http://fureylab.web.unc.edu/software/fseq/")
+      (synopsis "Feature density estimator for high-throughput sequence tags")
+      (description
+       "F-Seq is a software package that generates a continuous tag sequence
+density estimation allowing identification of biologically meaningful sites
+whose output can be displayed directly in the UCSC Genome Browser.")
+      (license license:gpl3+))))
-- 
2.13.0

^ permalink raw reply related	[flat|nested] 2+ messages in thread

* [bug#27377] [PATCH] gnu: Add f-seq.
  2017-06-15 15:26 [bug#27377] [PATCH] gnu: Add f-seq Ricardo Wurmus
@ 2017-06-17  3:31 ` Ben Woodcroft
  0 siblings, 0 replies; 2+ messages in thread
From: Ben Woodcroft @ 2017-06-17  3:31 UTC (permalink / raw)
  To: Ricardo Wurmus, 27377

Hi Ricardo,


On 16/06/17 01:26, Ricardo Wurmus wrote:
> * gnu/packages/bioinformatics.scm (f-seq): New variable.
> [..]
> +      (synopsis "Feature density estimator for high-throughput sequence tags")
> +      (description
> +       "F-Seq is a software package that generates a continuous tag sequence
> +density estimation allowing identification of biologically meaningful sites
> +whose output can be displayed directly in the UCSC Genome Browser.")
"features" is a little vague for me. How about something like this

"F-Seq is a software package that generates a continuous tag sequence
density estimation allowing identification of biologically meaningful sites such as transcription factor binding sites (ChIP-seq) or regions of open chromatin (DNase-seq). Output can be displayed directly in the UCSC Genome Browser."


I also had some problems running this software in a container:

[env]# fseq
/gnu/store/xjfxqh6rp4y4jwr4smwbvjqnikjbivai-profile/bin/fseq: line 30: 
sed: command not found
/gnu/store/xjfxqh6rp4y4jwr4smwbvjqnikjbivai-profile/bin/fseq: line 32: 
sed: command not found
/gnu/store/xjfxqh6rp4y4jwr4smwbvjqnikjbivai-profile/bin/fseq: line 30: 
sed: command not found
/gnu/store/xjfxqh6rp4y4jwr4smwbvjqnikjbivai-profile/bin/fseq: line 32: 
sed: command not found
/gnu/store/xjfxqh6rp4y4jwr4smwbvjqnikjbivai-profile/bin/fseq: line 62: 
dirname: command not found
Error: Could not find or load main class edu.duke.igsp.gkde.Main

(exitstatus 1)


Given that the exitstatus of the above is non-zero, what about adding a 
cheap and cheerful test phase which simply runs "fseq -h" or similar?

Otherwise LGTM.

ben

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2017-06-17  3:33 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2017-06-15 15:26 [bug#27377] [PATCH] gnu: Add f-seq Ricardo Wurmus
2017-06-17  3:31 ` Ben Woodcroft

Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/guix.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).