unofficial mirror of guix-patches@gnu.org 
 help / color / mirror / code / Atom feed
* bug#26546: [PATCH] gnu: Add ponymix
@ 2017-04-17 19:41 Stefan Reichör
  2017-04-17 20:39 ` Leo Famulari
  0 siblings, 1 reply; 2+ messages in thread
From: Stefan Reichör @ 2017-04-17 19:41 UTC (permalink / raw)
  To: 26546

[-- Attachment #1: 0001-gnu-Add-ponymix.patch --]
[-- Type: text/x-diff, Size: 2317 bytes --]

From c0e4e33ba755803324e4ce8fbddb80e540d753af Mon Sep 17 00:00:00 2001
From: Stefan Reichoer <stefan@xsteve.at>
Date: Mon, 17 Apr 2017 21:35:33 +0200
Subject: [PATCH] gnu: Add ponymix.

* gnu/packages/pulseaudio.scm (ponymix): New variable.
---
 gnu/packages/pulseaudio.scm | 35 +++++++++++++++++++++++++++++++++++
 1 file changed, 35 insertions(+)

diff --git a/gnu/packages/pulseaudio.scm b/gnu/packages/pulseaudio.scm
index 71fcc3f..c0602c3 100644
--- a/gnu/packages/pulseaudio.scm
+++ b/gnu/packages/pulseaudio.scm
@@ -4,6 +4,7 @@
 ;;; Copyright © 2016 Efraim Flashner <efraim@flashner.co.il>
 ;;; Copyright © 2016 Ricardo Wurmus <rekado@elephly.net>
 ;;; Copyright © 2017 Leo Famulari <leo@famulari.name>
+;;; Copyright © 2017 Stefan Reichör <stefan@xsteve.at>
 ;;;
 ;;; This file is part of GNU Guix.
 ;;;
@@ -247,3 +248,37 @@ sound server.")
 graphical user interface to connect to a PulseAudio server and
 easily control the volume of all clients, sinks, etc.")
     (license l:gpl2+)))
+
+(define-public ponymix
+  (package
+    (name "ponymix")
+    (version "5")
+    (source (origin
+             (method url-fetch)
+             (uri (string-append "https://github.com/falconindy/ponymix/"
+                                 "archive/" version ".tar.gz"))
+             (sha256
+              (base32
+               "1c0ch98zry3c4ixywwynjid1n1nh4xl4l1p548giq2w3zwflaghn"))
+              (modules '((guix build utils)))
+              (snippet
+               '(substitute* "Makefile"
+                  (("/usr") "")))))
+    (build-system gnu-build-system)
+    (arguments
+     `(#:tests? #f ; There is no test suite.
+       #:make-flags (let ((out (assoc-ref %outputs "out")))
+                      (list (string-append "DESTDIR=" out)))
+       #:phases
+       (modify-phases %standard-phases
+         (delete 'configure)))) ; There's no configure phase.
+    (inputs
+     `(("pulseaudio" ,pulseaudio)))
+    (native-inputs
+     `(("pkg-config" ,pkg-config)))
+    (home-page "https://github.com/falconindy/ponymix")
+    (synopsis "CLI PulseAudio volume control")
+    (description
+     "PulseAudio Volume Control for the CLI. In addition it is possible
+to use named sources and sinks.")
+    (license l:expat)))
-- 
2.7.4

^ permalink raw reply related	[flat|nested] 2+ messages in thread

* bug#26546: [PATCH] gnu: Add ponymix
  2017-04-17 19:41 bug#26546: [PATCH] gnu: Add ponymix Stefan Reichör
@ 2017-04-17 20:39 ` Leo Famulari
  0 siblings, 0 replies; 2+ messages in thread
From: Leo Famulari @ 2017-04-17 20:39 UTC (permalink / raw)
  To: Stefan Reichör; +Cc: 26546-done

[-- Attachment #1: Type: text/plain, Size: 1371 bytes --]

On Mon, Apr 17, 2017 at 09:41:22PM +0200, Stefan Reichör wrote:
> From c0e4e33ba755803324e4ce8fbddb80e540d753af Mon Sep 17 00:00:00 2001
> From: Stefan Reichoer <stefan@xsteve.at>
> Date: Mon, 17 Apr 2017 21:35:33 +0200
> Subject: [PATCH] gnu: Add ponymix.
> 
> * gnu/packages/pulseaudio.scm (ponymix): New variable.

Thanks! Pushed as 05bdb5e64dea826552510cfeba8c63bcf487dcad with the
following changes:

> +             (uri (string-append "https://github.com/falconindy/ponymix/"
> +                                 "archive/" version ".tar.gz"))

To satisfy `guix lint`, I used (file-name) to make sure the source
tarball included the name of the package.

> +              (modules '((guix build utils)))
> +              (snippet
> +               '(substitute* "Makefile"
> +                  (("/usr") "")))))

Since origin snippets affect what you get from `guix build --source`, we
reserve them for fixing serious bugs and software freedom issues.
Guix-specific changes like this one are done in build phases, which
don't affect the source tarball. So, I moved this substitution into a
'patch-paths' phase.

> +    (synopsis "CLI PulseAudio volume control")
> +    (description
> +     "PulseAudio Volume Control for the CLI. In addition it is possible
> +to use named sources and sinks.")

I made some stylistic changes here.

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2017-04-17 20:40 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2017-04-17 19:41 bug#26546: [PATCH] gnu: Add ponymix Stefan Reichör
2017-04-17 20:39 ` Leo Famulari

Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/guix.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).