unofficial mirror of guix-patches@gnu.org 
 help / color / mirror / code / Atom feed
* bug#26469: [PATCH] glibc/linux: enable parallel build
@ 2017-04-12 21:29 Sergei Trofimovich
  2017-04-15  5:48 ` Kei Kebreau
  0 siblings, 1 reply; 4+ messages in thread
From: Sergei Trofimovich @ 2017-04-12 21:29 UTC (permalink / raw)
  To: 26469

Parallel build failure was fixed upstream as:
https://sourceware.org/git/?p=glibc.git;a=commitdiff;h=e8b6be0016f131c2ac72bf3213eabdb59800e63b

gnu/packages/base.scm (glibc/linux): reenable parallel builds

Signed-off-by: Sergei Trofimovich <slyfox@inbox.ru>
---
 gnu/packages/base.scm | 4 ----
 1 file changed, 4 deletions(-)

diff --git a/gnu/packages/base.scm b/gnu/packages/base.scm
index 5c36b612f..79733b14f 100644
--- a/gnu/packages/base.scm
+++ b/gnu/packages/base.scm
@@ -563,10 +563,6 @@ store.")
    (arguments
     `(#:out-of-source? #t
 
-      ;; In version 2.21, there a race in the 'elf' directory, see
-      ;; <http://lists.gnu.org/archive/html/guix-devel/2015-02/msg00709.html>.
-      #:parallel-build? #f
-
       ;; The libraries have an empty RUNPATH, but some, such as the versioned
       ;; libraries (libdl-2.24.so, etc.) have ld.so marked as NEEDED.  Since
       ;; these libraries are always going to be found anyway, just skip
-- 
2.12.2

^ permalink raw reply related	[flat|nested] 4+ messages in thread

* bug#26469: [PATCH] glibc/linux: enable parallel build
  2017-04-12 21:29 bug#26469: [PATCH] glibc/linux: enable parallel build Sergei Trofimovich
@ 2017-04-15  5:48 ` Kei Kebreau
  2017-04-16  9:30   ` Ludovic Courtès
  0 siblings, 1 reply; 4+ messages in thread
From: Kei Kebreau @ 2017-04-15  5:48 UTC (permalink / raw)
  To: Sergei Trofimovich; +Cc: 26469

[-- Attachment #1: Type: text/plain, Size: 1169 bytes --]

Sergei Trofimovich <slyfox@inbox.ru> writes:

> Parallel build failure was fixed upstream as:
> https://sourceware.org/git/?p=glibc.git;a=commitdiff;h=e8b6be0016f131c2ac72bf3213eabdb59800e63b
>
> gnu/packages/base.scm (glibc/linux): reenable parallel builds
>
> Signed-off-by: Sergei Trofimovich <slyfox@inbox.ru>
> ---
>  gnu/packages/base.scm | 4 ----
>  1 file changed, 4 deletions(-)
>
> diff --git a/gnu/packages/base.scm b/gnu/packages/base.scm
> index 5c36b612f..79733b14f 100644
> --- a/gnu/packages/base.scm
> +++ b/gnu/packages/base.scm
> @@ -563,10 +563,6 @@ store.")
>     (arguments
>      `(#:out-of-source? #t
>  
> -      ;; In version 2.21, there a race in the 'elf' directory, see
> -      ;; <http://lists.gnu.org/archive/html/guix-devel/2015-02/msg00709.html>.
> -      #:parallel-build? #f
> -
>        ;; The libraries have an empty RUNPATH, but some, such as the versioned
>        ;; libraries (libdl-2.24.so, etc.) have ld.so marked as NEEDED.  Since
>        ;; these libraries are always going to be found anyway, just skip

This works fine for me, but I'll wait for a second opinion in case I
missed something.

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 832 bytes --]

^ permalink raw reply	[flat|nested] 4+ messages in thread

* bug#26469: [PATCH] glibc/linux: enable parallel build
  2017-04-15  5:48 ` Kei Kebreau
@ 2017-04-16  9:30   ` Ludovic Courtès
  2017-04-16 13:22     ` Kei Kebreau
  0 siblings, 1 reply; 4+ messages in thread
From: Ludovic Courtès @ 2017-04-16  9:30 UTC (permalink / raw)
  To: Kei Kebreau; +Cc: 26469

Kei Kebreau <kei@openmailbox.org> skribis:

> Sergei Trofimovich <slyfox@inbox.ru> writes:
>
>> Parallel build failure was fixed upstream as:
>> https://sourceware.org/git/?p=glibc.git;a=commitdiff;h=e8b6be0016f131c2ac72bf3213eabdb59800e63b
>>
>> gnu/packages/base.scm (glibc/linux): reenable parallel builds
>>
>> Signed-off-by: Sergei Trofimovich <slyfox@inbox.ru>
>> ---
>>  gnu/packages/base.scm | 4 ----
>>  1 file changed, 4 deletions(-)
>>
>> diff --git a/gnu/packages/base.scm b/gnu/packages/base.scm
>> index 5c36b612f..79733b14f 100644
>> --- a/gnu/packages/base.scm
>> +++ b/gnu/packages/base.scm
>> @@ -563,10 +563,6 @@ store.")
>>     (arguments
>>      `(#:out-of-source? #t
>>  
>> -      ;; In version 2.21, there a race in the 'elf' directory, see
>> -      ;; <http://lists.gnu.org/archive/html/guix-devel/2015-02/msg00709.html>.
>> -      #:parallel-build? #f
>> -
>>        ;; The libraries have an empty RUNPATH, but some, such as the versioned
>>        ;; libraries (libdl-2.24.so, etc.) have ld.so marked as NEEDED.  Since
>>        ;; these libraries are always going to be found anyway, just skip
>
> This works fine for me, but I'll wait for a second opinion in case I
> missed something.

No objections for me, feel free to push to ‘core-updates’.

Thanks!

Ludo’.

^ permalink raw reply	[flat|nested] 4+ messages in thread

* bug#26469: [PATCH] glibc/linux: enable parallel build
  2017-04-16  9:30   ` Ludovic Courtès
@ 2017-04-16 13:22     ` Kei Kebreau
  0 siblings, 0 replies; 4+ messages in thread
From: Kei Kebreau @ 2017-04-16 13:22 UTC (permalink / raw)
  To: Ludovic Courtès; +Cc: 26469-done

[-- Attachment #1: Type: text/plain, Size: 1454 bytes --]

ludo@gnu.org (Ludovic Courtès) writes:

> Kei Kebreau <kei@openmailbox.org> skribis:
>
>> Sergei Trofimovich <slyfox@inbox.ru> writes:
>>
>>> Parallel build failure was fixed upstream as:
>>> https://sourceware.org/git/?p=glibc.git;a=commitdiff;h=e8b6be0016f131c2ac72bf3213eabdb59800e63b
>>>
>>> gnu/packages/base.scm (glibc/linux): reenable parallel builds
>>>
>>> Signed-off-by: Sergei Trofimovich <slyfox@inbox.ru>
>>> ---
>>>  gnu/packages/base.scm | 4 ----
>>>  1 file changed, 4 deletions(-)
>>>
>>> diff --git a/gnu/packages/base.scm b/gnu/packages/base.scm
>>> index 5c36b612f..79733b14f 100644
>>> --- a/gnu/packages/base.scm
>>> +++ b/gnu/packages/base.scm
>>> @@ -563,10 +563,6 @@ store.")
>>>     (arguments
>>>      `(#:out-of-source? #t
>>>  
>>> -      ;; In version 2.21, there a race in the 'elf' directory, see
>>> -      ;; <http://lists.gnu.org/archive/html/guix-devel/2015-02/msg00709.html>.
>>> -      #:parallel-build? #f
>>> -
>>>        ;; The libraries have an empty RUNPATH, but some, such as the versioned
>>>        ;; libraries (libdl-2.24.so, etc.) have ld.so marked as NEEDED.  Since
>>>        ;; these libraries are always going to be found anyway, just skip
>>
>> This works fine for me, but I'll wait for a second opinion in case I
>> missed something.
>
> No objections for me, feel free to push to ‘core-updates’.
>
> Thanks!
>
> Ludo’.

Done! Thanks to both of you.

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 832 bytes --]

^ permalink raw reply	[flat|nested] 4+ messages in thread

end of thread, other threads:[~2017-04-16 13:23 UTC | newest]

Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2017-04-12 21:29 bug#26469: [PATCH] glibc/linux: enable parallel build Sergei Trofimovich
2017-04-15  5:48 ` Kei Kebreau
2017-04-16  9:30   ` Ludovic Courtès
2017-04-16 13:22     ` Kei Kebreau

Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/guix.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).