bug#26405: [PATCH 0/2] Tweaks to the PHP package.

bug#26405: [PATCH 0/2] Tweaks to the PHP package.

[alex.sassmannshausen]

From: Alex Sassmannshausen <alex@pompo.co>

The following 2 patches add tweaks to the excellent PHP package.

The first removes --enable-threads.  Its presence causes a warning during the
configure stage of php, because the option is apparently not supported.  I
imagine it was removed with php 7.

The second adds --with-mysqli.  Adding like so makes it default to the mysql
native driver.  Adding this configure option allows running things such as
wordpress, which require mysqli.

Alex Sassmannshausen (2):
  gnu: php: Remove '--enable-threads' configure option.
  gnu: php: Add '--with-mysqli' configure option.

 gnu/packages/php.scm | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

-- 
2.12.2

bug#26403: [PATCH 1/2] gnu: php: Remove '--enable-threads' configure option.

[alex.sassmannshausen]

From: Alex Sassmannshausen <alex@pompo.co>

* gnu/packages/php.scm (php): Remove '--enable-threads' configure option, as
  it is no longer recognized in PHP 7.
---
 gnu/packages/php.scm | 3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)

diff --git a/gnu/packages/php.scm b/gnu/packages/php.scm
index 071820ecb..3537a8e97 100644
--- a/gnu/packages/php.scm
+++ b/gnu/packages/php.scm
@@ -130,8 +130,7 @@
                "--enable-inifile"
                "--enable-mbstring"
                "--enable-pcntl"
-               "--enable-sockets"
-               "--enable-threads"))
+               "--enable-sockets"))
        #:phases
        (modify-phases %standard-phases
          (add-after 'unpack 'do-not-record-build-flags
-- 
2.12.2

bug#26404: [PATCH 2/2] gnu: php: Add '--with-mysqli' configure option.

[alex.sassmannshausen]

From: Alex Sassmannshausen <alex@pompo.co>

* gnu/packages/php.scm: Add '--with-mysqli' configure option.
---
 gnu/packages/php.scm | 1 +
 1 file changed, 1 insertion(+)

diff --git a/gnu/packages/php.scm b/gnu/packages/php.scm
index 3537a8e97..4bc301161 100644
--- a/gnu/packages/php.scm
+++ b/gnu/packages/php.scm
@@ -119,6 +119,7 @@
                ;; extension of php.
                "--with-iconv"
                "--with-openssl"
+               "--with-mysqli"          ; Required for, e.g. wordpress
                "--with-pdo-mysql"
                "--with-zlib"
                "--enable-calendar"
-- 
2.12.2

bug#26404: [PATCH 2/2] gnu: php: Add '--with-mysqli' configure option.

[Leo Famulari]

On Sat, Apr 08, 2017 at 05:39:26PM +0200, alex.sassmannshausen@gmail.com wrote:
> From: Alex Sassmannshausen <alex@pompo.co>
> 
> * gnu/packages/php.scm: Add '--with-mysqli' configure option.

LGTM, thanks!

bug#26405: [PATCH 0/2] Tweaks to the PHP package.

[Leo Famulari]

On Sat, Apr 08, 2017 at 05:39:24PM +0200, alex.sassmannshausen@gmail.com wrote:
> From: Alex Sassmannshausen <alex@pompo.co>
> 
> The following 2 patches add tweaks to the excellent PHP package.
> 
> The first removes --enable-threads.  Its presence causes a warning during the
> configure stage of php, because the option is apparently not supported.  I
> imagine it was removed with php 7.

Julien, what do you think?

bug#26405: [PATCH 0/2] Tweaks to the PHP package.

[julien lepiller]

Thank you for these patches! I tried them, and I think we can push them.

bug#26405: [PATCH 0/2] Tweaks to the PHP package.

[Ludovic Courtès]

Hello!

julien lepiller <julien@lepiller.eu> skribis:

> Thank you for these patches! I tried them, and I think we can push them.

Alex, if that’s still OK with you, can you push the patches?

Thanks,
Ludo’.

bug#26405: Acknowledgement ([PATCH 0/2] Tweaks to the PHP package.)

[Alex Sassmannshausen]

Pushed to master.

GNU bug Tracking System writes:

> Thank you for filing a new bug report with debbugs.gnu.org.
>
> This is an automatically generated reply to let you know your message
> has been received.
>
> Your message is being forwarded to the package maintainers and other
> interested parties for their attention; they will reply in due course.
>
> Your message has been sent to the package maintainer(s):
>  guix-patches@gnu.org
>
> If you wish to submit further information on this problem, please
> send it to 26405@debbugs.gnu.org.
>
> Please do not send mail to help-debbugs@gnu.org unless you wish
> to report a problem with the Bug-tracking system.