* bug#26225: [PATCH] guix: Compress and decompress xz archives in parallel.
[not found] ` <5vvaqyii1c.fsf@fencepost.gnu.org>
@ 2017-03-30 22:22 ` Leo Famulari
2017-03-31 17:56 ` Kei Kebreau
2017-04-01 6:52 ` Marius Bakke
0 siblings, 2 replies; 5+ messages in thread
From: Leo Famulari @ 2017-03-30 22:22 UTC (permalink / raw)
To: 26225, efraim
[-- Attachment #1: Type: text/plain, Size: 917 bytes --]
Efraim Flashner wrote:
> * guix/scripts/pack.scm (%compressors): Add flag '-T0' when calling "xz".
> * guix/utils.scm (decompressed-port, compressed-port,
> compressed-output-port): Same.
> --- a/guix/utils.scm
> +++ b/guix/utils.scm
> @@ -154,7 +155,7 @@ a symbol such as 'xz."
> (match compression
> ((or #f 'none) (values input '()))
> ('bzip2 (filtered-port `(,%bzip2 "-dc") input))
> - ('xz (filtered-port `(,%xz "-dc") input))
> + ('xz (filtered-port `(,%xz "-dc -T0") input))
> ('gzip (filtered-port `(,%gzip "-dc") input))
> (else (error "unsupported compression scheme" compression))))
Parallel decompression isn't implemented yet, but the extra '-T0' option
doesn't seem to break anything.
The changes LGTM.
I sent a companion patch to <https://bugs.gnu.org/26316> that enables
threaded compression when building source tarballs.
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
^ permalink raw reply [flat|nested] 5+ messages in thread
* bug#26225: [PATCH] guix: Compress and decompress xz archives in parallel.
2017-03-30 22:22 ` bug#26225: [PATCH] guix: Compress and decompress xz archives in parallel Leo Famulari
@ 2017-03-31 17:56 ` Kei Kebreau
2017-03-31 23:01 ` Leo Famulari
2017-04-01 6:52 ` Marius Bakke
1 sibling, 1 reply; 5+ messages in thread
From: Kei Kebreau @ 2017-03-31 17:56 UTC (permalink / raw)
To: Leo Famulari; +Cc: efraim, 26225
[-- Attachment #1: Type: text/plain, Size: 1003 bytes --]
Leo Famulari <leo@famulari.name> writes:
> Efraim Flashner wrote:
>> * guix/scripts/pack.scm (%compressors): Add flag '-T0' when calling "xz".
>> * guix/utils.scm (decompressed-port, compressed-port,
>> compressed-output-port): Same.
>
>> --- a/guix/utils.scm
>> +++ b/guix/utils.scm
>> @@ -154,7 +155,7 @@ a symbol such as 'xz."
>> (match compression
>> ((or #f 'none) (values input '()))
>> ('bzip2 (filtered-port `(,%bzip2 "-dc") input))
>> - ('xz (filtered-port `(,%xz "-dc") input))
>> + ('xz (filtered-port `(,%xz "-dc -T0") input))
>> ('gzip (filtered-port `(,%gzip "-dc") input))
>> (else (error "unsupported compression scheme" compression))))
>
> Parallel decompression isn't implemented yet, but the extra '-T0' option
> doesn't seem to break anything.
>
> The changes LGTM.
>
> I sent a companion patch to <https://bugs.gnu.org/26316> that enables
> threaded compression when building source tarballs.
LGTM as well.
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 832 bytes --]
^ permalink raw reply [flat|nested] 5+ messages in thread
* bug#26225: [PATCH] guix: Compress and decompress xz archives in parallel.
2017-03-31 17:56 ` Kei Kebreau
@ 2017-03-31 23:01 ` Leo Famulari
0 siblings, 0 replies; 5+ messages in thread
From: Leo Famulari @ 2017-03-31 23:01 UTC (permalink / raw)
To: Kei Kebreau; +Cc: efraim, 26225
[-- Attachment #1: Type: text/plain, Size: 1191 bytes --]
On Fri, Mar 31, 2017 at 01:56:37PM -0400, Kei Kebreau wrote:
> Leo Famulari <leo@famulari.name> writes:
>
> > Efraim Flashner wrote:
> >> * guix/scripts/pack.scm (%compressors): Add flag '-T0' when calling "xz".
> >> * guix/utils.scm (decompressed-port, compressed-port,
> >> compressed-output-port): Same.
> >
> >> --- a/guix/utils.scm
> >> +++ b/guix/utils.scm
> >> @@ -154,7 +155,7 @@ a symbol such as 'xz."
> >> (match compression
> >> ((or #f 'none) (values input '()))
> >> ('bzip2 (filtered-port `(,%bzip2 "-dc") input))
> >> - ('xz (filtered-port `(,%xz "-dc") input))
> >> + ('xz (filtered-port `(,%xz "-dc -T0") input))
> >> ('gzip (filtered-port `(,%gzip "-dc") input))
> >> (else (error "unsupported compression scheme" compression))))
> >
> > Parallel decompression isn't implemented yet, but the extra '-T0' option
> > doesn't seem to break anything.
> >
> > The changes LGTM.
> >
> > I sent a companion patch to <https://bugs.gnu.org/26316> that enables
> > threaded compression when building source tarballs.
>
> LGTM as well.
AFAICT, this doesn't cause mass rebuilds.
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
^ permalink raw reply [flat|nested] 5+ messages in thread
* bug#26225: [PATCH] guix: Compress and decompress xz archives in parallel.
2017-03-30 22:22 ` bug#26225: [PATCH] guix: Compress and decompress xz archives in parallel Leo Famulari
2017-03-31 17:56 ` Kei Kebreau
@ 2017-04-01 6:52 ` Marius Bakke
2017-04-02 21:21 ` Leo Famulari
1 sibling, 1 reply; 5+ messages in thread
From: Marius Bakke @ 2017-04-01 6:52 UTC (permalink / raw)
To: Leo Famulari, 26225, efraim
[-- Attachment #1: Type: text/plain, Size: 1062 bytes --]
Leo Famulari <leo@famulari.name> writes:
> Efraim Flashner wrote:
>> * guix/scripts/pack.scm (%compressors): Add flag '-T0' when calling "xz".
>> * guix/utils.scm (decompressed-port, compressed-port,
>> compressed-output-port): Same.
>
>> --- a/guix/utils.scm
>> +++ b/guix/utils.scm
>> @@ -154,7 +155,7 @@ a symbol such as 'xz."
>> (match compression
>> ((or #f 'none) (values input '()))
>> ('bzip2 (filtered-port `(,%bzip2 "-dc") input))
>> - ('xz (filtered-port `(,%xz "-dc") input))
>> + ('xz (filtered-port `(,%xz "-dc -T0") input))
>> ('gzip (filtered-port `(,%gzip "-dc") input))
>> (else (error "unsupported compression scheme" compression))))
>
> Parallel decompression isn't implemented yet, but the extra '-T0' option
> doesn't seem to break anything.
>
> The changes LGTM.
>
> I sent a companion patch to <https://bugs.gnu.org/26316> that enables
> threaded compression when building source tarballs.
Is (parallel-job-count) accessible here? It would be nice to respect it.
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 487 bytes --]
^ permalink raw reply [flat|nested] 5+ messages in thread
* bug#26225: [PATCH] guix: Compress and decompress xz archives in parallel.
2017-04-01 6:52 ` Marius Bakke
@ 2017-04-02 21:21 ` Leo Famulari
0 siblings, 0 replies; 5+ messages in thread
From: Leo Famulari @ 2017-04-02 21:21 UTC (permalink / raw)
To: Marius Bakke; +Cc: efraim, 26225
[-- Attachment #1: Type: text/plain, Size: 940 bytes --]
On Sat, Apr 01, 2017 at 08:52:28AM +0200, Marius Bakke wrote:
> > Efraim Flashner wrote:
> >> * guix/scripts/pack.scm (%compressors): Add flag '-T0' when calling "xz".
> >> * guix/utils.scm (decompressed-port, compressed-port,
> >> compressed-output-port): Same.
> >
> >> --- a/guix/utils.scm
> >> +++ b/guix/utils.scm
> >> @@ -154,7 +155,7 @@ a symbol such as 'xz."
> >> (match compression
> >> ((or #f 'none) (values input '()))
> >> ('bzip2 (filtered-port `(,%bzip2 "-dc") input))
> >> - ('xz (filtered-port `(,%xz "-dc") input))
> >> + ('xz (filtered-port `(,%xz "-dc -T0") input))
> >> ('gzip (filtered-port `(,%gzip "-dc") input))
> >> (else (error "unsupported compression scheme" compression))))
>
> Is (parallel-job-count) accessible here? It would be nice to respect it.
I agree, it would be good if we respected it here, if possible.
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2017-04-02 21:22 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
[not found] <E1cr0d6-0004an-8g@eggs.gnu.org>
[not found] ` <5vvaqyii1c.fsf@fencepost.gnu.org>
2017-03-30 22:22 ` bug#26225: [PATCH] guix: Compress and decompress xz archives in parallel Leo Famulari
2017-03-31 17:56 ` Kei Kebreau
2017-03-31 23:01 ` Leo Famulari
2017-04-01 6:52 ` Marius Bakke
2017-04-02 21:21 ` Leo Famulari
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/guix.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).