From: Hartmut Goebel <h.goebel@crazy-compilers.com>
To: Efraim Flashner <efraim@flashner.co.il>
Cc: 38711-close@debbugs.gnu.org, ludo@gnu.org
Subject: bug#38711: [PATCH] build-system: qt: Actually use qt-build-system, not cmake-build-system.
Date: Mon, 23 Dec 2019 17:50:51 +0100 [thread overview]
Message-ID: <1eaa5897-b0e8-e7dc-1b4a-a4ef57784be6@crazy-compilers.com> (raw)
In-Reply-To: <20191223133033.GQ1115@E5400>
[-- Attachment #1.1: Type: text/plain, Size: 951 bytes --]
Hi Efraim,
thanks for the review.
Am 23.12.19 um 14:30 schrieb Efraim Flashner:
> This would explain some of the problems we've run into with, say,
> mumble. If applying this means we can reverse
> a7a91c01c98499c8a1e44fadea1b8f70e91fc16f and still have the binaries
> wrapped then I say go for it.
Yes, this patch allows to revert
a7a91c01c98499c8a1e44fadea1b8f70e91fc16f. See also
<https://debbugs.gnu.org/cgi/bugreport.cgi?bug=38553#47>.
I already reverted a7a91c01c and changed the other packages which used
the same pattern ((sddm, ktouch, kdeconnect, kdevelop))
> Don't forget to re-indent the following lines
ACK. I did this in a separate commit to make the actual change more obvious.
Pushed as fce8ec9e151..50bdf0043.
--
Regards
Hartmut Goebel
| Hartmut Goebel | h.goebel@crazy-compilers.com |
| www.crazy-compilers.com | compilers which you thought are impossible |
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
next prev parent reply other threads:[~2019-12-23 16:52 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-12-22 21:40 [bug#38711] [PATCH] build-system: qt: Actually use qt-build-system, not cmake-build-system Hartmut Goebel
2019-12-23 13:30 ` Efraim Flashner
2019-12-23 16:50 ` Hartmut Goebel [this message]
2019-12-23 16:54 ` Ludovic Courtès
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://guix.gnu.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1eaa5897-b0e8-e7dc-1b4a-a4ef57784be6@crazy-compilers.com \
--to=h.goebel@crazy-compilers.com \
--cc=38711-close@debbugs.gnu.org \
--cc=efraim@flashner.co.il \
--cc=ludo@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/guix.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).