From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:470:142:3::10]:43628) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1ijQw7-000831-Ri for guix-patches@gnu.org; Mon, 23 Dec 2019 11:52:04 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1ijQw6-00026k-NC for guix-patches@gnu.org; Mon, 23 Dec 2019 11:52:03 -0500 Received: from debbugs.gnu.org ([209.51.188.43]:45638) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1ijQw6-00026f-Jo for guix-patches@gnu.org; Mon, 23 Dec 2019 11:52:02 -0500 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1ijQw6-0004V2-GM for guix-patches@gnu.org; Mon, 23 Dec 2019 11:52:02 -0500 Subject: bug#38711: [PATCH] build-system: qt: Actually use qt-build-system, not cmake-build-system. Resent-To: guix-patches@gnu.org Resent-Message-ID: References: <20191222214003.7352-1-h.goebel@crazy-compilers.com> <20191223133033.GQ1115@E5400> From: Hartmut Goebel Message-ID: <1eaa5897-b0e8-e7dc-1b4a-a4ef57784be6@crazy-compilers.com> Date: Mon, 23 Dec 2019 17:50:51 +0100 MIME-Version: 1.0 In-Reply-To: <20191223133033.GQ1115@E5400> Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="F0WiuIZdujmvM6yJSuMULxH30iWB3XU2Y" List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+kyle=kyleam.com@gnu.org Sender: "Guix-patches" To: Efraim Flashner Cc: 38711-close@debbugs.gnu.org, ludo@gnu.org This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --F0WiuIZdujmvM6yJSuMULxH30iWB3XU2Y Content-Type: multipart/mixed; boundary="P3K2qNp5UvuIgexX6ZE10AR31P38N59hq"; protected-headers="v1" From: Hartmut Goebel To: Efraim Flashner Cc: 38711-close@debbugs.gnu.org, ludo@gnu.org Message-ID: <1eaa5897-b0e8-e7dc-1b4a-a4ef57784be6@crazy-compilers.com> Subject: Re: [bug#38711] [PATCH] build-system: qt: Actually use qt-build-system, not cmake-build-system. References: <20191222214003.7352-1-h.goebel@crazy-compilers.com> <20191223133033.GQ1115@E5400> In-Reply-To: <20191223133033.GQ1115@E5400> --P3K2qNp5UvuIgexX6ZE10AR31P38N59hq Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Content-Language: en-US Hi Efraim, thanks for the review. Am 23.12.19 um 14:30 schrieb Efraim Flashner: > This would explain some of the problems we've run into with, say, > mumble. If applying this means we can reverse > a7a91c01c98499c8a1e44fadea1b8f70e91fc16f and still have the binaries > wrapped then I say go for it. Yes, this patch allows to revert a7a91c01c98499c8a1e44fadea1b8f70e91fc16f. See also . I already reverted a7a91c01c and changed the other packages which used the same pattern ((sddm, ktouch, kdeconnect, kdevelop)) > Don't forget to re-indent the following lines=20 ACK. I did this in a separate commit to make the actual change more obvio= us. Pushed as fce8ec9e151..50bdf0043. --=20 Regards Hartmut Goebel | Hartmut Goebel | h.goebel@crazy-compilers.com | | www.crazy-compilers.com | compilers which you thought are impossible | --P3K2qNp5UvuIgexX6ZE10AR31P38N59hq-- --F0WiuIZdujmvM6yJSuMULxH30iWB3XU2Y Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- iQIzBAEBCAAdFiEE1K2LnBZ7dXxPCOh3e3UoEb93O2UFAl4A8HAACgkQe3UoEb93 O2XF1A//Ym3YtexU0Qwgv0kP3a5NQg09FU8mPyOwcbrl1i7JgKW9yplqRPGKpbY3 uvkv0NkQdbUexijY93jox1KUxTvTMa7CkBgj0UuXOdregqYpLSbt5DM/ucs+VllA D1kDeADn78x9j7WFNKebmPMZQyR2lRVGMjBKAR5p6A8anDv++6fo/fs9/Npi3p/Q wfta/GCqeGskeA4+7oj0xDskuadGv2gbKrQdBMOBhGdDnAEmQuSVtOzDpWuvcEAW As8KeAa8p/ERkRGZUgkcNjDny/oYzeyusmTemNTh2FcjAusIO8GtQlLrd3ci48xH 4p5iuLVhoKiKCCTUEU0zOmXKDEAyh/4gM13A9HR5to/xh3qgg0gjyN6KJyw01mMD jFIJc7Vy9uRbqN7fKSXz01EPP88lZeEJEHl/IOh1zQgo2S42Z/TW4F8jPE8g0Xua NtYoGQpy3pKU9kP6tVQ4lqWBxdpTQ3rwHhj0laNtKq2dDcHsK235D9+aIuxptD29 iXojIqFDR2dcwkQSK8uGjradIEfH9PRd/zM2Dh5kLN5e4oe/GdEGOWlu1OmNZxb5 4S+gs/iNCCcp3R4b+PQWV+vT9Z4ErQvT3LCIpVsZlV38xbuLI7qubKjny+b6q2No 2eebFYxuZJhO4UX53j6QafeiKB8rZJrnHCdjQCer56KLO8+Pl/Q= =/V9P -----END PGP SIGNATURE----- --F0WiuIZdujmvM6yJSuMULxH30iWB3XU2Y--