unofficial mirror of guix-patches@gnu.org 
 help / color / mirror / code / Atom feed
From: Maxime Devos <maximedevos@telenet.be>
To: Isaac Young <isyoung@pm.me>, 47399@debbugs.gnu.org
Subject: [bug#47399] [PATCH] Add Google's Highway library.
Date: Fri, 26 Mar 2021 10:17:24 +0100	[thread overview]
Message-ID: <1e082ec631688b4c1a561f85122cb852d2a03d20.camel@telenet.be> (raw)
In-Reply-To: <dOkQ4Y0u4ztu6Ahtsfp-i47XDozlW6iwGvbaOA8wVDmLKyhrwmL2lCmU8_-tCRcO8NeRRSeHEzIriOHB13IRNSWdBrZlbXzc3lQep4JNYEw=@pm.me>

[-- Attachment #1: Type: text/plain, Size: 1868 bytes --]

On Fri, 2021-03-26 at 00:54 +0000, Isaac Young via Guix-patches via wrote:
> Hello, 
> 
> I would like to add Google's highway library (https://github.com/google/highway) to guix officially. Any feedback will be greately apperciated as this is my first public package.

A commit message is missing from the patch.  E.g. something like

commit b09967bc587dd61c638da3d6fb5bbda7e87ed85c
Author: Raghav Gururajan <rg@raghavgururajan.name>
Date:   Sun Mar 7 01:47:19 2021 -0500

    gnu: Add psi-plus.
    
    * gnu/packages/messaging.scm (psi-plus): New variable.

(See 16.1 ‘Submitting Patches’ in the manual.)

You should add a ‘Copyright YEAR your-name’ as well at the top of the file.
There is no need to add ‘#:tests? #t’ as tests are enabled by default.

What's HWY_SYSTEM_GTEST=ON for?  Maybe add a comment

;; Prevent the configuration script from trying to download googletest
;; from the network.

or something like that.  Run "./pre-inst-env guix lint google-highway"
if you haven't already.

The "googletest" input does not make much sense when cross-compiling;
maybe move it to native-inputs with something like

  (native-inputs
   ,@(if (%current-target-system)
         '()
         ;; only used by the test suite
         `(("googletest" ,googletest))))

(See 8.2.1 ‘‘package’ reference’.)

(Admittedly, we don't focus much on making packages cross-compilable,
except for packages like gcc, bash, binutils ..., so no big problem
if this package isn't cross-compilable.)

Assuming you're on a system different from "aarch64-linux-gnu",
you can test cross-compilability with
"./pre-inst-env guix build --target=aarch64-linux-gnu google-highway".
(See 9.3.1 ‘Additional Build Options’)

Otherwise no comments, assuming it builds!

> Thank you,
> Isaac Young

Greetings,
Maxime.

[-- Attachment #2: This is a digitally signed message part --]
[-- Type: application/pgp-signature, Size: 260 bytes --]

  parent reply	other threads:[~2021-03-26  9:18 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-03-26  0:54 [bug#47399] [PATCH] Add Google's Highway library Isaac Young via Guix-patches via
2021-03-26  1:56 ` Isaac Young via Guix-patches via
2021-03-26  2:28 ` Isaac Young via Guix-patches via
2021-03-26  9:17 ` Maxime Devos [this message]
2022-02-07 15:30 ` bug#47399: " Vinicius Monego

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://guix.gnu.org/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1e082ec631688b4c1a561f85122cb852d2a03d20.camel@telenet.be \
    --to=maximedevos@telenet.be \
    --cc=47399@debbugs.gnu.org \
    --cc=isyoung@pm.me \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/guix.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).