From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp2 ([2001:41d0:8:6d80::]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) by ms0.migadu.com with LMTPS id SO8MOdSmXWB8eQAAgWs5BA (envelope-from ) for ; Fri, 26 Mar 2021 10:18:12 +0100 Received: from aspmx1.migadu.com ([2001:41d0:8:6d80::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp2 with LMTPS id 2Cf6MtSmXWDAJwAAB5/wlQ (envelope-from ) for ; Fri, 26 Mar 2021 09:18:12 +0000 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id 8BF0C33C98 for ; Fri, 26 Mar 2021 10:18:12 +0100 (CET) Received: from localhost ([::1]:55866 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1lPibb-0003hH-M9 for larch@yhetil.org; Fri, 26 Mar 2021 05:18:11 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:44030) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lPibS-0003gc-N7 for guix-patches@gnu.org; Fri, 26 Mar 2021 05:18:03 -0400 Received: from debbugs.gnu.org ([209.51.188.43]:57102) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1lPibS-0005jc-GR for guix-patches@gnu.org; Fri, 26 Mar 2021 05:18:02 -0400 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1lPibS-00085g-D5 for guix-patches@gnu.org; Fri, 26 Mar 2021 05:18:02 -0400 X-Loop: help-debbugs@gnu.org Subject: [bug#47399] [PATCH] Add Google's Highway library. Resent-From: Maxime Devos Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Fri, 26 Mar 2021 09:18:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 47399 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: Isaac Young , 47399@debbugs.gnu.org Received: via spool by 47399-submit@debbugs.gnu.org id=B47399.161675025631056 (code B ref 47399); Fri, 26 Mar 2021 09:18:02 +0000 Received: (at 47399) by debbugs.gnu.org; 26 Mar 2021 09:17:36 +0000 Received: from localhost ([127.0.0.1]:40414 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1lPib1-00084q-KT for submit@debbugs.gnu.org; Fri, 26 Mar 2021 05:17:36 -0400 Received: from michel.telenet-ops.be ([195.130.137.88]:50120) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1lPiaz-00084g-0k for 47399@debbugs.gnu.org; Fri, 26 Mar 2021 05:17:34 -0400 Received: from ptr-bvsjgyjmffd7q9timvx.18120a2.ip6.access.telenet.be ([IPv6:2a02:1811:8c09:9d00:aaf1:9810:a0b8:a55d]) by michel.telenet-ops.be with bizsmtp id kxHW2400P0mfAB406xHWs1; Fri, 26 Mar 2021 10:17:31 +0100 Message-ID: <1e082ec631688b4c1a561f85122cb852d2a03d20.camel@telenet.be> From: Maxime Devos Date: Fri, 26 Mar 2021 10:17:24 +0100 In-Reply-To: References: Content-Type: multipart/signed; micalg="pgp-sha256"; protocol="application/pgp-signature"; boundary="=-2MrxslVajYTMP+OMqUnV" User-Agent: Evolution 3.34.2 MIME-Version: 1.0 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=telenet.be; s=r21; t=1616750251; bh=KSlKFUu0GmesyX0w8VaAY/Q1mDKuc7oXZ+0vvi73FR4=; h=Subject:From:To:Date:In-Reply-To:References; b=u6dgQdTolPiTsrPnFu23KdN+i9dA9VH19iYRhN/wp7neu5ksRje+eSZdzRlyF10eG bl/gfF9JQNwPelbfP3StozALCgjkHNsYy0G6/2Sn6INFwS+iZ5t0X2H/+sJgk3N8iz Qjep4YcLGDfJXZo+fUCYOacJ8RPoyuTaW7qjkQJ2wXoBCx3jiK6esf3JxWt+9N6yPm SHfljnxy1XOKyV+t3E8mIeX5+V+zvoIRkgE+HsY9ZKu/X7YOEvutKucsKAAB2vpsKK uY5p/CPDP9EJHdyj6CnOAYA5IYsOguBz0mshPnCeYzUTDeKLd0tS7yI/eNSU5zqBHe UJrCjYz825cKA== X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: guix-patches@gnu.org List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+larch=yhetil.org@gnu.org Sender: "Guix-patches" X-Migadu-Flow: FLOW_IN ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1616750292; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:mime-version:mime-version: content-type:content-type:resent-cc:resent-from:resent-sender: resent-message-id:in-reply-to:in-reply-to:references:references: list-id:list-help:list-unsubscribe:list-subscribe:list-post: dkim-signature; bh=KSlKFUu0GmesyX0w8VaAY/Q1mDKuc7oXZ+0vvi73FR4=; b=ew7873Wy1p7iWUGV3s3xLvB0hkAv7CwxsOG9534YMy0RAEOUyB+Jsmnyl8WFt68qqo0tqf DQfqzVEp0DyFrL4O2o34x6+SRpNcv7CayqO9FOrurk/7ugdwBkbSO+0y+2pOmWsj5t2uTJ cULQbe0ehxfLQE6bk3Ot4UqDLA6yz0UTdvZJBs7uQXTRu2fWdmT5uUbkIBRkqvPwf8nvvJ h1x1auqaQLRZcqoUGfgzKl1HFt/dC51u6RpCJV0tMupYBk9XjK3p7Ju9Ickwuodh6LugQU UB454EtOiwbOjnCxR2m7QZV/rGuujsIDomw53hJEMuOPow7HAJ2GgbQadBS6ow== ARC-Seal: i=1; s=key1; d=yhetil.org; t=1616750292; a=rsa-sha256; cv=none; b=K9qEnKr2VloDSHOnVlGKuBQax6closJ7Oia4c8m8XxHv4arBlJqEEO4uKp6FGW0h/HenG2 jRskS2QR12GD+JMrelOc6DnqlfpWsWEUhZmgIAw1FRt5D3N1Vl0N0FrmimHE25fdW7qpep //OMCLp/PN/pX5xDERSqtJ7awjbWCfhWyiQkQuJ7PQ5D/FkrFAOOaG9ldvdvOE9OKuXdGa J+VH5E5fybKFHalK0LAG8jHjG5/07uxIGAWnEWWYQYIFVfu0wdxTApU6dAeeW5TVmt3O+c PYmLxhMO8gcuiN+iz1UwLo7ZzJ2OQiLSChWkEljDOQZGvM77JdqersPEwoptzg== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=telenet.be header.s=r21 header.b=u6dgQdTo; dmarc=fail reason="SPF not aligned (relaxed)" header.from=telenet.be (policy=none); spf=pass (aspmx1.migadu.com: domain of guix-patches-bounces@gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=guix-patches-bounces@gnu.org X-Migadu-Spam-Score: -3.42 Authentication-Results: aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=telenet.be header.s=r21 header.b=u6dgQdTo; dmarc=fail reason="SPF not aligned (relaxed)" header.from=telenet.be (policy=none); spf=pass (aspmx1.migadu.com: domain of guix-patches-bounces@gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=guix-patches-bounces@gnu.org X-Migadu-Queue-Id: 8BF0C33C98 X-Spam-Score: -3.42 X-Migadu-Scanner: scn0.migadu.com X-TUID: iSb/punPmHAG --=-2MrxslVajYTMP+OMqUnV Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable On Fri, 2021-03-26 at 00:54 +0000, Isaac Young via Guix-patches via wrote: > Hello,=20 >=20 > I would like to add Google's highway library (https://github.com/google/h= ighway) to guix officially. Any feedback will be greately apperciated as th= is is my first public package. A commit message is missing from the patch. E.g. something like commit b09967bc587dd61c638da3d6fb5bbda7e87ed85c Author: Raghav Gururajan Date: Sun Mar 7 01:47:19 2021 -0500 gnu: Add psi-plus. =20 * gnu/packages/messaging.scm (psi-plus): New variable. (See 16.1 =E2=80=98Submitting Patches=E2=80=99 in the manual.) You should add a =E2=80=98Copyright YEAR your-name=E2=80=99 as well at the = top of the file. There is no need to add =E2=80=98#:tests? #t=E2=80=99 as tests are enabled = by default. What's HWY_SYSTEM_GTEST=3DON for? Maybe add a comment ;; Prevent the configuration script from trying to download googletest ;; from the network. or something like that. Run "./pre-inst-env guix lint google-highway" if you haven't already. The "googletest" input does not make much sense when cross-compiling; maybe move it to native-inputs with something like (native-inputs ,@(if (%current-target-system) '() ;; only used by the test suite `(("googletest" ,googletest)))) (See 8.2.1 =E2=80=98=E2=80=98package=E2=80=99 reference=E2=80=99.) (Admittedly, we don't focus much on making packages cross-compilable, except for packages like gcc, bash, binutils ..., so no big problem if this package isn't cross-compilable.) Assuming you're on a system different from "aarch64-linux-gnu", you can test cross-compilability with "./pre-inst-env guix build --target=3Daarch64-linux-gnu google-highway". (See 9.3.1 =E2=80=98Additional Build Options=E2=80=99) Otherwise no comments, assuming it builds! > Thank you, > Isaac Young Greetings, Maxime. --=-2MrxslVajYTMP+OMqUnV Content-Type: application/pgp-signature; name="signature.asc" Content-Description: This is a digitally signed message part Content-Transfer-Encoding: 7bit -----BEGIN PGP SIGNATURE----- iI0EABYIADUWIQTB8z7iDFKP233XAR9J4+4iGRcl7gUCYF2mpBccbWF4aW1lZGV2 b3NAdGVsZW5ldC5iZQAKCRBJ4+4iGRcl7imuAQCYrnBWX26ot6ORpDnCYS9/2nvg loLIzcR33EfXpSaLjgD9HBpFxovZKcvv/dIG5z7v325R94KeEB6NiLGXpSIcuAg= =Ew0o -----END PGP SIGNATURE----- --=-2MrxslVajYTMP+OMqUnV--