* [bug#42751] [PATCH] gnu: Add cfunge. [not found] <1926083374.1509159.1596819760388.ref@mail.yahoo.com> @ 2020-08-07 17:02 ` Hendur Saga via Guix-patches via 2020-08-09 20:50 ` Jakub Kądziołka 0 siblings, 1 reply; 4+ messages in thread From: Hendur Saga via Guix-patches via @ 2020-08-07 17:02 UTC (permalink / raw) To: 42751 [-- Attachment #1.1: Type: text/plain, Size: 172 bytes --] I added a new file, esolangs.scm, because I could not find any other place to be more appropriate, for this and forthcoming packages. - Hendursaga [-- Attachment #1.2: Type: text/html, Size: 498 bytes --] [-- Warning: decoded text below may be mangled, UTF-8 assumed --] [-- Attachment #2: 0001-gnu-Add-cfunge.patch --] [-- Type: text/x-patch, Size: 2535 bytes --] From 2d3277c651754178d42ed1edded50375b74dc992 Mon Sep 17 00:00:00 2001 From: Hendursaga <hendursaga@yahoo.com> Date: Thu, 6 Aug 2020 18:43:20 +0000 Subject: [PATCH] gnu: Add cfunge. * gnu/packages/esolangs.scm (cfunge): New variable. --- gnu/packages/esolangs.scm | 49 +++++++++++++++++++++++++++++++++++++++ 1 file changed, 49 insertions(+) create mode 100644 gnu/packages/esolangs.scm diff --git a/gnu/packages/esolangs.scm b/gnu/packages/esolangs.scm new file mode 100644 index 0000000000..bc4918b226 --- /dev/null +++ b/gnu/packages/esolangs.scm @@ -0,0 +1,49 @@ +;;; GNU Guix --- Functional package management for GNU +;;; Copyright © 2020 Hendursaga <hendursaga@yahoo.com> +;;; +;;; This file is part of GNU Guix. +;;; +;;; GNU Guix is free software; you can redistribute it and/or modify it +;;; under the terms of the GNU General Public License as published by +;;; the Free Software Foundation; either version 3 of the License, or (at +;;; your option) any later version. +;;; +;;; GNU Guix is distributed in the hope that it will be useful, but +;;; WITHOUT ANY WARRANTY; without even the implied warranty of +;;; MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the +;;; GNU General Public License for more details. +;;; +;;; You should have received a copy of the GNU General Public License +;;; along with GNU Guix. If not, see <http://www.gnu.org/licenses/>. + +(define-module (gnu packages esolangs) + #:use-module (gnu packages ncurses) + #:use-module (guix build-system cmake) + #:use-module (guix download) + #:use-module (guix git-download) + #:use-module ((guix licenses) #:prefix license:) + #:use-module (guix packages)) + +(define-public cfunge + (package + (name "cfunge") + (version "0.9.0") + (source (origin + (method git-fetch) + (uri (git-reference + (url "https://github.com/VorpalBlade/cfunge") + (commit version))) + (file-name (git-file-name name version)) + (sha256 + (base32 + "18ir0h10vxdb5jb57w5hjbgi8spjxg9x2148agadhhmbhsja02m7")))) + (build-system cmake-build-system) + (arguments + '(#:tests? #f)) ; no make target 'test' + (inputs + `(("ncurses" ,ncurses))) + (home-page "https://github.com/VorpalBlade/cfunge") + (synopsis "Fast conforming Befunge93/98/109 interpreter in C") + (description "cfunge is a fast conforming Befunge93/98/109 interpreter written in C. +It supports several fingerprints.") + (license license:gpl2+))) -- 2.28.0 ^ permalink raw reply related [flat|nested] 4+ messages in thread
* [bug#42751] [PATCH] gnu: Add cfunge. 2020-08-07 17:02 ` [bug#42751] [PATCH] gnu: Add cfunge Hendur Saga via Guix-patches via @ 2020-08-09 20:50 ` Jakub Kądziołka 2020-08-15 17:21 ` Hendur Saga via Guix-patches via 0 siblings, 1 reply; 4+ messages in thread From: Jakub Kądziołka @ 2020-08-09 20:50 UTC (permalink / raw) To: Hendur Saga; +Cc: 42751 [-- Attachment #1: Type: text/plain, Size: 1751 bytes --] On Fri, Aug 07, 2020 at 05:02:40PM +0000, Hendur Saga wrote: > I added a new file, esolangs.scm, because I could not find any other place to be more appropriate, for this and forthcoming packages. Not a bad idea, though toys.scm somewhat fits. Please add the new file to the list in gnu/local.mk, though. Also, could you run your code through etc/indent-code.el? > + (arguments > + '(#:tests? #f)) ; no make target 'test' The repository does contain a tests/ folder, did you try running these? You can check the rgbds package from assembly.scm for some inspiration as to how you can handle a custom testsuite entrypoint. > + (inputs > + `(("ncurses" ,ncurses))) > + (home-page "https://github.com/VorpalBlade/cfunge") > + (synopsis "Fast conforming Befunge93/98/109 interpreter in C") > + (description "cfunge is a fast conforming Befunge93/98/109 interpreter written in C. @command{cfunge} > +It supports several fingerprints.") It would be nice to define what a fingerprint is, as even though there was once a summer when I was fluent in Befunge, I still needed a longer moment to recall what those are. How about this Texinfo markup? @dfn{fingerprints} (opt-in language extensions identified by a four-character code). > + (license license:gpl2+))) COPYING and the headers in src/*.c (well, I checked diagnostic.c) suggest that it's actually gpl3+, what gives? Could you send an updated patch? Regards, Jakub Kądziołka P.S. I tried to test the package by running this CGCC answer in it, but it loops infinitely. I didn't have time to debug this, so I don't know where the blame lies. https://codegolf.stackexchange.com/a/150920/55934 [-- Attachment #2: signature.asc --] [-- Type: application/pgp-signature, Size: 833 bytes --] ^ permalink raw reply [flat|nested] 4+ messages in thread
* [bug#42751] [PATCH] gnu: Add cfunge. 2020-08-09 20:50 ` Jakub Kądziołka @ 2020-08-15 17:21 ` Hendur Saga via Guix-patches via 2020-12-15 22:02 ` Leo Famulari 0 siblings, 1 reply; 4+ messages in thread From: Hendur Saga via Guix-patches via @ 2020-08-15 17:21 UTC (permalink / raw) To: Jakub Kądziołka; +Cc: 42751 [-- Attachment #1.1: Type: text/plain, Size: 2637 bytes --] Patch updated and attached. > The repository does contain a tests/ folder, did you try running these? I've ran pretty much all the tests and quite frankly, they are manual, human-graded tests. There is no unified way to tell if a test passed, etc. That might be why there is no test target. > How about this Texinfo markup? I modified your suggestion a little to more resemble the specs' language: http://quadium.net/funge/spec98.html > it's actually gpl3+, what gives? Mea culpa. I mistyped that. > I don't know where the blame lies. The tio.run links linked from those two Befunge-98 examples use the FBBI fingerprint, which currently isn't supported by cfunge. I tested a few examples from https://esolangs.org/wiki/Befunge and everything seems to work fine. On Sunday, August 9, 2020, 04:50:37 PM EDT, Jakub Kądziołka <kuba@kadziolka.net> wrote: On Fri, Aug 07, 2020 at 05:02:40PM +0000, Hendur Saga wrote: > I added a new file, esolangs.scm, because I could not find any other place to be more appropriate, for this and forthcoming packages. Not a bad idea, though toys.scm somewhat fits. Please add the new file to the list in gnu/local.mk, though. Also, could you run your code through etc/indent-code.el? > + (arguments > + '(#:tests? #f)) ; no make target 'test' The repository does contain a tests/ folder, did you try running these? You can check the rgbds package from assembly.scm for some inspiration as to how you can handle a custom testsuite entrypoint. > + (inputs > + `(("ncurses" ,ncurses))) > + (home-page "https://github.com/VorpalBlade/cfunge") > + (synopsis "Fast conforming Befunge93/98/109 interpreter in C") > + (description "cfunge is a fast conforming Befunge93/98/109 interpreter written in C. @command{cfunge} > +It supports several fingerprints.") It would be nice to define what a fingerprint is, as even though there was once a summer when I was fluent in Befunge, I still needed a longer moment to recall what those are. How about this Texinfo markup? @dfn{fingerprints} (opt-in language extensions identified by a four-character code). > + (license license:gpl2+))) COPYING and the headers in src/*.c (well, I checked diagnostic.c) suggest that it's actually gpl3+, what gives? Could you send an updated patch? Regards, Jakub Kądziołka P.S. I tried to test the package by running this CGCC answer in it, but it loops infinitely. I didn't have time to debug this, so I don't know where the blame lies. https://codegolf.stackexchange.com/a/150920/55934 [-- Attachment #1.2: Type: text/html, Size: 4714 bytes --] [-- Warning: decoded text below may be mangled, UTF-8 assumed --] [-- Attachment #2: 0001-gnu-Add-cfunge.patch --] [-- Type: text/x-patch, Size: 3142 bytes --] From a30d2ce2870964c78c82469750e5bc8a34a0a477 Mon Sep 17 00:00:00 2001 From: Hendursaga <hendursaga@yahoo.com> Date: Sat, 15 Aug 2020 17:05:57 +0000 Subject: [PATCH] gnu: Add cfunge. * gnu/packages/esolangs.scm: New file. * gnu/packages/esolangs.scm (cfunge): New variable. * gnu/local.mk: Add esolangs.scm. --- gnu/local.mk | 1 + gnu/packages/esolangs.scm | 50 +++++++++++++++++++++++++++++++++++++++ 2 files changed, 51 insertions(+) create mode 100644 gnu/packages/esolangs.scm diff --git a/gnu/local.mk b/gnu/local.mk index 27dcf965ca..2e320512d8 100644 --- a/gnu/local.mk +++ b/gnu/local.mk @@ -197,6 +197,7 @@ GNU_SYSTEM_MODULES = \ %D%/packages/enlightenment.scm \ %D%/packages/entr.scm \ %D%/packages/erlang.scm \ + %D%/packages/esolangs.scm \ %D%/packages/fabric-management.scm \ %D%/packages/fcitx.scm \ %D%/packages/figlet.scm \ diff --git a/gnu/packages/esolangs.scm b/gnu/packages/esolangs.scm new file mode 100644 index 0000000000..f9848799e3 --- /dev/null +++ b/gnu/packages/esolangs.scm @@ -0,0 +1,50 @@ +;;; GNU Guix --- Functional package management for GNU +;;; Copyright © 2020 Hendursaga <hendursaga@yahoo.com> +;;; +;;; This file is part of GNU Guix. +;;; +;;; GNU Guix is free software; you can redistribute it and/or modify it +;;; under the terms of the GNU General Public License as published by +;;; the Free Software Foundation; either version 3 of the License, or (at +;;; your option) any later version. +;;; +;;; GNU Guix is distributed in the hope that it will be useful, but +;;; WITHOUT ANY WARRANTY; without even the implied warranty of +;;; MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the +;;; GNU General Public License for more details. +;;; +;;; You should have received a copy of the GNU General Public License +;;; along with GNU Guix. If not, see <http://www.gnu.org/licenses/>. + +(define-module (gnu packages esolangs) + #:use-module (gnu packages ncurses) + #:use-module (guix build-system cmake) + #:use-module (guix download) + #:use-module (guix git-download) + #:use-module ((guix licenses) #:prefix license:) + #:use-module (guix packages)) + +(define-public cfunge + (package + (name "cfunge") + (version "0.9.0") + (source (origin + (method git-fetch) + (uri (git-reference + (url "https://github.com/VorpalBlade/cfunge") + (commit version))) + (file-name (git-file-name name version)) + (sha256 + (base32 + "18ir0h10vxdb5jb57w5hjbgi8spjxg9x2148agadhhmbhsja02m7")))) + (build-system cmake-build-system) + (arguments + '(#:tests? #f)) ; no make target 'test' + (inputs + `(("ncurses" ,ncurses))) + (home-page "https://github.com/VorpalBlade/cfunge") + (synopsis "Fast conforming Befunge93/98/109 interpreter in C") + (description "@command{cfunge} is a fast conforming Befunge93/98/109 interpreter +written in C. It supports several @dfn{fingerprints} (opt-in language extensions +identified by unique ID codes).") + (license license:gpl3+))) -- 2.28.0 ^ permalink raw reply related [flat|nested] 4+ messages in thread
* [bug#42751] [PATCH] gnu: Add cfunge. 2020-08-15 17:21 ` Hendur Saga via Guix-patches via @ 2020-12-15 22:02 ` Leo Famulari 0 siblings, 0 replies; 4+ messages in thread From: Leo Famulari @ 2020-12-15 22:02 UTC (permalink / raw) To: 42751; +Cc: Jakub Kądziołka, 42751-done On Sat, Aug 15, 2020 at 05:21:01PM +0000, Hendur Saga via Guix-patches via wrote: > Patch updated and attached. > > The repository does contain a tests/ folder, did you try running these? > I've ran pretty much all the tests and quite frankly, they are manual, human-graded tests. There is no unified way to tell if a test passed, etc. That might be why there is no test target. Okay, I rewrote the comment to explain this. > > it's actually gpl3+, what gives? > Mea culpa. I mistyped that. It's GPL-3 only. The copyright owner has reserved the right to relicense the software under later versions of the GPL: ------ * This program is free software: you can redistribute it and/or modify * it under the terms of the GNU General Public License as published by * the Free Software Foundation, either version 3 of the License, or * (at the proxy's option) any later version. Arvid Norlander is a * proxy who can decide which future versions of the GNU General Public * License can be used. ------ source: https://github.com/VorpalBlade/cfunge/blob/master/src/main.c#L6 > From a30d2ce2870964c78c82469750e5bc8a34a0a477 Mon Sep 17 00:00:00 2001 > From: Hendursaga <hendursaga@yahoo.com> > Date: Sat, 15 Aug 2020 17:05:57 +0000 > Subject: [PATCH] gnu: Add cfunge. > > * gnu/packages/esolangs.scm: New file. > * gnu/packages/esolangs.scm (cfunge): New variable. > * gnu/local.mk: Add esolangs.scm. Thanks! I tweaked the commit message and pushed as 0510ca15aa395ddd3daf0720b541662671bf14c3 > --- > gnu/local.mk | 1 + > gnu/packages/esolangs.scm | 50 +++++++++++++++++++++++++++++++++++++++ > 2 files changed, 51 insertions(+) > create mode 100644 gnu/packages/esolangs.scm > > diff --git a/gnu/local.mk b/gnu/local.mk > index 27dcf965ca..2e320512d8 100644 > --- a/gnu/local.mk > +++ b/gnu/local.mk > @@ -197,6 +197,7 @@ GNU_SYSTEM_MODULES = \ > %D%/packages/enlightenment.scm \ > %D%/packages/entr.scm \ > %D%/packages/erlang.scm \ > + %D%/packages/esolangs.scm \ > %D%/packages/fabric-management.scm \ > %D%/packages/fcitx.scm \ > %D%/packages/figlet.scm \ > diff --git a/gnu/packages/esolangs.scm b/gnu/packages/esolangs.scm > new file mode 100644 > index 0000000000..f9848799e3 > --- /dev/null > +++ b/gnu/packages/esolangs.scm > @@ -0,0 +1,50 @@ > +;;; GNU Guix --- Functional package management for GNU > +;;; Copyright ?? 2020 Hendursaga <hendursaga@yahoo.com> > +;;; > +;;; This file is part of GNU Guix. > +;;; > +;;; GNU Guix is free software; you can redistribute it and/or modify it > +;;; under the terms of the GNU General Public License as published by > +;;; the Free Software Foundation; either version 3 of the License, or (at > +;;; your option) any later version. > +;;; > +;;; GNU Guix is distributed in the hope that it will be useful, but > +;;; WITHOUT ANY WARRANTY; without even the implied warranty of > +;;; MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the > +;;; GNU General Public License for more details. > +;;; > +;;; You should have received a copy of the GNU General Public License > +;;; along with GNU Guix. If not, see <http://www.gnu.org/licenses/>. > + > +(define-module (gnu packages esolangs) > + #:use-module (gnu packages ncurses) > + #:use-module (guix build-system cmake) > + #:use-module (guix download) > + #:use-module (guix git-download) > + #:use-module ((guix licenses) #:prefix license:) > + #:use-module (guix packages)) > + > +(define-public cfunge > + (package > + (name "cfunge") > + (version "0.9.0") > + (source (origin > + (method git-fetch) > + (uri (git-reference > + (url "https://github.com/VorpalBlade/cfunge") > + (commit version))) > + (file-name (git-file-name name version)) > + (sha256 > + (base32 > + "18ir0h10vxdb5jb57w5hjbgi8spjxg9x2148agadhhmbhsja02m7")))) > + (build-system cmake-build-system) > + (arguments > + '(#:tests? #f)) ; no make target 'test' > + (inputs > + `(("ncurses" ,ncurses))) > + (home-page "https://github.com/VorpalBlade/cfunge") > + (synopsis "Fast conforming Befunge93/98/109 interpreter in C") > + (description "@command{cfunge} is a fast conforming Befunge93/98/109 interpreter > +written in C. It supports several @dfn{fingerprints} (opt-in language extensions > +identified by unique ID codes).") > + (license license:gpl3+))) > -- > 2.28.0 > ^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2020-12-15 22:03 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
[not found] <1926083374.1509159.1596819760388.ref@mail.yahoo.com>
2020-08-07 17:02 ` [bug#42751] [PATCH] gnu: Add cfunge Hendur Saga via Guix-patches via
2020-08-09 20:50 ` Jakub Kądziołka
2020-08-15 17:21 ` Hendur Saga via Guix-patches via
2020-12-15 22:02 ` Leo Famulari
Code repositories for project(s) associated with this public inbox https://git.savannah.gnu.org/cgit/guix.git This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).