From: julien lepiller <julien@lepiller.eu>
To: 28723@debbugs.gnu.org
Subject: [bug#28723] Add HDF-Java. [PATCH 1/2] gnu: Add java-slf4-simple.
Date: Tue, 10 Oct 2017 10:18:44 +0200 [thread overview]
Message-ID: <184aac76e16750f0d225cde722a20115@inria.fr> (raw)
In-Reply-To: <20171009192509.GA21287@jasmine.lan>
Le 2017-10-09 21:25, Leo Famulari a écrit :
> On Fri, Oct 06, 2017 at 06:01:53PM +0200, Thomas Danckaert wrote:
>> Hi Guix,
>>
>> this patch adds the “Simple” implementation of the SLF4J interface,
>> used by
>> HDF-Java's tests.
>>
>> About this patch: the tests of slf4j-simple require some of
>> slf4j-api's test
>> code, which are therefore compiled in a somewhat ad-hoc fashion, but
>> it
>> works...
>>
>> Thomas
>
>> From d034b46040d51b7e82fb95df3601dc9925fa1502 Mon Sep 17 00:00:00 2001
>> From: Thomas Danckaert <post@thomasdanckaert.be>
>> Date: Fri, 6 Oct 2017 12:38:34 +0200
>> Subject: [PATCH 1/2] gnu: Add java-slf4-simple.
>>
>> * gnu/packages/java.scm (java-slf4j-simple): New variable.
>
> Okay, looks good to me!
I don't know whether it's better, but I had to build slf4j-simple for
maven. Here is what I have:
(define java-slf4j-api-tests
(package
(inherit java-slf4j-api)
(name "java-slf4j-api-tests")
(arguments
`(#:jar-name "slf4j-api-tests.jar"
#:source-dir "slf4j-api/src/test/java"
#:tests? #f))
(inputs
`(("slf4j" ,java-slf4j-api)
,@(package-inputs java-slf4j-api)
,@(package-native-inputs java-slf4j-api)))
(native-inputs '())))
(define-public java-slf4j-simple
(package
(inherit java-slf4j-api)
(name "java-slf4j-simple")
(arguments
`(#:jar-name "slf4j-simple.jar"
#:source-dir "slf4j-simple/src/main/java"
#:test-dir "slf4j-simple/src/test"))
(inputs
`(("slf4j" ,java-slf4j-api)
,@(package-inputs java-slf4j-api)))
(native-inputs
`(("tests" ,java-slf4j-api-tests)
,@(package-native-inputs java-slf4j-api)))))
The idea is that maybe other packages in the slf4j archive will need
these tests, so I built a package for them.
Otherwise your version LGTM too. Why do you need to build in the current
directory and not in build/test-classes? If you build in
build/test-classes, I think you don't need to set CLASSPATH in the
build-slf4j-api-test-helpers phase.
next prev parent reply other threads:[~2017-10-10 8:19 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-10-06 16:01 [bug#28723] Add HDF-Java. [PATCH 1/2] gnu: Add java-slf4-simple Thomas Danckaert
2017-10-06 16:20 ` [bug#28723] [PATCH 2/2] gnu: Add hdf-java Thomas Danckaert
2017-10-09 19:27 ` Leo Famulari
2017-10-10 6:48 ` Thomas Danckaert
2017-10-09 19:25 ` [bug#28723] Add HDF-Java. [PATCH 1/2] gnu: Add java-slf4-simple Leo Famulari
2017-10-10 8:18 ` julien lepiller [this message]
2017-10-10 8:31 ` bug#28723: (no subject) Thomas Danckaert
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://guix.gnu.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=184aac76e16750f0d225cde722a20115@inria.fr \
--to=julien@lepiller.eu \
--cc=28723@debbugs.gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/guix.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).